Skip to content

Bump rust version to fix failure for dependency update (cryptography)#23672

Open
HadhemiDD wants to merge 3 commits into
masterfrom
hs/update-rust
Open

Bump rust version to fix failure for dependency update (cryptography)#23672
HadhemiDD wants to merge 3 commits into
masterfrom
hs/update-rust

Conversation

@HadhemiDD
Copy link
Copy Markdown
Contributor

What does this PR do?

Updating the dependencies PR is failing due to old rust version, bumping the rust version for linux and windows.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 11, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.


# Rust toolchain (needed for cryptography)
ENV RUST_VERSION="1.76"
ENV RUST_VERSION="1.83.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to match the rust version used in datadog-agent?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datadog agent rust version is already at 1.91

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aiuto, as a side note, they do not need to match. These are just used because cryptography is included built by ourselves in the wheels we ship but should be disconnected from the rust version in the agent.

I would propose to hold off on this PR until we branch of for the release starting tomorrow. Unless we need any of the dependency bumps to address a CVE. I am checking that to consider whether these should be merged now or they can wait until we branch off for 7.80.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 12, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants