Bump rust version to fix failure for dependency update (cryptography)#23672
Bump rust version to fix failure for dependency update (cryptography)#23672HadhemiDD wants to merge 3 commits into
Conversation
|
This PR does not modify any files shipped with the agent. To help streamline the release process, please consider adding the |
|
|
||
| # Rust toolchain (needed for cryptography) | ||
| ENV RUST_VERSION="1.76" | ||
| ENV RUST_VERSION="1.83.0" |
There was a problem hiding this comment.
Does this have to match the rust version used in datadog-agent?
There was a problem hiding this comment.
The datadog agent rust version is already at 1.91
There was a problem hiding this comment.
@aiuto, as a side note, they do not need to match. These are just used because cryptography is included built by ourselves in the wheels we ship but should be disconnected from the rust version in the agent.
I would propose to hold off on this PR until we branch of for the release starting tomorrow. Unless we need any of the dependency bumps to address a CVE. I am checking that to consider whether these should be merged now or they can wait until we branch off for 7.80.
Validation ReportAll 20 validations passed. Show details
|
What does this PR do?
Updating the dependencies PR is failing due to old rust version, bumping the rust version for linux and windows.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged