Add New External DNS Metrics: controller.consecutive.soft.errors & controller.last_reconcile#23671
Add New External DNS Metrics: controller.consecutive.soft.errors & controller.last_reconcile#23671ddog-nasirthomas wants to merge 4 commits into
Conversation
…l_dns_controller_last_reconcile_timestamp_seconds
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 2405a17 | Docs | Datadog PR Page | Give us feedback! |
Validation ReportAll 20 validations passed. Show details
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2405a17293
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| Added metrics external_dns.controller.last_reconcile & external_dns.controller.consecutive.soft.errors | |||
There was a problem hiding this comment.
End the changelog fragment with a period
The root AGENTS.md changelog instructions require each entry to be a single line that ends with a period. This new fragment currently lacks the trailing period, so it violates the repository's documented changelog format for shipped Agent changes.
Useful? React with 👍 / 👎.
What does this PR do?
Adds two new metrics controller.consecutive.soft.errors & controller.last_reconcile
Verified the metrics with this documentation: https://kubernetes-sigs.github.io/external-dns/latest/docs/monitoring/metrics/#supported-metrics
Motivation
Customer FR
https://datadoghq.atlassian.net/browse/FRAGENT-3558
https://datadoghq.atlassian.net/browse/FRAGENT-3559
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged