[ddev] Retry agent check on transient failure to fix SNMP E2E flake#23646
[ddev] Retry agent check on transient failure to fix SNMP E2E flake#23646Kyle-Neale wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: bd4527c | Docs | Datadog PR Page | Give us feedback! |
0102e1e to
ee648c2
Compare
c3d50af to
f277b75
Compare
f277b75 to
bd4527c
Compare
Validation ReportAll 20 validations passed. Show details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd4527ce4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| Retry agent check invocations on transient failures to address SNMP E2E flake from autodiscovery reload races No newline at end of file | |||
There was a problem hiding this comment.
End the changelog entry with a period
The repository instructions in AGENTS.md say changelog entries should be a single line that ends with a period. This new entry currently has no trailing period, so it violates the documented changelog format and should be updated before merging.
Useful? React with 👍 / 👎.
What does this PR do?
Wraps
agent checkinvocations inddev env agentwith a bounded retry (3 attempts, 0.5s backoff).Motivation
Mitigates the SNMP master.yml E2E flake (
no valid check found) — a brief race in the existing E2E config-swap path where autodiscovery can deregister the check between the swap and the immediateagent checkcall. ~44% of recent master SNMP runs hit this; >99% of tests still pass within failing runs.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and itwill automatically open a backport PR once this one is merged