Phase 2: HTTPXWrapper initial implementation

[mwdd146980]

What does this PR do?

Implements Phase 2 of the requests → httpx migration (Phase 1: PR #22676).

New: http_httpx.py

• HTTPXWrapper — wraps httpx.Client, satisfies HTTPClientProtocol, translates httpx exceptions to the HTTPError hierarchy
• HTTPXResponseAdapter — bridges httpx.Response to HTTPResponseProtocol: adds iter_content (httpx uses iter_bytes/iter_text), adapts iter_lines signature, and adds __enter__/__exit__ (httpx responses aren't context managers)
• Exception translation at the request boundary: httpx.TimeoutException → HTTPTimeoutError, httpx.ConnectError → HTTPConnectionError, etc.

New: use_httpx feature flag in AgentCheck.http

• Set use_httpx: true in instance config to opt a check into the httpx backend
• All integrations using self.http get the flag for free; no call-site changes required
• Default remains RequestsWrapper

Proof of concept: nginx

• test_get_enabled_endpoints and test_only_query_enabled_endpoints now run with both [requests] and [httpx] backends — all pass
• Tests that patch requests.Session directly (test_config, test_no_version) are left on the requests backend; they document the config parity gap (auth/SSL forwarding to httpx.Client) deferred to Phase 3

Backend equivalence tests

• test_http_backend_equivalence.py: RequestsWrapper and HTTPXWrapper produce identical responses for status_code, content, iter_lines, iter_content, and context manager usage

Known limitations (Phase 3 work)

HTTPXWrapper currently wraps a plain httpx.Client(). Instance config options (auth, TLS, proxy, timeouts) are not yet forwarded to the httpx client. Integrations that rely on test_config-style assertions against requests.Session kwargs will need per-integration follow-up once config parity is implemented.

Motivation

RFC: Migrate the HTTP layer from requests to httpx

Phase 1 established the protocol boundary. Phase 2 provides the httpx implementation and the opt-in mechanism.

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
• If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

[mwdd146980]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Add Kerberos and NTLM auth adapters for HTTPXWrapper #22706
• Forward instance config (auth, TLS, timeout, proxy, headers) to HTTPXWrapper #22705
• Phase 2: HTTPXWrapper initial implementation #22704 👈 (View in Graphite)
• Feature branch for httpx migration #22676 : 7 other dependent PRs (#22710 , #22722 , #22864 and 4 others)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

❌ Patch coverage is 97.12919% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.90%. Comparing base (bd007a7) to head (033d0b2).

Additional details and impacted files

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mwdd146980]

Code review

Found 2 issues:

1. Non-HTTPError httpx exceptions (e.g. httpx.InvalidURL) bypass the translation layer and leak as raw httpx exceptions. _request only catches httpx.HTTPError, but httpx.InvalidURL inherits directly from Exception — not from httpx.HTTPError. A malformed URL in instance config will surface as a raw httpx.InvalidURL rather than an HTTPError subclass, breaking any caller that catches the project's exception hierarchy.

integrations-core/datadog_checks_base/datadog_checks/base/utils/http_httpx.py

Lines 71 to 76 in ffda003

	def _request(self, method: str, url: str, **options: Any) -> HTTPXResponseAdapter:
	try:
	return HTTPXResponseAdapter(self._client.request(method, url, **options))
	except httpx.HTTPError as e:
	raise _translate_httpx_error(e) from e

2. HTTPXWrapper never closes its httpx.Client, leaking file descriptors in long-running Agent processes. HTTPXWrapper has no close() method or __enter__/__exit__, and AgentCheck has no teardown that releases self._http. RequestsWrapper handles this via __del__ calling self._session.close() (see http.py L639–645), but the httpx wrapper has no equivalent. httpx.Client pools connections and requires explicit cleanup.

integrations-core/datadog_checks_base/datadog_checks/base/utils/http_httpx.py

Lines 67 to 70 in ffda003

	class HTTPXWrapper:
	def __init__(self, client: httpx.Client) -> None:
	self._client = client

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[datadog-official]

✨ Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1 Test failed

❄️ Known flaky: test_e2e_profile_cisco_asa from test_e2e_core_vs_python.py     (Fix with Cursor)

[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 01-check-apikey.sh: executing... 
[cont-init.d] 01-check-apikey.sh: exited 0.
[cont-init.d] 50-ci.sh: executing... 
[cont-init.d] 50-ci.sh: exited 0.
[cont-init.d] 50-ecs-managed.sh: executing... 
...

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 84.83% (+0.04%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 033d0b2 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Validation Report

All 20 validations passed.

Show details

Validation	Description	Status
agent-reqs	Verify check versions match the Agent requirements file	✅
ci	Validate CI configuration and Codecov settings	✅
codeowners	Validate every integration has a CODEOWNERS entry	✅
config	Validate default configuration files against spec.yaml	✅
dep	Verify dependency pins are consistent and Agent-compatible	✅
http	Validate integrations use the HTTP wrapper correctly	✅
imports	Validate check imports do not use deprecated modules	✅
integration-style	Validate check code style conventions	✅
jmx-metrics	Validate JMX metrics definition files and config	✅
labeler	Validate PR labeler config matches integration directories	✅
legacy-signature	Validate no integration uses the legacy Agent check signature	✅
license-headers	Validate Python files have proper license headers	✅
licenses	Validate third-party license attribution list	✅
metadata	Validate metadata.csv metric definitions	✅
models	Validate configuration data models match spec.yaml	✅
openmetrics	Validate OpenMetrics integrations disable the metric limit	✅
package	Validate Python package metadata and naming	✅
readmes	Validate README files have required sections	✅
saved-views	Validate saved view JSON file structure and fields	✅
version	Validate version consistency between package and changelog	✅

View full run

[mwdd146980]

Closing as stale — will reintroduce when httpx migration base lands.