Skip to content

[TEST] Demo changes for incorporate-pr-feedback skill #35261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buraizu wants to merge 1 commit into from
+9 −3
Closed

[TEST] Demo changes for incorporate-pr-feedback skill #35261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions content/en/getting_started/integrations/aws.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@

## Overview

This guide walks you through integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. After completing setup, you can enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding.
Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'will walk' uses a temporal word ('will'). Revert to present tense: "This guide walks you through..."

Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'Once you have completed setup' — use 'After you complete setup' instead. Also, 'easily' should be removed (Vale: words to avoid).

Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'will walk' uses a temporal word. Switch to present tense: "This guide walks you through..."

Also, 'Once you have completed setup' → 'After you complete setup' (Vale: use 'After' instead of 'Once').

Also, remove 'easily' — it's a filler word per the style guide.

Also, 'to ensure that all your data is collected' — 'ensure' should be avoided or replaced with 'helps ensure'. Consider simplifying: end the sentence at 'configure log forwarding.'

This guide will walk you through the process of integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. Once you have completed setup, you can easily enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding to ensure that all your data is collected.

Check warning on line 36 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use 'helps' or 'helps ensure' instead of 'ensure'.

Check warning on line 36 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use '' instead of 'easily'.

Check notice on line 36 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.sentencelength 

Suggestion: Try to keep your sentence length to 25 words or fewer.

Check warning on line 36 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use 'after you' instead of 'Once you'.

Check warning on line 36 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_sensitive 

Use 'After' instead of 'Once'.

Check warning on line 36 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.tense 

Avoid temporal words like 'will'.
Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale (multiple): Several issues on this line:

  1. 'will walk' uses a temporal word ('will'). Revert to present tense: 'This guide walks you through...'
  2. 'Once you have completed setup' → 'After you complete setup' ('Once' is flagged; use 'After')
  3. Remove 'easily' — filler word per the Datadog style guide
  4. 'to ensure that all your data is collected' — remove; it's redundant padding. End the sentence at 'configure log forwarding.'

Suggested rewrite: 'This guide walks you through integrating an Amazon Web Services (AWS) account with Datadog using Datadog's CloudFormation template. After completing setup, you can enable individual AWS service integrations, install the Datadog Agent on EC2 instances for deeper visibility, and configure log forwarding.'


## Prerequisites

Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'Note that' should be replaced with 'Note:' per the Datadog style guide.

Also, the additional clause 'and administrative access to your AWS console' is useful context — keep it.

Before you begin, ensure that you have an [AWS][7] account. The CloudFormation template creates an IAM role and associated policy, allowing Datadog's AWS account to make API calls to your AWS account to collect and push data. Your AWS user must have the following IAM permissions to run the template:
Before you begin, ensure you have an [AWS][7] account and administrative access to your AWS console. The CloudFormation template creates an IAM role and associated policy, allowing Datadog's AWS account to make API calls to your AWS account to collect and push data. Note that your AWS user must have the following IAM permissions to run the template:

Check warning on line 40 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use '**Note**:' instead of 'Note that'.

Check notice on line 40 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.sentencelength 

Suggestion: Try to keep your sentence length to 25 words or fewer.

Check warning on line 40 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use 'helps' or 'helps ensure' instead of 'ensure'.
Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'Note that' should be replaced with 'Note:' — this is a direct Vale violation per the Datadog style guide.

Change to: 'Note: Your AWS user must have the following IAM permissions to run the template:'


{{% collapse-content title="Required IAM permissions" level="h4" expanded=false id="iam-permissions" %}}
- cloudformation:CreateStack
Expand Down Expand Up @@ -130,15 +130,21 @@

Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content: The 'Tag filtering' section uses several flagged phrases:

  • 'leverage' → use 'use'
  • 'utilizing' → use 'using'
  • 'easily' → remove
  • 'fine-tune' → use 'customize'

Suggested rewrite: "Use tag-based filtering to control which AWS resources Datadog monitors. Under the Metric Collection tab, add tag filters to include or exclude specific resources and customize your monitoring scope."

Under the **General** tab on the [AWS integration page][8], you can control the AWS regions where Datadog collects metrics, CloudWatch events, and resources.

### Tag filtering

Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale (multiple): The new 'Tag filtering' section has several style guide violations:

  1. 'leverage' → 'use'
  2. 'utilizing' → 'using'
  3. 'easily' → remove
  4. 'fine-tune' → 'customize'

Suggested rewrite:

'Use tag-based filtering to control which AWS resources Datadog monitors. Add tag filters under the Metric Collection tab to include or exclude specific resources and customize your monitoring scope.'

You can leverage tag-based filtering to control which AWS resources Datadog monitors. By utilizing tag filters under the **Metric Collection** tab, you can easily include or exclude specific resources. This allows you to fine-tune your monitoring setup to only collect metrics from the resources that matter to your team.

Check warning on line 135 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use 'customize', 'optimize', or 'refine' instead of 'fine-tune'.

Check warning on line 135 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use '' instead of 'easily'.

Check warning on line 135 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.words_case_insensitive 

Use 'use', 'apply', or 'take advantage of' instead of 'leverage'.

## Send logs

Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: 'simplest' is a superlative that implies ease — avoid these per the style guide. Change to something more factual: 'This option requires no additional infrastructure.'

There are two ways to send AWS service logs to Datadog:
Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale: 'simplest' — avoid superlatives like 'simplest'. Consider: 'This option requires no additional infrastructure.'


- [Amazon Data Firehose destination][10]: Recommended for high-volume CloudWatch logs.
- [Amazon Data Firehose destination][10]: Recommended for high-volume CloudWatch logs. This is the simplest option and requires no additional infrastructure.
- [Forwarder Lambda function][11]: Required for traces, enhanced metrics, or custom metrics from Lambda functions. Also recommended for logs from S3 or other resources that cannot stream directly to Amazon Data Firehose.
Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale + Style: Multiple issues in this tip:

  • 'currently' is a temporal word — remove it
  • 'easier to set up' — avoid comparatives like 'easier'; be specific instead
  • The tip format ('Tip:') is non-standard for this doc site — use a 'Note:' callout or incorporate the guidance into the bullet list above instead.


See [Enable logging for your AWS service][14] for setup instructions.

**Tip**: If you are currently unsure which method to use, start with the Amazon Data Firehose destination, as it is easier to set up and maintain.

Check notice on line 146 in content/en/getting_started/integrations/aws.md

View workflow job for this annotation

GitHub Actions / vale

Datadog.sentencelength 

Suggestion: Try to keep your sentence length to 25 words or fewer.
Copy link
Contributor Author

@buraizu buraizu Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vale + Structure: Several issues with this tip:

  1. 'currently' is a temporal word — remove it ('If you are unsure which method to use...')
  2. 'easier' is a comparative that implies simplicity — be specific instead (e.g., 'requires less configuration')
  3. 'Tip:' is a non-standard callout format for this site. Either use 'Note:' or fold this guidance into the bullet list above as a note on the Firehose option.


### Validation

Once you have enabled logs, find them in the [Log Explorer][15] using either the `source` or `service` facets from the facet panel, such as this example from S3:
Expand Down
Loading