fix(appsec): use length-aware libddwaf bindings to prevent NUL byte truncation#18128
Closed
KowalskiThomas wants to merge 1 commit into
Closed
Conversation
Codeowners resolved as |
BenchmarksBenchmark execution time: 2026-05-18 08:54:31 Comparing candidate commit 564f5de in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 78 metrics, 0 unstable metrics. scenario:iastaspectsospath-ospathbasename_aspect
|
Contributor
|
This is currently not an issue for our product, this PR should be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates
ddwaf_object_map_addlto take a new string length parameter. Previously, due to using rawstrlento detect the string length, it would stop at the first null byte in the input, even if the string was actually longer.Depends on: DataDog/libddwaf#493