Resolve Hibernate test DTDs from classpath.#11292
Resolve Hibernate test DTDs from classpath.#11292gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom
Conversation
AlexeyKuznetsov-DD
added
type: bug
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 4ee2247
into
master
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
alexeyk/hibernate-fix-revisited
branch
2 participants
What Does This Do
Updates Hibernate instrumentation test
hibernate.cfg.xmlfiles to reference the Hibernate configuration DTD viaclasspath://org/hibernate/hibernate-configuration-3.0.dtdinstead of an HTTP URL.Motivation
Hibernate 3.3 only resolves some DTD system IDs locally. When the resolver does not recognize the HTTP URL, SAX parsing falls back to opening the external DTD over the network, which can hang tests in CI.
Using
classpath://makes DTD resolution explicit and avoids network access during test setup.Additional Notes
Previous attempt in #11177 failed because older versions of Hibernate require a different URL to fall back to local resolution. Therefore, it’s better to explicitly specify where the DTD should be resolved from.
Verified locally with:
./gradlew :dd-java-agent:instrumentation:hibernate:hibernate-core-3.3:test