Add helper script to help review pull request titles#11281
Add helper script to help review pull request titles#11281PerfectSlayer wants to merge 1 commit intomasterfrom
Conversation
PerfectSlayer
added
tag: no release notes
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d972a9d6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| local t="$1" | ||
| local reasons=() | ||
| if [[ "$t" =~ $CONVENTIONAL_COMMIT_PREFIX_RE ]]; then | ||
| reasons+=("conventional-commit prefix") |
There was a problem hiding this comment.
When a PR title starts with an emoji or numeric prefix, such as the repository's mirror/cherry-pick style 🪞 10020 - ... or 🍒 9935 - ..., strip_prefixes leaves the prefix in place and this check does not fire because the first character is not lowercase. The script then counts those titles as OK even though the CONTRIBUTING title format requires a sentence starting with an infinitive verb, so an obvious release-note title violation can be missed instead of being presented for correction.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I'm good with those ones
1 participant
What Does This Do
This PR adds my helper script to review the PR titles before making a PR.
It is not bullet proof but help saving time. It is not automatic on purpose and the goal is to highlight issues faster, come up with suggestion to fix them, and apply the fix without having to rely and the GitHub PR or milestone page which struggle with pagination.
Motivation
I used to do it manually but the increase count of PR by milestone makes it tedious.
Additionally, AI review (or worse, AI fix) is usually pretty bad and not helping to capture meaningful changelog.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.