Rename request body sampling env var#11162
Open
manuel-alvarez-alvarez wants to merge 2 commits intomasterfrom
Open
Rename request body sampling env var#11162manuel-alvarez-alvarez wants to merge 2 commits intomasterfrom
manuel-alvarez-alvarez wants to merge 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066598
Total [baseline] (8.871 s) : 0, 8870883
Agent [candidate] (1.055 s) : 0, 1054533
Total [candidate] (8.877 s) : 0, 8877165
section iast
Agent [baseline] (1.232 s) : 0, 1231571
Total [baseline] (9.557 s) : 0, 9556621
Agent [candidate] (1.236 s) : 0, 1235654
Total [candidate] (9.534 s) : 0, 9533679
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.247 ms) : 0, 1247
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (642.578 ms) : 0, 642578
BytebuddyAgent [candidate] (634.835 ms) : 0, 634835
AgentMeter [baseline] (29.846 ms) : 0, 29846
AgentMeter [candidate] (29.483 ms) : 0, 29483
GlobalTracer [baseline] (251.355 ms) : 0, 251355
GlobalTracer [candidate] (248.456 ms) : 0, 248456
AppSec [baseline] (32.69 ms) : 0, 32690
AppSec [candidate] (32.191 ms) : 0, 32191
Debugger [baseline] (60.092 ms) : 0, 60092
Debugger [candidate] (59.298 ms) : 0, 59298
Remote Config [baseline] (605.734 µs) : 0, 606
Remote Config [candidate] (592.265 µs) : 0, 592
Telemetry [baseline] (8.134 ms) : 0, 8134
Telemetry [candidate] (8.798 ms) : 0, 8798
Flare Poller [baseline] (3.667 ms) : 0, 3667
Flare Poller [candidate] (3.581 ms) : 0, 3581
section iast
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (810.221 ms) : 0, 810221
BytebuddyAgent [candidate] (811.768 ms) : 0, 811768
AgentMeter [baseline] (11.326 ms) : 0, 11326
AgentMeter [candidate] (11.438 ms) : 0, 11438
GlobalTracer [baseline] (239.106 ms) : 0, 239106
GlobalTracer [candidate] (240.723 ms) : 0, 240723
AppSec [baseline] (27.4 ms) : 0, 27400
AppSec [candidate] (31.392 ms) : 0, 31392
Debugger [baseline] (63.686 ms) : 0, 63686
Debugger [candidate] (62.727 ms) : 0, 62727
Remote Config [baseline] (534.529 µs) : 0, 535
Remote Config [candidate] (521.293 µs) : 0, 521
Telemetry [baseline] (7.692 ms) : 0, 7692
Telemetry [candidate] (7.822 ms) : 0, 7822
Flare Poller [baseline] (3.421 ms) : 0, 3421
Flare Poller [candidate] (3.423 ms) : 0, 3423
IAST [baseline] (30.905 ms) : 0, 30905
IAST [candidate] (28.587 ms) : 0, 28587
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059093
Total [baseline] (11.119 s) : 0, 11118971
Agent [candidate] (1.064 s) : 0, 1063770
Total [candidate] (10.989 s) : 0, 10989117
section appsec
Agent [baseline] (1.273 s) : 0, 1272649
Total [baseline] (11.076 s) : 0, 11075771
Agent [candidate] (1.272 s) : 0, 1271984
Total [candidate] (11.126 s) : 0, 11125826
section iast
Agent [baseline] (1.238 s) : 0, 1238146
Total [baseline] (11.25 s) : 0, 11250303
Agent [candidate] (1.238 s) : 0, 1238065
Total [candidate] (11.323 s) : 0, 11323282
section profiling
Agent [baseline] (1.183 s) : 0, 1183201
Total [baseline] (11.01 s) : 0, 11010095
Agent [candidate] (1.185 s) : 0, 1184944
Total [candidate] (11.083 s) : 0, 11083368
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.255 ms) : 0, 1255
crashtracking [candidate] (1.251 ms) : 0, 1251
BytebuddyAgent [baseline] (636.471 ms) : 0, 636471
BytebuddyAgent [candidate] (639.519 ms) : 0, 639519
AgentMeter [baseline] (29.517 ms) : 0, 29517
AgentMeter [candidate] (29.687 ms) : 0, 29687
GlobalTracer [baseline] (249.139 ms) : 0, 249139
GlobalTracer [candidate] (249.951 ms) : 0, 249951
AppSec [baseline] (32.299 ms) : 0, 32299
AppSec [candidate] (32.14 ms) : 0, 32140
Debugger [baseline] (60.39 ms) : 0, 60390
Debugger [candidate] (59.875 ms) : 0, 59875
Remote Config [baseline] (598.206 µs) : 0, 598
Remote Config [candidate] (591.087 µs) : 0, 591
Telemetry [baseline] (8.001 ms) : 0, 8001
Telemetry [candidate] (8.795 ms) : 0, 8795
Flare Poller [baseline] (5.187 ms) : 0, 5187
Flare Poller [candidate] (5.757 ms) : 0, 5757
section appsec
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (684.017 ms) : 0, 684017
BytebuddyAgent [candidate] (680.402 ms) : 0, 680402
AgentMeter [baseline] (12.423 ms) : 0, 12423
AgentMeter [candidate] (12.414 ms) : 0, 12414
GlobalTracer [baseline] (251.048 ms) : 0, 251048
GlobalTracer [candidate] (251.1 ms) : 0, 251100
AppSec [baseline] (187.301 ms) : 0, 187301
AppSec [candidate] (187.934 ms) : 0, 187934
Debugger [baseline] (64.131 ms) : 0, 64131
Debugger [candidate] (65.747 ms) : 0, 65747
Remote Config [baseline] (578.0 µs) : 0, 578
Remote Config [candidate] (595.567 µs) : 0, 596
Telemetry [baseline] (7.761 ms) : 0, 7761
Telemetry [candidate] (7.973 ms) : 0, 7973
Flare Poller [baseline] (3.415 ms) : 0, 3415
Flare Poller [candidate] (3.514 ms) : 0, 3514
IAST [baseline] (24.217 ms) : 0, 24217
IAST [candidate] (24.543 ms) : 0, 24543
section iast
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (813.439 ms) : 0, 813439
BytebuddyAgent [candidate] (812.704 ms) : 0, 812704
AgentMeter [baseline] (11.423 ms) : 0, 11423
AgentMeter [candidate] (11.474 ms) : 0, 11474
GlobalTracer [baseline] (239.953 ms) : 0, 239953
GlobalTracer [candidate] (241.163 ms) : 0, 241163
AppSec [baseline] (29.545 ms) : 0, 29545
AppSec [candidate] (27.781 ms) : 0, 27781
Debugger [baseline] (66.964 ms) : 0, 66964
Debugger [candidate] (64.942 ms) : 0, 64942
Remote Config [baseline] (536.297 µs) : 0, 536
Remote Config [candidate] (529.134 µs) : 0, 529
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (7.786 ms) : 0, 7786
Flare Poller [baseline] (3.457 ms) : 0, 3457
Flare Poller [candidate] (3.468 ms) : 0, 3468
IAST [baseline] (27.63 ms) : 0, 27630
IAST [candidate] (31.016 ms) : 0, 31016
section profiling
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (691.045 ms) : 0, 691045
BytebuddyAgent [candidate] (691.987 ms) : 0, 691987
AgentMeter [baseline] (8.908 ms) : 0, 8908
AgentMeter [candidate] (8.893 ms) : 0, 8893
GlobalTracer [baseline] (207.467 ms) : 0, 207467
GlobalTracer [candidate] (207.387 ms) : 0, 207387
AppSec [baseline] (32.494 ms) : 0, 32494
AppSec [candidate] (32.587 ms) : 0, 32587
Debugger [baseline] (65.706 ms) : 0, 65706
Debugger [candidate] (65.568 ms) : 0, 65568
Remote Config [baseline] (575.208 µs) : 0, 575
Remote Config [candidate] (581.286 µs) : 0, 581
Telemetry [baseline] (7.767 ms) : 0, 7767
Telemetry [candidate] (7.859 ms) : 0, 7859
Flare Poller [baseline] (3.483 ms) : 0, 3483
Flare Poller [candidate] (3.548 ms) : 0, 3548
ProfilingAgent [baseline] (93.184 ms) : 0, 93184
ProfilingAgent [candidate] (93.878 ms) : 0, 93878
Profiling [baseline] (93.754 ms) : 0, 93754
Profiling [candidate] (94.437 ms) : 0, 94437
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section baseline
no_agent (18.173 ms) : 17988, 18359
. : milestone, 18173,
appsec (18.927 ms) : 18730, 19124
. : milestone, 18927,
code_origins (17.877 ms) : 17698, 18056
. : milestone, 17877,
iast (18.089 ms) : 17908, 18270
. : milestone, 18089,
profiling (18.233 ms) : 18052, 18414
. : milestone, 18233,
tracing (17.824 ms) : 17650, 17998
. : milestone, 17824,
section candidate
no_agent (19.169 ms) : 18975, 19364
. : milestone, 19169,
appsec (18.662 ms) : 18474, 18850
. : milestone, 18662,
code_origins (17.849 ms) : 17671, 18027
. : milestone, 17849,
iast (17.773 ms) : 17604, 17942
. : milestone, 17773,
profiling (18.321 ms) : 18139, 18503
. : milestone, 18321,
tracing (17.959 ms) : 17782, 18136
. : milestone, 17959,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section baseline
no_agent (1.251 ms) : 1239, 1264
. : milestone, 1251,
iast (3.349 ms) : 3301, 3397
. : milestone, 3349,
iast_FULL (6.219 ms) : 6155, 6283
. : milestone, 6219,
iast_GLOBAL (3.835 ms) : 3776, 3893
. : milestone, 3835,
profiling (2.175 ms) : 2156, 2194
. : milestone, 2175,
tracing (2.006 ms) : 1988, 2023
. : milestone, 2006,
section candidate
no_agent (1.245 ms) : 1234, 1257
. : milestone, 1245,
iast (3.441 ms) : 3392, 3491
. : milestone, 3441,
iast_FULL (5.792 ms) : 5734, 5851
. : milestone, 5792,
iast_GLOBAL (3.775 ms) : 3711, 3840
. : milestone, 3775,
profiling (2.208 ms) : 2188, 2228
. : milestone, 2208,
tracing (1.949 ms) : 1930, 1968
. : milestone, 1949,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section baseline
no_agent (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
appsec (14.525 s) : 14525000, 14525000
. : milestone, 14525000,
iast (18.667 s) : 18667000, 18667000
. : milestone, 18667000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.468 s) : 15468000, 15468000
. : milestone, 15468000,
tracing (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
section candidate
no_agent (15.516 s) : 15516000, 15516000
. : milestone, 15516000,
appsec (14.725 s) : 14725000, 14725000
. : milestone, 14725000,
iast (18.565 s) : 18565000, 18565000
. : milestone, 18565000,
iast_GLOBAL (18.077 s) : 18077000, 18077000
. : milestone, 18077000,
profiling (15.331 s) : 15331000, 15331000
. : milestone, 15331000,
tracing (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~271c2d3f17, baseline=1.62.0-SNAPSHOT~34333bb5c3
dateFormat X
axisFormat %s
section baseline
no_agent (1.495 ms) : 1483, 1507
. : milestone, 1495,
appsec (2.558 ms) : 2503, 2613
. : milestone, 2558,
iast (2.293 ms) : 2223, 2363
. : milestone, 2293,
iast_GLOBAL (2.332 ms) : 2262, 2403
. : milestone, 2332,
profiling (2.124 ms) : 2069, 2179
. : milestone, 2124,
tracing (2.091 ms) : 2037, 2145
. : milestone, 2091,
section candidate
no_agent (1.498 ms) : 1487, 1510
. : milestone, 1498,
appsec (3.825 ms) : 3602, 4048
. : milestone, 3825,
iast (2.288 ms) : 2219, 2358
. : milestone, 2288,
iast_GLOBAL (2.331 ms) : 2261, 2402
. : milestone, 2331,
profiling (2.117 ms) : 2062, 2172
. : milestone, 2117,
tracing (2.093 ms) : 2039, 2146
. : milestone, 2093,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Renames the environment variable
DD_API_SECURITY_DOWNSTREAM_REQUEST_BODY_ANALYSIS_SAMPLE_RATEtoDD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATEkeeping the aliases.Motivation
The name of the previous variable was too long for certain languages so we had to crop it.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-59936
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.