Conversation
…consume context to a kotlin suspend consume fun
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065315
Total [baseline] (8.829 s) : 0, 8829381
Agent [candidate] (1.065 s) : 0, 1064991
Total [candidate] (8.863 s) : 0, 8862731
section iast
Agent [baseline] (1.236 s) : 0, 1235752
Total [baseline] (9.557 s) : 0, 9557336
Agent [candidate] (1.243 s) : 0, 1242520
Total [candidate] (9.567 s) : 0, 9567182
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (632.431 ms) : 0, 632431
BytebuddyAgent [candidate] (632.762 ms) : 0, 632762
AgentMeter [baseline] (29.366 ms) : 0, 29366
AgentMeter [candidate] (29.183 ms) : 0, 29183
GlobalTracer [baseline] (258.159 ms) : 0, 258159
GlobalTracer [candidate] (258.322 ms) : 0, 258322
AppSec [baseline] (31.748 ms) : 0, 31748
AppSec [candidate] (31.77 ms) : 0, 31770
Debugger [baseline] (59.063 ms) : 0, 59063
Debugger [candidate] (59.185 ms) : 0, 59185
Remote Config [baseline] (594.962 µs) : 0, 595
Remote Config [candidate] (590.036 µs) : 0, 590
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.733 ms) : 0, 8733
Flare Poller [baseline] (7.911 ms) : 0, 7911
Flare Poller [candidate] (7.123 ms) : 0, 7123
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (803.121 ms) : 0, 803121
BytebuddyAgent [candidate] (809.395 ms) : 0, 809395
AgentMeter [baseline] (11.502 ms) : 0, 11502
AgentMeter [candidate] (11.814 ms) : 0, 11814
GlobalTracer [baseline] (248.562 ms) : 0, 248562
GlobalTracer [candidate] (249.385 ms) : 0, 249385
IAST [baseline] (25.439 ms) : 0, 25439
IAST [candidate] (25.33 ms) : 0, 25330
AppSec [baseline] (26.757 ms) : 0, 26757
AppSec [candidate] (27.45 ms) : 0, 27450
Debugger [baseline] (62.824 ms) : 0, 62824
Debugger [candidate] (61.642 ms) : 0, 61642
Remote Config [baseline] (526.167 µs) : 0, 526
Remote Config [candidate] (511.798 µs) : 0, 512
Telemetry [baseline] (14.838 ms) : 0, 14838
Telemetry [candidate] (14.733 ms) : 0, 14733
Flare Poller [baseline] (4.818 ms) : 0, 4818
Flare Poller [candidate] (4.83 ms) : 0, 4830
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058867
Total [baseline] (10.967 s) : 0, 10966574
Agent [candidate] (1.056 s) : 0, 1056376
Total [candidate] (10.997 s) : 0, 10996528
section appsec
Agent [baseline] (1.26 s) : 0, 1259789
Total [baseline] (11.212 s) : 0, 11212477
Agent [candidate] (1.245 s) : 0, 1244630
Total [candidate] (11.148 s) : 0, 11148130
section iast
Agent [baseline] (1.235 s) : 0, 1235309
Total [baseline] (11.442 s) : 0, 11442350
Agent [candidate] (1.224 s) : 0, 1223803
Total [candidate] (11.272 s) : 0, 11271576
section profiling
Agent [baseline] (1.18 s) : 0, 1180474
Total [baseline] (10.936 s) : 0, 10935911
Agent [candidate] (1.199 s) : 0, 1199116
Total [candidate] (11.149 s) : 0, 11149473
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (627.086 ms) : 0, 627086
BytebuddyAgent [candidate] (627.275 ms) : 0, 627275
AgentMeter [baseline] (29.033 ms) : 0, 29033
AgentMeter [candidate] (28.995 ms) : 0, 28995
GlobalTracer [baseline] (256.642 ms) : 0, 256642
GlobalTracer [candidate] (256.583 ms) : 0, 256583
AppSec [baseline] (31.48 ms) : 0, 31480
AppSec [candidate] (31.417 ms) : 0, 31417
Debugger [baseline] (59.584 ms) : 0, 59584
Debugger [candidate] (59.341 ms) : 0, 59341
Remote Config [baseline] (585.387 µs) : 0, 585
Remote Config [candidate] (578.944 µs) : 0, 579
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (8.569 ms) : 0, 8569
Flare Poller [baseline] (8.639 ms) : 0, 8639
Flare Poller [candidate] (6.458 ms) : 0, 6458
section appsec
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (667.017 ms) : 0, 667017
BytebuddyAgent [candidate] (658.12 ms) : 0, 658120
AgentMeter [baseline] (12.094 ms) : 0, 12094
AgentMeter [candidate] (11.936 ms) : 0, 11936
GlobalTracer [baseline] (260.594 ms) : 0, 260594
GlobalTracer [candidate] (257.697 ms) : 0, 257697
IAST [baseline] (24.317 ms) : 0, 24317
IAST [candidate] (23.978 ms) : 0, 23978
AppSec [baseline] (178.418 ms) : 0, 178418
AppSec [candidate] (176.946 ms) : 0, 176946
Debugger [baseline] (66.338 ms) : 0, 66338
Debugger [candidate] (65.412 ms) : 0, 65412
Remote Config [baseline] (576.372 µs) : 0, 576
Remote Config [candidate] (572.123 µs) : 0, 572
Telemetry [baseline] (9.133 ms) : 0, 9133
Telemetry [candidate] (9.009 ms) : 0, 9009
Flare Poller [baseline] (3.646 ms) : 0, 3646
Flare Poller [candidate] (3.627 ms) : 0, 3627
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (803.883 ms) : 0, 803883
BytebuddyAgent [candidate] (793.682 ms) : 0, 793682
AgentMeter [baseline] (11.56 ms) : 0, 11560
AgentMeter [candidate] (11.253 ms) : 0, 11253
GlobalTracer [baseline] (247.114 ms) : 0, 247114
GlobalTracer [candidate] (246.562 ms) : 0, 246562
IAST [baseline] (25.156 ms) : 0, 25156
IAST [candidate] (25.043 ms) : 0, 25043
AppSec [baseline] (26.449 ms) : 0, 26449
AppSec [candidate] (26.32 ms) : 0, 26320
Debugger [baseline] (63.421 ms) : 0, 63421
Debugger [candidate] (63.655 ms) : 0, 63655
Remote Config [baseline] (523.753 µs) : 0, 524
Remote Config [candidate] (510.778 µs) : 0, 511
Telemetry [baseline] (14.934 ms) : 0, 14934
Telemetry [candidate] (14.797 ms) : 0, 14797
Flare Poller [baseline] (4.895 ms) : 0, 4895
Flare Poller [candidate] (4.92 ms) : 0, 4920
section profiling
crashtracking [baseline] (1.166 ms) : 0, 1166
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (681.724 ms) : 0, 681724
BytebuddyAgent [candidate] (694.205 ms) : 0, 694205
AgentMeter [baseline] (8.625 ms) : 0, 8625
AgentMeter [candidate] (8.668 ms) : 0, 8668
GlobalTracer [baseline] (215.321 ms) : 0, 215321
GlobalTracer [candidate] (217.373 ms) : 0, 217373
AppSec [baseline] (31.73 ms) : 0, 31730
AppSec [candidate] (32.49 ms) : 0, 32490
Debugger [baseline] (64.626 ms) : 0, 64626
Debugger [candidate] (62.733 ms) : 0, 62733
Remote Config [baseline] (592.318 µs) : 0, 592
Remote Config [candidate] (604.426 µs) : 0, 604
Telemetry [baseline] (8.2 ms) : 0, 8200
Telemetry [candidate] (10.717 ms) : 0, 10717
Flare Poller [baseline] (4.275 ms) : 0, 4275
Flare Poller [candidate] (4.317 ms) : 0, 4317
ProfilingAgent [baseline] (93.526 ms) : 0, 93526
ProfilingAgent [candidate] (95.034 ms) : 0, 95034
Profiling [baseline] (94.096 ms) : 0, 94096
Profiling [candidate] (95.592 ms) : 0, 95592
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (1.259 ms) : 1245, 1273
. : milestone, 1259,
iast (3.173 ms) : 3132, 3214
. : milestone, 3173,
iast_FULL (6.049 ms) : 5986, 6111
. : milestone, 6049,
iast_GLOBAL (3.673 ms) : 3614, 3732
. : milestone, 3673,
profiling (2.27 ms) : 2248, 2292
. : milestone, 2270,
tracing (1.862 ms) : 1847, 1878
. : milestone, 1862,
section candidate
no_agent (1.185 ms) : 1173, 1196
. : milestone, 1185,
iast (3.089 ms) : 3053, 3125
. : milestone, 3089,
iast_FULL (5.799 ms) : 5741, 5857
. : milestone, 5799,
iast_GLOBAL (3.669 ms) : 3607, 3732
. : milestone, 3669,
profiling (2.086 ms) : 2062, 2109
. : milestone, 2086,
tracing (1.775 ms) : 1760, 1790
. : milestone, 1775,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (19.356 ms) : 19161, 19551
. : milestone, 19356,
appsec (18.709 ms) : 18518, 18901
. : milestone, 18709,
code_origins (17.974 ms) : 17795, 18153
. : milestone, 17974,
iast (17.857 ms) : 17675, 18039
. : milestone, 17857,
profiling (18.574 ms) : 18388, 18760
. : milestone, 18574,
tracing (17.601 ms) : 17427, 17775
. : milestone, 17601,
section candidate
no_agent (18.429 ms) : 18240, 18619
. : milestone, 18429,
appsec (18.595 ms) : 18405, 18784
. : milestone, 18595,
code_origins (17.765 ms) : 17589, 17940
. : milestone, 17765,
iast (17.983 ms) : 17806, 18160
. : milestone, 17983,
profiling (18.875 ms) : 18685, 19065
. : milestone, 18875,
tracing (17.865 ms) : 17683, 18047
. : milestone, 17865,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
appsec (14.871 s) : 14871000, 14871000
. : milestone, 14871000,
iast (17.855 s) : 17855000, 17855000
. : milestone, 17855000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
. : milestone, 17963000,
profiling (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
tracing (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
section candidate
no_agent (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
appsec (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
iast (18.228 s) : 18228000, 18228000
. : milestone, 18228000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
tracing (15.29 s) : 15290000, 15290000
. : milestone, 15290000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~96c42a15a6, baseline=1.61.0-SNAPSHOT~c04d61b318
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.718 ms) : 3503, 3932
. : milestone, 3718,
iast (2.27 ms) : 2199, 2340
. : milestone, 2270,
iast_GLOBAL (2.311 ms) : 2241, 2381
. : milestone, 2311,
profiling (2.085 ms) : 2030, 2140
. : milestone, 2085,
tracing (2.067 ms) : 2013, 2121
. : milestone, 2067,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.502 ms) : 2447, 2557
. : milestone, 2502,
iast (2.269 ms) : 2199, 2339
. : milestone, 2269,
iast_GLOBAL (2.31 ms) : 2239, 2380
. : milestone, 2310,
profiling (2.092 ms) : 2037, 2148
. : milestone, 2092,
tracing (2.068 ms) : 2014, 2122
. : milestone, 2068,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds support for KotlinAwareInvocableHandlerMethod to pass the spring.consume context to a kotlin suspend consume fun.
Motivation
A kotlin suspend function execution isn't in scope of the spring.consume.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMS-18839
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.