Avoid CNDF exceptions in instrumentation tests#10815
Avoid CNDF exceptions in instrumentation tests#10815
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067068
Total [baseline] (8.82 s) : 0, 8820009
Agent [candidate] (1.066 s) : 0, 1066204
Total [candidate] (8.847 s) : 0, 8847239
section iast
Agent [baseline] (1.233 s) : 0, 1233039
Total [baseline] (9.542 s) : 0, 9542282
Agent [candidate] (1.227 s) : 0, 1227419
Total [candidate] (9.557 s) : 0, 9557374
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (633.955 ms) : 0, 633955
BytebuddyAgent [candidate] (634.343 ms) : 0, 634343
AgentMeter [baseline] (29.419 ms) : 0, 29419
AgentMeter [candidate] (29.336 ms) : 0, 29336
GlobalTracer [baseline] (259.034 ms) : 0, 259034
GlobalTracer [candidate] (259.333 ms) : 0, 259333
AppSec [baseline] (31.984 ms) : 0, 31984
AppSec [candidate] (31.897 ms) : 0, 31897
Debugger [baseline] (59.398 ms) : 0, 59398
Debugger [candidate] (59.387 ms) : 0, 59387
Remote Config [baseline] (598.263 µs) : 0, 598
Remote Config [candidate] (596.71 µs) : 0, 597
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.733 ms) : 0, 8733
Flare Poller [baseline] (6.503 ms) : 0, 6503
Flare Poller [candidate] (5.093 ms) : 0, 5093
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (801.347 ms) : 0, 801347
BytebuddyAgent [candidate] (796.853 ms) : 0, 796853
AgentMeter [baseline] (11.543 ms) : 0, 11543
AgentMeter [candidate] (11.327 ms) : 0, 11327
GlobalTracer [baseline] (248.482 ms) : 0, 248482
GlobalTracer [candidate] (247.304 ms) : 0, 247304
IAST [baseline] (25.347 ms) : 0, 25347
IAST [candidate] (25.094 ms) : 0, 25094
AppSec [baseline] (26.546 ms) : 0, 26546
AppSec [candidate] (27.074 ms) : 0, 27074
Debugger [baseline] (62.409 ms) : 0, 62409
Debugger [candidate] (62.127 ms) : 0, 62127
Remote Config [baseline] (520.054 µs) : 0, 520
Remote Config [candidate] (525.819 µs) : 0, 526
Telemetry [baseline] (14.798 ms) : 0, 14798
Telemetry [candidate] (14.927 ms) : 0, 14927
Flare Poller [baseline] (4.621 ms) : 0, 4621
Flare Poller [candidate] (4.853 ms) : 0, 4853
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059502
Total [baseline] (11.037 s) : 0, 11037348
Agent [candidate] (1.076 s) : 0, 1076059
Total [candidate] (11.126 s) : 0, 11126357
section appsec
Agent [baseline] (1.247 s) : 0, 1246673
Total [baseline] (11.157 s) : 0, 11157260
Agent [candidate] (1.256 s) : 0, 1255535
Total [candidate] (11.168 s) : 0, 11167535
section iast
Agent [baseline] (1.237 s) : 0, 1236717
Total [baseline] (11.269 s) : 0, 11269457
Agent [candidate] (1.244 s) : 0, 1244175
Total [candidate] (11.404 s) : 0, 11403636
section profiling
Agent [baseline] (1.183 s) : 0, 1183312
Total [baseline] (11.063 s) : 0, 11062745
Agent [candidate] (1.181 s) : 0, 1181405
Total [candidate] (11.053 s) : 0, 11052586
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.211 ms) : 0, 1211
BytebuddyAgent [baseline] (628.13 ms) : 0, 628130
BytebuddyAgent [candidate] (637.915 ms) : 0, 637915
AgentMeter [baseline] (29.198 ms) : 0, 29198
AgentMeter [candidate] (29.61 ms) : 0, 29610
GlobalTracer [baseline] (257.311 ms) : 0, 257311
GlobalTracer [candidate] (260.427 ms) : 0, 260427
AppSec [baseline] (31.623 ms) : 0, 31623
AppSec [candidate] (32.033 ms) : 0, 32033
Debugger [baseline] (59.596 ms) : 0, 59596
Debugger [candidate] (60.403 ms) : 0, 60403
Remote Config [baseline] (582.876 µs) : 0, 583
Remote Config [candidate] (605.279 µs) : 0, 605
Telemetry [baseline] (8.585 ms) : 0, 8585
Telemetry [candidate] (8.82 ms) : 0, 8820
Flare Poller [baseline] (7.216 ms) : 0, 7216
Flare Poller [candidate] (8.659 ms) : 0, 8659
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (658.34 ms) : 0, 658340
BytebuddyAgent [candidate] (663.297 ms) : 0, 663297
AgentMeter [baseline] (12.037 ms) : 0, 12037
AgentMeter [candidate] (12.172 ms) : 0, 12172
GlobalTracer [baseline] (258.565 ms) : 0, 258565
GlobalTracer [candidate] (260.159 ms) : 0, 260159
AppSec [baseline] (177.506 ms) : 0, 177506
AppSec [candidate] (178.627 ms) : 0, 178627
Debugger [baseline] (65.518 ms) : 0, 65518
Debugger [candidate] (65.375 ms) : 0, 65375
Remote Config [baseline] (578.948 µs) : 0, 579
Remote Config [candidate] (580.125 µs) : 0, 580
Telemetry [baseline] (9.169 ms) : 0, 9169
Telemetry [candidate] (9.965 ms) : 0, 9965
Flare Poller [baseline] (3.56 ms) : 0, 3560
Flare Poller [candidate] (3.561 ms) : 0, 3561
IAST [baseline] (23.96 ms) : 0, 23960
IAST [candidate] (24.124 ms) : 0, 24124
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (803.083 ms) : 0, 803083
BytebuddyAgent [candidate] (808.535 ms) : 0, 808535
AgentMeter [baseline] (11.605 ms) : 0, 11605
AgentMeter [candidate] (11.898 ms) : 0, 11898
GlobalTracer [baseline] (248.634 ms) : 0, 248634
GlobalTracer [candidate] (249.957 ms) : 0, 249957
AppSec [baseline] (26.589 ms) : 0, 26589
AppSec [candidate] (26.733 ms) : 0, 26733
Debugger [baseline] (65.803 ms) : 0, 65803
Debugger [candidate] (63.632 ms) : 0, 63632
Remote Config [baseline] (542.461 µs) : 0, 542
Remote Config [candidate] (554.055 µs) : 0, 554
Telemetry [baseline] (13.524 ms) : 0, 13524
Telemetry [candidate] (15.314 ms) : 0, 15314
Flare Poller [baseline] (4.274 ms) : 0, 4274
Flare Poller [candidate] (4.475 ms) : 0, 4475
IAST [baseline] (25.307 ms) : 0, 25307
IAST [candidate] (25.506 ms) : 0, 25506
section profiling
ProfilingAgent [baseline] (94.512 ms) : 0, 94512
ProfilingAgent [candidate] (94.036 ms) : 0, 94036
crashtracking [baseline] (1.167 ms) : 0, 1167
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (682.738 ms) : 0, 682738
BytebuddyAgent [candidate] (681.916 ms) : 0, 681916
AgentMeter [baseline] (8.664 ms) : 0, 8664
AgentMeter [candidate] (8.545 ms) : 0, 8545
GlobalTracer [baseline] (215.595 ms) : 0, 215595
GlobalTracer [candidate] (215.397 ms) : 0, 215397
AppSec [baseline] (32.049 ms) : 0, 32049
AppSec [candidate] (31.955 ms) : 0, 31955
Debugger [baseline] (63.037 ms) : 0, 63037
Debugger [candidate] (62.939 ms) : 0, 62939
Remote Config [baseline] (604.634 µs) : 0, 605
Remote Config [candidate] (584.772 µs) : 0, 585
Telemetry [baseline] (10.528 ms) : 0, 10528
Telemetry [candidate] (10.552 ms) : 0, 10552
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (3.497 ms) : 0, 3497
Profiling [baseline] (95.089 ms) : 0, 95089
Profiling [candidate] (94.595 ms) : 0, 94595
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1161, 1185
. : milestone, 1173,
iast (3.365 ms) : 3322, 3407
. : milestone, 3365,
iast_FULL (5.971 ms) : 5911, 6031
. : milestone, 5971,
iast_GLOBAL (3.514 ms) : 3461, 3567
. : milestone, 3514,
profiling (2.02 ms) : 2002, 2038
. : milestone, 2020,
tracing (1.783 ms) : 1768, 1798
. : milestone, 1783,
section candidate
no_agent (1.177 ms) : 1166, 1189
. : milestone, 1177,
iast (3.13 ms) : 3089, 3172
. : milestone, 3130,
iast_FULL (5.855 ms) : 5798, 5913
. : milestone, 5855,
iast_GLOBAL (3.554 ms) : 3495, 3613
. : milestone, 3554,
profiling (2.007 ms) : 1989, 2025
. : milestone, 2007,
tracing (1.799 ms) : 1783, 1814
. : milestone, 1799,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section baseline
no_agent (18.05 ms) : 17867, 18234
. : milestone, 18050,
appsec (18.568 ms) : 18382, 18754
. : milestone, 18568,
code_origins (17.875 ms) : 17698, 18053
. : milestone, 17875,
iast (17.937 ms) : 17757, 18116
. : milestone, 17937,
profiling (18.956 ms) : 18768, 19144
. : milestone, 18956,
tracing (18.582 ms) : 18395, 18769
. : milestone, 18582,
section candidate
no_agent (18.241 ms) : 18057, 18424
. : milestone, 18241,
appsec (18.378 ms) : 18197, 18558
. : milestone, 18378,
code_origins (17.71 ms) : 17533, 17886
. : milestone, 17710,
iast (18.572 ms) : 18383, 18761
. : milestone, 18572,
profiling (18.661 ms) : 18474, 18848
. : milestone, 18661,
tracing (17.925 ms) : 17745, 18106
. : milestone, 17925,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section baseline
no_agent (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
appsec (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
iast (17.673 s) : 17673000, 17673000
. : milestone, 17673000,
iast_GLOBAL (17.95 s) : 17950000, 17950000
. : milestone, 17950000,
profiling (15.239 s) : 15239000, 15239000
. : milestone, 15239000,
tracing (15.148 s) : 15148000, 15148000
. : milestone, 15148000,
section candidate
no_agent (14.655 s) : 14655000, 14655000
. : milestone, 14655000,
appsec (14.711 s) : 14711000, 14711000
. : milestone, 14711000,
iast (18.158 s) : 18158000, 18158000
. : milestone, 18158000,
iast_GLOBAL (17.731 s) : 17731000, 17731000
. : milestone, 17731000,
profiling (14.775 s) : 14775000, 14775000
. : milestone, 14775000,
tracing (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~ff564880ed, baseline=1.61.0-SNAPSHOT~c1e9ac6389
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1480
. : milestone, 1469,
appsec (3.809 ms) : 3588, 4030
. : milestone, 3809,
iast (2.253 ms) : 2185, 2322
. : milestone, 2253,
iast_GLOBAL (2.304 ms) : 2235, 2373
. : milestone, 2304,
profiling (2.114 ms) : 2058, 2171
. : milestone, 2114,
tracing (2.056 ms) : 2003, 2109
. : milestone, 2056,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.73 ms) : 3514, 3946
. : milestone, 3730,
iast (2.263 ms) : 2194, 2332
. : milestone, 2263,
iast_GLOBAL (2.305 ms) : 2235, 2375
. : milestone, 2305,
profiling (2.09 ms) : 2035, 2145
. : milestone, 2090,
tracing (2.062 ms) : 2009, 2116
. : milestone, 2062,
|
| implementation(project(":components:environment")) | ||
| implementation(project(":dd-trace-api")) |
There was a problem hiding this comment.
question: Out of curiosity do we want to expose these other two ?
There was a problem hiding this comment.
I was asking the same question when I did the change but honestly I don't know with certitude
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in Use ⏳ Processing |
What Does This Do
config-utilsneedsfilesystem-utilsfor stable config. Now this was not transitively drawn during tests and all instrumentations test executions are showing:This PR changes the dependency scope to
apito enforce thatMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.