Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1072482
Total [baseline] (11.127 s) : 0, 11126982
Agent [candidate] (1.058 s) : 0, 1058192
Total [candidate] (11.18 s) : 0, 11180242
section appsec
Agent [baseline] (1.247 s) : 0, 1247054
Total [baseline] (11.248 s) : 0, 11247780
Agent [candidate] (1.252 s) : 0, 1251671
Total [candidate] (11.245 s) : 0, 11244700
section iast
Agent [baseline] (1.229 s) : 0, 1229148
Total [baseline] (11.304 s) : 0, 11303798
Agent [candidate] (1.226 s) : 0, 1226151
Total [candidate] (11.36 s) : 0, 11359507
section profiling
Agent [baseline] (1.182 s) : 0, 1181966
Total [baseline] (10.969 s) : 0, 10968890
Agent [candidate] (1.184 s) : 0, 1183725
Total [candidate] (11.11 s) : 0, 11109806
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (637.244 ms) : 0, 637244
BytebuddyAgent [candidate] (627.142 ms) : 0, 627142
AgentMeter [baseline] (29.614 ms) : 0, 29614
AgentMeter [candidate] (29.014 ms) : 0, 29014
GlobalTracer [baseline] (260.344 ms) : 0, 260344
GlobalTracer [candidate] (256.512 ms) : 0, 256512
AppSec [baseline] (32.07 ms) : 0, 32070
AppSec [candidate] (31.473 ms) : 0, 31473
Debugger [baseline] (60.448 ms) : 0, 60448
Debugger [candidate] (59.418 ms) : 0, 59418
Remote Config [baseline] (603.411 µs) : 0, 603
Remote Config [candidate] (585.842 µs) : 0, 586
Telemetry [baseline] (8.871 ms) : 0, 8871
Telemetry [candidate] (8.619 ms) : 0, 8619
Flare Poller [baseline] (5.857 ms) : 0, 5857
Flare Poller [candidate] (8.186 ms) : 0, 8186
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (658.294 ms) : 0, 658294
BytebuddyAgent [candidate] (661.886 ms) : 0, 661886
AgentMeter [baseline] (12.047 ms) : 0, 12047
AgentMeter [candidate] (12.065 ms) : 0, 12065
GlobalTracer [baseline] (258.67 ms) : 0, 258670
GlobalTracer [candidate] (259.342 ms) : 0, 259342
IAST [baseline] (23.946 ms) : 0, 23946
IAST [candidate] (24.09 ms) : 0, 24090
AppSec [baseline] (177.666 ms) : 0, 177666
AppSec [candidate] (177.684 ms) : 0, 177684
Debugger [baseline] (65.693 ms) : 0, 65693
Debugger [candidate] (65.725 ms) : 0, 65725
Remote Config [baseline] (575.44 µs) : 0, 575
Remote Config [candidate] (571.584 µs) : 0, 572
Telemetry [baseline] (9.08 ms) : 0, 9080
Telemetry [candidate] (9.169 ms) : 0, 9169
Flare Poller [baseline] (3.613 ms) : 0, 3613
Flare Poller [candidate] (3.6 ms) : 0, 3600
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (797.208 ms) : 0, 797208
BytebuddyAgent [candidate] (795.373 ms) : 0, 795373
AgentMeter [baseline] (11.313 ms) : 0, 11313
AgentMeter [candidate] (11.363 ms) : 0, 11363
GlobalTracer [baseline] (247.959 ms) : 0, 247959
GlobalTracer [candidate] (246.996 ms) : 0, 246996
IAST [baseline] (25.127 ms) : 0, 25127
IAST [candidate] (25.116 ms) : 0, 25116
AppSec [baseline] (26.407 ms) : 0, 26407
AppSec [candidate] (27.203 ms) : 0, 27203
Debugger [baseline] (64.366 ms) : 0, 64366
Debugger [candidate] (63.236 ms) : 0, 63236
Remote Config [baseline] (533.317 µs) : 0, 533
Remote Config [candidate] (530.052 µs) : 0, 530
Telemetry [baseline] (14.658 ms) : 0, 14658
Telemetry [candidate] (14.752 ms) : 0, 14752
Flare Poller [baseline] (4.423 ms) : 0, 4423
Flare Poller [candidate] (4.439 ms) : 0, 4439
section profiling
crashtracking [baseline] (1.164 ms) : 0, 1164
crashtracking [candidate] (1.167 ms) : 0, 1167
BytebuddyAgent [baseline] (682.573 ms) : 0, 682573
BytebuddyAgent [candidate] (683.325 ms) : 0, 683325
AgentMeter [baseline] (8.62 ms) : 0, 8620
AgentMeter [candidate] (8.627 ms) : 0, 8627
GlobalTracer [baseline] (215.62 ms) : 0, 215620
GlobalTracer [candidate] (216.01 ms) : 0, 216010
AppSec [baseline] (32.055 ms) : 0, 32055
AppSec [candidate] (31.931 ms) : 0, 31931
Debugger [baseline] (65.38 ms) : 0, 65380
Debugger [candidate] (65.139 ms) : 0, 65139
Remote Config [baseline] (605.785 µs) : 0, 606
Remote Config [candidate] (584.125 µs) : 0, 584
Telemetry [baseline] (8.191 ms) : 0, 8191
Telemetry [candidate] (8.258 ms) : 0, 8258
Flare Poller [baseline] (3.485 ms) : 0, 3485
Flare Poller [candidate] (3.526 ms) : 0, 3526
ProfilingAgent [baseline] (93.563 ms) : 0, 93563
ProfilingAgent [candidate] (94.331 ms) : 0, 94331
Profiling [baseline] (94.134 ms) : 0, 94134
Profiling [candidate] (94.898 ms) : 0, 94898
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061797
Total [baseline] (8.832 s) : 0, 8831653
Agent [candidate] (1.059 s) : 0, 1059441
Total [candidate] (8.831 s) : 0, 8830839
section iast
Agent [baseline] (1.228 s) : 0, 1228445
Total [baseline] (9.569 s) : 0, 9568504
Agent [candidate] (1.228 s) : 0, 1228077
Total [candidate] (9.546 s) : 0, 9546040
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (629.269 ms) : 0, 629269
BytebuddyAgent [candidate] (628.518 ms) : 0, 628518
AgentMeter [baseline] (29.083 ms) : 0, 29083
AgentMeter [candidate] (29.129 ms) : 0, 29129
GlobalTracer [baseline] (257.583 ms) : 0, 257583
GlobalTracer [candidate] (257.137 ms) : 0, 257137
AppSec [baseline] (31.611 ms) : 0, 31611
AppSec [candidate] (31.66 ms) : 0, 31660
Debugger [baseline] (58.743 ms) : 0, 58743
Debugger [candidate] (58.594 ms) : 0, 58594
Remote Config [baseline] (591.644 µs) : 0, 592
Remote Config [candidate] (584.305 µs) : 0, 584
Telemetry [baseline] (8.78 ms) : 0, 8780
Telemetry [candidate] (8.739 ms) : 0, 8739
Flare Poller [baseline] (8.818 ms) : 0, 8818
Flare Poller [candidate] (7.785 ms) : 0, 7785
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (797.705 ms) : 0, 797705
BytebuddyAgent [candidate] (796.79 ms) : 0, 796790
AgentMeter [baseline] (11.373 ms) : 0, 11373
AgentMeter [candidate] (11.371 ms) : 0, 11371
GlobalTracer [baseline] (247.735 ms) : 0, 247735
GlobalTracer [candidate] (247.777 ms) : 0, 247777
AppSec [baseline] (26.388 ms) : 0, 26388
AppSec [candidate] (26.327 ms) : 0, 26327
Debugger [baseline] (62.523 ms) : 0, 62523
Debugger [candidate] (62.981 ms) : 0, 62981
Remote Config [baseline] (590.052 µs) : 0, 590
Remote Config [candidate] (530.107 µs) : 0, 530
Telemetry [baseline] (15.114 ms) : 0, 15114
Telemetry [candidate] (15.2 ms) : 0, 15200
Flare Poller [baseline] (4.418 ms) : 0, 4418
Flare Poller [candidate] (4.633 ms) : 0, 4633
IAST [baseline] (25.135 ms) : 0, 25135
IAST [candidate] (25.205 ms) : 0, 25205
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section baseline
no_agent (17.15 ms) : 16975, 17324
. : milestone, 17150,
appsec (19.56 ms) : 19362, 19757
. : milestone, 19560,
code_origins (18.579 ms) : 18393, 18765
. : milestone, 18579,
iast (17.641 ms) : 17466, 17817
. : milestone, 17641,
profiling (19.786 ms) : 19586, 19987
. : milestone, 19786,
tracing (17.918 ms) : 17739, 18097
. : milestone, 17918,
section candidate
no_agent (19.427 ms) : 19225, 19629
. : milestone, 19427,
appsec (18.781 ms) : 18592, 18970
. : milestone, 18781,
code_origins (19.089 ms) : 18896, 19281
. : milestone, 19089,
iast (18.043 ms) : 17864, 18222
. : milestone, 18043,
profiling (19.682 ms) : 19480, 19883
. : milestone, 19682,
tracing (17.636 ms) : 17459, 17813
. : milestone, 17636,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section baseline
no_agent (1.203 ms) : 1191, 1215
. : milestone, 1203,
iast (3.221 ms) : 3175, 3267
. : milestone, 3221,
iast_FULL (5.649 ms) : 5593, 5705
. : milestone, 5649,
iast_GLOBAL (3.661 ms) : 3597, 3725
. : milestone, 3661,
profiling (2.0 ms) : 1982, 2018
. : milestone, 2000,
tracing (1.767 ms) : 1752, 1782
. : milestone, 1767,
section candidate
no_agent (1.196 ms) : 1185, 1208
. : milestone, 1196,
iast (3.14 ms) : 3102, 3179
. : milestone, 3140,
iast_FULL (5.872 ms) : 5813, 5931
. : milestone, 5872,
iast_GLOBAL (3.389 ms) : 3345, 3434
. : milestone, 3389,
profiling (1.962 ms) : 1944, 1979
. : milestone, 1962,
tracing (1.778 ms) : 1763, 1792
. : milestone, 1778,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.519 ms) : 2464, 2574
. : milestone, 2519,
iast (2.255 ms) : 2185, 2324
. : milestone, 2255,
iast_GLOBAL (2.293 ms) : 2223, 2363
. : milestone, 2293,
profiling (2.113 ms) : 2056, 2171
. : milestone, 2113,
tracing (2.067 ms) : 2013, 2120
. : milestone, 2067,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.818 ms) : 3596, 4039
. : milestone, 3818,
iast (2.262 ms) : 2193, 2331
. : milestone, 2262,
iast_GLOBAL (2.306 ms) : 2237, 2376
. : milestone, 2306,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.068 ms) : 2014, 2121
. : milestone, 2068,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4d811cb620, baseline=1.61.0-SNAPSHOT~92d7ae699c
dateFormat X
axisFormat %s
section baseline
no_agent (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
appsec (15.037 s) : 15037000, 15037000
. : milestone, 15037000,
iast (17.915 s) : 17915000, 17915000
. : milestone, 17915000,
iast_GLOBAL (18.004 s) : 18004000, 18004000
. : milestone, 18004000,
profiling (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
tracing (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
section candidate
no_agent (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
appsec (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
iast (17.959 s) : 17959000, 17959000
. : milestone, 17959000,
iast_GLOBAL (17.48 s) : 17480000, 17480000
. : milestone, 17480000,
profiling (14.723 s) : 14723000, 14723000
. : milestone, 14723000,
tracing (15.175 s) : 15175000, 15175000
. : milestone, 15175000,
|
|
|
||
| @ParameterizedTest(name = "test mapping to Map from non-object JSON: {0}") | ||
| @ValueSource(strings = {"1", "[1, 2]"}) | ||
| // temporary disable spotless, will open issue to fix this. |
There was a problem hiding this comment.
It'd be nice to link the issue here (and for the special chars comment below if relevant)
There was a problem hiding this comment.
I'm investigating it. Latest spotless 8.3.0 should support TableTest format, but it is failing on our setup due to recent changes for spotlessPredeclare, investigating how to fix this first.
PerfectSlayer
left a comment
There was a problem hiding this comment.
👏 praise: That looks to be a nice improvement!
💭 thought: I had some concerns especially around duplicating test case for values that would not fit into test tables. So I give it a try and it fits nicely with @MethodSource too so it looks like we can have best of both world (table test for most of the case, method source for the ones that could not fit, all feeding the same parameterized tests). Here is the related change proposal: #10816
| @@ -0,0 +1,76 @@ | |||
| --- | |||
| name: use-tabletest | |||
There was a problem hiding this comment.
🎯 suggestion: I would suggest: 1. something more specific, 2. using +ing form according the naming conventions. So maybe something like: migrating-junit-source-to-tabletest
There was a problem hiding this comment.
I might need to rename the ones I created to match the conventions too 😅
|
|
||
| Never: | ||
| - --info | ||
| - extra gradle runs just to “confirm” |
There was a problem hiding this comment.
💭 thought: Do you have some cases in mind you want to prevent?
|
|
||
| dependencies { | ||
| testImplementation(libs.tabletest) | ||
| } |
There was a problem hiding this comment.
❔ question: Should we include it by default as we include JUnit?
That would prevent all modules to have to import it (as we all expect them to have test 😬 )
| arguments(Arrays.asList("value1", "value2"), "[\"value1\",\"value2\"]"), | ||
| arguments(Arrays.asList("va\"lu\"e1", "value2"), "[\"va\\\"lu\\\"e1\",\"value2\"]")); | ||
| @Test | ||
| void testMappingIterableToJsonArrayWithQuotedValue() throws IOException { |
There was a problem hiding this comment.
❔ question: What makes this test case not going to the@TableTest?
Because this duplicate the test method and split the test cases into two different tests.
EDIT: Looks like it fits nicely. I added it to my PR.
| return Stream.of(arguments((Object) null), arguments("null"), arguments(""), arguments("[]")); | ||
| } | ||
|
|
||
| // Using `@MethodSource` as special chars not supported by `@TableTest` (yet?). |
There was a problem hiding this comment.
❔ question: What about https://tabletest.org/reference/advanced-features/#java-string-arrays?
EDIT: The issue come from: String.valueOf((char) 4096)
What Does This Do
@TableTestsupport for tests in components/json.@MethodSourceand@ValueSourceto@TableTest.@Testmethods or existing@MethodSource-based tests where appropriate.@TableTestin future test migrations.Motivation
Improve test readability and maintainability by adopting a tabular style similar to
Spockdata tables, while keeping the structure idiomatic forJUnit.Additional Notes
@TableTest.