In telemetry, replace Objects.hash with HashingUtils.hash#10813
Open
In telemetry, replace Objects.hash with HashingUtils.hash#10813
Conversation
Co-authored-by: dougqh <dougqh@gmail.com>
Contributor
|
I can only run on private repositories. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057769
Total [baseline] (11.033 s) : 0, 11033031
Agent [candidate] (1.058 s) : 0, 1058435
Total [candidate] (11.079 s) : 0, 11078851
section appsec
Agent [baseline] (1.251 s) : 0, 1251027
Total [baseline] (11.227 s) : 0, 11227302
Agent [candidate] (1.247 s) : 0, 1246687
Total [candidate] (11.088 s) : 0, 11087683
section iast
Agent [baseline] (1.222 s) : 0, 1222223
Total [baseline] (11.254 s) : 0, 11254075
Agent [candidate] (1.228 s) : 0, 1227746
Total [candidate] (11.285 s) : 0, 11285143
section profiling
Agent [baseline] (1.18 s) : 0, 1180486
Total [baseline] (10.981 s) : 0, 10981187
Agent [candidate] (1.18 s) : 0, 1180040
Total [candidate] (11.006 s) : 0, 11006488
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (627.397 ms) : 0, 627397
BytebuddyAgent [candidate] (628.151 ms) : 0, 628151
AgentMeter [baseline] (29.137 ms) : 0, 29137
AgentMeter [candidate] (29.157 ms) : 0, 29157
GlobalTracer [baseline] (256.629 ms) : 0, 256629
GlobalTracer [candidate] (256.781 ms) : 0, 256781
AppSec [baseline] (31.502 ms) : 0, 31502
AppSec [candidate] (31.477 ms) : 0, 31477
Debugger [baseline] (59.425 ms) : 0, 59425
Debugger [candidate] (59.4 ms) : 0, 59400
Remote Config [baseline] (589.215 µs) : 0, 589
Remote Config [candidate] (592.44 µs) : 0, 592
Telemetry [baseline] (8.607 ms) : 0, 8607
Telemetry [candidate] (8.618 ms) : 0, 8618
Flare Poller [baseline] (7.273 ms) : 0, 7273
Flare Poller [candidate] (7.063 ms) : 0, 7063
section appsec
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (661.927 ms) : 0, 661927
BytebuddyAgent [candidate] (658.85 ms) : 0, 658850
AgentMeter [baseline] (12.094 ms) : 0, 12094
AgentMeter [candidate] (12.016 ms) : 0, 12016
GlobalTracer [baseline] (259.001 ms) : 0, 259001
GlobalTracer [candidate] (258.527 ms) : 0, 258527
AppSec [baseline] (177.4 ms) : 0, 177400
AppSec [candidate] (177.174 ms) : 0, 177174
Debugger [baseline] (65.694 ms) : 0, 65694
Debugger [candidate] (65.541 ms) : 0, 65541
Remote Config [baseline] (570.829 µs) : 0, 571
Remote Config [candidate] (567.529 µs) : 0, 568
Telemetry [baseline] (9.175 ms) : 0, 9175
Telemetry [candidate] (9.047 ms) : 0, 9047
Flare Poller [baseline] (3.635 ms) : 0, 3635
Flare Poller [candidate] (3.6 ms) : 0, 3600
IAST [baseline] (24.044 ms) : 0, 24044
IAST [candidate] (23.94 ms) : 0, 23940
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (792.737 ms) : 0, 792737
BytebuddyAgent [candidate] (797.315 ms) : 0, 797315
AgentMeter [baseline] (11.305 ms) : 0, 11305
AgentMeter [candidate] (11.371 ms) : 0, 11371
GlobalTracer [baseline] (246.32 ms) : 0, 246320
GlobalTracer [candidate] (247.162 ms) : 0, 247162
AppSec [baseline] (26.298 ms) : 0, 26298
AppSec [candidate] (26.219 ms) : 0, 26219
Debugger [baseline] (63.946 ms) : 0, 63946
Debugger [candidate] (64.721 ms) : 0, 64721
Remote Config [baseline] (520.098 µs) : 0, 520
Remote Config [candidate] (539.563 µs) : 0, 540
Telemetry [baseline] (14.612 ms) : 0, 14612
Telemetry [candidate] (13.739 ms) : 0, 13739
Flare Poller [baseline] (4.249 ms) : 0, 4249
Flare Poller [candidate] (4.539 ms) : 0, 4539
IAST [baseline] (25.024 ms) : 0, 25024
IAST [candidate] (25.037 ms) : 0, 25037
section profiling
ProfilingAgent [baseline] (94.172 ms) : 0, 94172
ProfilingAgent [candidate] (92.956 ms) : 0, 92956
crashtracking [baseline] (1.158 ms) : 0, 1158
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (681.1 ms) : 0, 681100
BytebuddyAgent [candidate] (681.971 ms) : 0, 681971
AgentMeter [baseline] (8.645 ms) : 0, 8645
AgentMeter [candidate] (8.603 ms) : 0, 8603
GlobalTracer [baseline] (215.007 ms) : 0, 215007
GlobalTracer [candidate] (215.278 ms) : 0, 215278
AppSec [baseline] (31.925 ms) : 0, 31925
AppSec [candidate] (32.008 ms) : 0, 32008
Debugger [baseline] (63.123 ms) : 0, 63123
Debugger [candidate] (60.588 ms) : 0, 60588
Remote Config [baseline] (593.411 µs) : 0, 593
Remote Config [candidate] (580.833 µs) : 0, 581
Telemetry [baseline] (9.897 ms) : 0, 9897
Telemetry [candidate] (12.832 ms) : 0, 12832
Flare Poller [baseline] (4.308 ms) : 0, 4308
Flare Poller [candidate] (3.5 ms) : 0, 3500
Profiling [baseline] (94.748 ms) : 0, 94748
Profiling [candidate] (93.519 ms) : 0, 93519
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071803
Total [baseline] (8.864 s) : 0, 8863969
Agent [candidate] (1.06 s) : 0, 1059769
Total [candidate] (8.797 s) : 0, 8796957
section iast
Agent [baseline] (1.237 s) : 0, 1236661
Total [baseline] (9.547 s) : 0, 9546739
Agent [candidate] (1.227 s) : 0, 1227092
Total [candidate] (9.539 s) : 0, 9539132
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (636.01 ms) : 0, 636010
BytebuddyAgent [candidate] (629.516 ms) : 0, 629516
AgentMeter [baseline] (29.461 ms) : 0, 29461
AgentMeter [candidate] (29.04 ms) : 0, 29040
GlobalTracer [baseline] (259.16 ms) : 0, 259160
GlobalTracer [candidate] (256.465 ms) : 0, 256465
AppSec [baseline] (32.043 ms) : 0, 32043
AppSec [candidate] (31.533 ms) : 0, 31533
Debugger [baseline] (59.426 ms) : 0, 59426
Debugger [candidate] (58.711 ms) : 0, 58711
Remote Config [baseline] (598.648 µs) : 0, 599
Remote Config [candidate] (589.24 µs) : 0, 589
Telemetry [baseline] (8.831 ms) : 0, 8831
Telemetry [candidate] (8.733 ms) : 0, 8733
Flare Poller [baseline] (8.786 ms) : 0, 8786
Flare Poller [candidate] (7.93 ms) : 0, 7930
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (804.232 ms) : 0, 804232
BytebuddyAgent [candidate] (796.692 ms) : 0, 796692
AgentMeter [baseline] (11.563 ms) : 0, 11563
AgentMeter [candidate] (11.35 ms) : 0, 11350
GlobalTracer [baseline] (248.316 ms) : 0, 248316
GlobalTracer [candidate] (247.424 ms) : 0, 247424
IAST [baseline] (25.319 ms) : 0, 25319
IAST [candidate] (25.134 ms) : 0, 25134
AppSec [baseline] (26.545 ms) : 0, 26545
AppSec [candidate] (26.351 ms) : 0, 26351
Debugger [baseline] (62.977 ms) : 0, 62977
Debugger [candidate] (62.576 ms) : 0, 62576
Remote Config [baseline] (536.381 µs) : 0, 536
Remote Config [candidate] (524.216 µs) : 0, 524
Telemetry [baseline] (15.035 ms) : 0, 15035
Telemetry [candidate] (15.43 ms) : 0, 15430
Flare Poller [baseline] (4.575 ms) : 0, 4575
Flare Poller [candidate] (4.279 ms) : 0, 4279
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (17.054 ms) : 16883, 17225
. : milestone, 17054,
appsec (18.956 ms) : 18762, 19151
. : milestone, 18956,
code_origins (18.13 ms) : 17949, 18312
. : milestone, 18130,
iast (18.242 ms) : 18061, 18423
. : milestone, 18242,
profiling (18.996 ms) : 18808, 19183
. : milestone, 18996,
tracing (17.691 ms) : 17515, 17866
. : milestone, 17691,
section candidate
no_agent (19.513 ms) : 19315, 19711
. : milestone, 19513,
appsec (18.533 ms) : 18343, 18723
. : milestone, 18533,
code_origins (17.926 ms) : 17747, 18105
. : milestone, 17926,
iast (17.782 ms) : 17606, 17957
. : milestone, 17782,
profiling (18.688 ms) : 18500, 18876
. : milestone, 18688,
tracing (17.882 ms) : 17703, 18061
. : milestone, 17882,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (1.192 ms) : 1180, 1204
. : milestone, 1192,
iast (3.172 ms) : 3127, 3216
. : milestone, 3172,
iast_FULL (6.201 ms) : 6136, 6266
. : milestone, 6201,
iast_GLOBAL (3.711 ms) : 3644, 3778
. : milestone, 3711,
profiling (2.102 ms) : 2082, 2121
. : milestone, 2102,
tracing (1.775 ms) : 1761, 1789
. : milestone, 1775,
section candidate
no_agent (1.182 ms) : 1171, 1193
. : milestone, 1182,
iast (3.247 ms) : 3197, 3297
. : milestone, 3247,
iast_FULL (5.868 ms) : 5809, 5927
. : milestone, 5868,
iast_GLOBAL (3.729 ms) : 3679, 3779
. : milestone, 3729,
profiling (2.061 ms) : 2042, 2079
. : milestone, 2061,
tracing (1.782 ms) : 1767, 1797
. : milestone, 1782,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (15.488 s) : 15488000, 15488000
. : milestone, 15488000,
appsec (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
iast (17.979 s) : 17979000, 17979000
. : milestone, 17979000,
iast_GLOBAL (17.596 s) : 17596000, 17596000
. : milestone, 17596000,
profiling (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
tracing (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
section candidate
no_agent (15.541 s) : 15541000, 15541000
. : milestone, 15541000,
appsec (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
iast (17.732 s) : 17732000, 17732000
. : milestone, 17732000,
iast_GLOBAL (17.691 s) : 17691000, 17691000
. : milestone, 17691000,
profiling (15.435 s) : 15435000, 15435000
. : milestone, 15435000,
tracing (15.076 s) : 15076000, 15076000
. : milestone, 15076000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~6df5c84224, baseline=1.61.0-SNAPSHOT~93c3816062
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
. : milestone, 1484,
appsec (2.531 ms) : 2476, 2586
. : milestone, 2531,
iast (2.271 ms) : 2202, 2341
. : milestone, 2271,
iast_GLOBAL (2.322 ms) : 2253, 2392
. : milestone, 2322,
profiling (2.134 ms) : 2076, 2191
. : milestone, 2134,
tracing (2.065 ms) : 2011, 2119
. : milestone, 2065,
section candidate
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (3.813 ms) : 3589, 4036
. : milestone, 3813,
iast (2.267 ms) : 2198, 2337
. : milestone, 2267,
iast_GLOBAL (2.315 ms) : 2245, 2385
. : milestone, 2315,
profiling (2.111 ms) : 2055, 2168
. : milestone, 2111,
tracing (2.088 ms) : 2034, 2142
. : milestone, 2088,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Replaces calls to
Objects.hash()withHashingUtils.hash()in theMetricCollectorto avoidObject[]allocation from var-args call.Motivation
Reduces
Object[]allocation which reduces GC activityAdditional Notes
Updated two
hashCode()method implementations in theMetricCollectorinner classes to useHashingUtils.hash()instead ofObjects.hash().Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issuePR by Bits
View session in Datadog
Comment @DataDog to request changes