Skip to content

Fix flaky cron trigger test in SpringSchedulingTest #10792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bm1549 wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −8
Open

Fix flaky cron trigger test in SpringSchedulingTest #10792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa57bcf
Fix flaky cron trigger test by closing context before assertions
bm1549 Mar 10, 2026
072361c
Fix ConditionNotSatisfiedError by capturing cron tasks before context…
bm1549 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...ntation/spring/spring-scheduling-3.1/src/latestDepTest/groovy/SpringSchedulingTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,14 @@ class SpringSchedulingTest extends InstrumentationSpecification {
setup:
def context = new AnnotationConfigApplicationContext(TriggerTaskConfig, SchedulingConfig)
def task = context.getBean(TriggerTask)
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)

task.blockUntilExecute()
// Capture cron tasks before closing the context (endpoint is unavailable after close).
def cronTasks = scheduledTaskEndpoint.scheduledTasks().getCron()
// Close the context immediately after the first execution to prevent a second cron
// firing before assertions complete, which would produce extra traces and cause flakiness.
context.close()

expect:
assert task != null
Expand Down Expand Up @@ -54,13 +60,10 @@ class SpringSchedulingTest extends InstrumentationSpecification {
}
}
and:
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)
assert scheduledTaskEndpoint != null
scheduledTaskEndpoint.scheduledTasks().getCron().each {
cronTasks.each {
it.getRunnable().getTarget() == TriggerTask.getName()
}
cleanup:
context.close()
}

def "schedule interval test"() {
Expand Down
11 changes: 7 additions & 4 deletions .../instrumentation/spring/spring-scheduling-3.1/src/test/groovy/SpringSchedulingTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,14 @@ class SpringSchedulingTest extends InstrumentationSpecification {
setup:
def context = new AnnotationConfigApplicationContext(TriggerTaskConfig, SchedulingConfig)
def task = context.getBean(TriggerTask)
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)

task.blockUntilExecute()
// Capture cron tasks before closing the context (endpoint is unavailable after close).
def cronTasks = scheduledTaskEndpoint.scheduledTasks().getCron()
// Close the context immediately after the first execution to prevent a second cron
// firing before assertions complete, which would produce extra traces and cause flakiness.
context.close()

expect:
assert task != null
Expand Down Expand Up @@ -54,13 +60,10 @@ class SpringSchedulingTest extends InstrumentationSpecification {
}
}
and:
def scheduledTaskEndpoint = context.getBean(ScheduledTasksEndpoint)
assert scheduledTaskEndpoint != null
scheduledTaskEndpoint.scheduledTasks().getCron().each {
cronTasks.each {
it.getRunnable().getTarget() == TriggerTask.getName()
}
cleanup:
context.close()
}

def "schedule interval test"() {
Expand Down
Loading