Piotr.wolski/capture kafka producer consumer configs#10697
Draft
piochelepiotr wants to merge 7 commits intomasterfrom
Draft
Piotr.wolski/capture kafka producer consumer configs#10697piochelepiotr wants to merge 7 commits intomasterfrom
piochelepiotr wants to merge 7 commits intomasterfrom
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 7 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067098
Total [baseline] (11.127 s) : 0, 11127101
Agent [candidate] (1.058 s) : 0, 1057520
Total [candidate] (11.016 s) : 0, 11016003
section appsec
Agent [baseline] (1.252 s) : 0, 1252226
Total [baseline] (11.252 s) : 0, 11252154
Agent [candidate] (1.245 s) : 0, 1245368
Total [candidate] (11.183 s) : 0, 11183240
section iast
Agent [baseline] (1.228 s) : 0, 1227526
Total [baseline] (11.4 s) : 0, 11399849
Agent [candidate] (1.228 s) : 0, 1228174
Total [candidate] (11.26 s) : 0, 11259606
section profiling
Agent [baseline] (1.192 s) : 0, 1191539
Total [baseline] (11.134 s) : 0, 11134010
Agent [candidate] (1.188 s) : 0, 1187895
Total [candidate] (11.083 s) : 0, 11082672
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (633.629 ms) : 0, 633629
BytebuddyAgent [candidate] (626.959 ms) : 0, 626959
AgentMeter [baseline] (29.263 ms) : 0, 29263
AgentMeter [candidate] (28.96 ms) : 0, 28960
GlobalTracer [baseline] (258.686 ms) : 0, 258686
GlobalTracer [candidate] (255.962 ms) : 0, 255962
AppSec [baseline] (31.729 ms) : 0, 31729
AppSec [candidate] (31.386 ms) : 0, 31386
Debugger [baseline] (59.649 ms) : 0, 59649
Debugger [candidate] (59.173 ms) : 0, 59173
Remote Config [baseline] (627.506 µs) : 0, 628
Remote Config [candidate] (578.311 µs) : 0, 578
Telemetry [baseline] (8.706 ms) : 0, 8706
Telemetry [candidate] (8.589 ms) : 0, 8589
Flare Poller [baseline] (7.398 ms) : 0, 7398
Flare Poller [candidate] (8.805 ms) : 0, 8805
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (661.324 ms) : 0, 661324
BytebuddyAgent [candidate] (657.727 ms) : 0, 657727
AgentMeter [baseline] (12.13 ms) : 0, 12130
AgentMeter [candidate] (12.031 ms) : 0, 12031
GlobalTracer [baseline] (259.477 ms) : 0, 259477
GlobalTracer [candidate] (258.174 ms) : 0, 258174
IAST [baseline] (24.227 ms) : 0, 24227
IAST [candidate] (23.945 ms) : 0, 23945
AppSec [baseline] (177.825 ms) : 0, 177825
AppSec [candidate] (177.106 ms) : 0, 177106
Debugger [baseline] (66.505 ms) : 0, 66505
Debugger [candidate] (65.871 ms) : 0, 65871
Remote Config [baseline] (581.487 µs) : 0, 581
Remote Config [candidate] (569.184 µs) : 0, 569
Telemetry [baseline] (9.03 ms) : 0, 9030
Telemetry [candidate] (8.966 ms) : 0, 8966
Flare Poller [baseline] (3.667 ms) : 0, 3667
Flare Poller [candidate] (3.616 ms) : 0, 3616
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (795.923 ms) : 0, 795923
BytebuddyAgent [candidate] (797.034 ms) : 0, 797034
AgentMeter [baseline] (11.351 ms) : 0, 11351
AgentMeter [candidate] (11.311 ms) : 0, 11311
GlobalTracer [baseline] (247.822 ms) : 0, 247822
GlobalTracer [candidate] (247.771 ms) : 0, 247771
IAST [baseline] (25.239 ms) : 0, 25239
IAST [candidate] (25.072 ms) : 0, 25072
AppSec [baseline] (26.567 ms) : 0, 26567
AppSec [candidate] (26.319 ms) : 0, 26319
Debugger [baseline] (64.422 ms) : 0, 64422
Debugger [candidate] (64.76 ms) : 0, 64760
Remote Config [baseline] (516.667 µs) : 0, 517
Remote Config [candidate] (504.339 µs) : 0, 504
Telemetry [baseline] (13.817 ms) : 0, 13817
Telemetry [candidate] (13.947 ms) : 0, 13947
Flare Poller [baseline] (4.598 ms) : 0, 4598
Flare Poller [candidate] (4.355 ms) : 0, 4355
section profiling
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (686.546 ms) : 0, 686546
BytebuddyAgent [candidate] (686.514 ms) : 0, 686514
AgentMeter [baseline] (8.706 ms) : 0, 8706
AgentMeter [candidate] (8.659 ms) : 0, 8659
GlobalTracer [baseline] (217.613 ms) : 0, 217613
GlobalTracer [candidate] (216.438 ms) : 0, 216438
AppSec [baseline] (32.512 ms) : 0, 32512
AppSec [candidate] (32.111 ms) : 0, 32111
Debugger [baseline] (65.223 ms) : 0, 65223
Debugger [candidate] (65.604 ms) : 0, 65604
Remote Config [baseline] (590.465 µs) : 0, 590
Remote Config [candidate] (589.863 µs) : 0, 590
Telemetry [baseline] (9.123 ms) : 0, 9123
Telemetry [candidate] (8.118 ms) : 0, 8118
Flare Poller [baseline] (3.612 ms) : 0, 3612
Flare Poller [candidate] (3.477 ms) : 0, 3477
ProfilingAgent [baseline] (95.003 ms) : 0, 95003
ProfilingAgent [candidate] (93.988 ms) : 0, 93988
Profiling [baseline] (95.578 ms) : 0, 95578
Profiling [candidate] (94.554 ms) : 0, 94554
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060985
Total [baseline] (8.815 s) : 0, 8814877
Agent [candidate] (1.065 s) : 0, 1065297
Total [candidate] (8.856 s) : 0, 8855810
section iast
Agent [baseline] (1.243 s) : 0, 1242637
Total [baseline] (9.591 s) : 0, 9591282
Agent [candidate] (1.234 s) : 0, 1234158
Total [candidate] (9.558 s) : 0, 9558182
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.209 ms) : 0, 1209
BytebuddyAgent [baseline] (629.869 ms) : 0, 629869
BytebuddyAgent [candidate] (633.107 ms) : 0, 633107
AgentMeter [baseline] (29.138 ms) : 0, 29138
AgentMeter [candidate] (29.2 ms) : 0, 29200
GlobalTracer [baseline] (256.907 ms) : 0, 256907
GlobalTracer [candidate] (258.121 ms) : 0, 258121
AppSec [baseline] (31.514 ms) : 0, 31514
AppSec [candidate] (31.873 ms) : 0, 31873
Debugger [baseline] (58.724 ms) : 0, 58724
Debugger [candidate] (58.963 ms) : 0, 58963
Remote Config [baseline] (615.857 µs) : 0, 616
Remote Config [candidate] (590.704 µs) : 0, 591
Telemetry [baseline] (8.691 ms) : 0, 8691
Telemetry [candidate] (8.721 ms) : 0, 8721
Flare Poller [baseline] (8.084 ms) : 0, 8084
Flare Poller [candidate] (7.317 ms) : 0, 7317
section iast
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (807.818 ms) : 0, 807818
BytebuddyAgent [candidate] (802.221 ms) : 0, 802221
AgentMeter [baseline] (11.781 ms) : 0, 11781
AgentMeter [candidate] (11.53 ms) : 0, 11530
GlobalTracer [baseline] (249.715 ms) : 0, 249715
GlobalTracer [candidate] (248.365 ms) : 0, 248365
IAST [baseline] (25.628 ms) : 0, 25628
IAST [candidate] (25.228 ms) : 0, 25228
AppSec [baseline] (26.866 ms) : 0, 26866
AppSec [candidate] (26.453 ms) : 0, 26453
Debugger [baseline] (62.923 ms) : 0, 62923
Debugger [candidate] (62.874 ms) : 0, 62874
Remote Config [baseline] (513.965 µs) : 0, 514
Remote Config [candidate] (518.355 µs) : 0, 518
Telemetry [baseline] (14.889 ms) : 0, 14889
Telemetry [candidate] (14.834 ms) : 0, 14834
Flare Poller [baseline] (4.931 ms) : 0, 4931
Flare Poller [candidate] (4.781 ms) : 0, 4781
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.177 ms) : 1165, 1188
. : milestone, 1177,
iast (3.202 ms) : 3158, 3246
. : milestone, 3202,
iast_FULL (5.931 ms) : 5871, 5990
. : milestone, 5931,
iast_GLOBAL (3.508 ms) : 3459, 3557
. : milestone, 3508,
profiling (2.231 ms) : 2211, 2252
. : milestone, 2231,
tracing (1.815 ms) : 1799, 1830
. : milestone, 1815,
section candidate
no_agent (1.195 ms) : 1183, 1206
. : milestone, 1195,
iast (3.054 ms) : 3012, 3096
. : milestone, 3054,
iast_FULL (5.702 ms) : 5646, 5757
. : milestone, 5702,
iast_GLOBAL (3.61 ms) : 3554, 3665
. : milestone, 3610,
profiling (2.076 ms) : 2058, 2095
. : milestone, 2076,
tracing (1.781 ms) : 1767, 1795
. : milestone, 1781,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (19.492 ms) : 19292, 19692
. : milestone, 19492,
appsec (19.082 ms) : 18887, 19277
. : milestone, 19082,
code_origins (17.672 ms) : 17496, 17848
. : milestone, 17672,
iast (17.807 ms) : 17633, 17981
. : milestone, 17807,
profiling (19.413 ms) : 19219, 19608
. : milestone, 19413,
tracing (17.882 ms) : 17705, 18059
. : milestone, 17882,
section candidate
no_agent (19.42 ms) : 19220, 19620
. : milestone, 19420,
appsec (18.558 ms) : 18372, 18744
. : milestone, 18558,
code_origins (18.702 ms) : 18515, 18889
. : milestone, 18702,
iast (17.683 ms) : 17512, 17855
. : milestone, 17683,
profiling (18.418 ms) : 18235, 18601
. : milestone, 18418,
tracing (17.649 ms) : 17474, 17825
. : milestone, 17649,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.523 ms) : 2469, 2578
. : milestone, 2523,
iast (2.266 ms) : 2197, 2335
. : milestone, 2266,
iast_GLOBAL (2.297 ms) : 2228, 2367
. : milestone, 2297,
profiling (2.088 ms) : 2033, 2142
. : milestone, 2088,
tracing (2.064 ms) : 2010, 2117
. : milestone, 2064,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.793 ms) : 3574, 4012
. : milestone, 3793,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.295 ms) : 2225, 2364
. : milestone, 2295,
profiling (2.092 ms) : 2037, 2146
. : milestone, 2092,
tracing (2.056 ms) : 2003, 2109
. : milestone, 2056,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~a0208b97fe, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
iast (17.754 s) : 17754000, 17754000
. : milestone, 17754000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
. : milestone, 17869000,
profiling (14.962 s) : 14962000, 14962000
. : milestone, 14962000,
tracing (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
section candidate
no_agent (15.274 s) : 15274000, 15274000
. : milestone, 15274000,
appsec (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
iast (17.689 s) : 17689000, 17689000
. : milestone, 17689000,
iast_GLOBAL (17.672 s) : 17672000, 17672000
. : milestone, 17672000,
profiling (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
|
- Fix MetadataState class name to use fully qualified name in KafkaProducerInstrumentation (helperClassNames and contextStore), which was causing producer spans to break due to context store mismatch - Replace sensitive keys denylist with an allowlist of safe config keys - Mask values of non-allowed keys with "****" instead of dropping them, to enable monitoring of which configs are seen but not yet allowed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fd826ee to
1ecfe51
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In Groovy, `map[expr1] = expr2` evaluates expr2 before expr1, which swapped msgpack key/value reads. Use temp variables instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.