-
Notifications
You must be signed in to change notification settings - Fork 323
Cleanup duplicate condition check. #10326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cleanup duplicate condition check. #10326
Conversation
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086793
Total [baseline] (8.789 s) : 0, 8788933
Agent [candidate] (1.092 s) : 0, 1091708
Total [candidate] (8.769 s) : 0, 8769293
section iast
Agent [baseline] (1.226 s) : 0, 1226080
Total [baseline] (9.296 s) : 0, 9296458
Agent [candidate] (1.231 s) : 0, 1230964
Total [candidate] (9.343 s) : 0, 9342773
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (652.96 ms) : 0, 652960
BytebuddyAgent [candidate] (656.105 ms) : 0, 656105
GlobalTracer [baseline] (283.102 ms) : 0, 283102
GlobalTracer [candidate] (284.205 ms) : 0, 284205
AppSec [baseline] (32.772 ms) : 0, 32772
AppSec [candidate] (32.856 ms) : 0, 32856
Debugger [baseline] (67.705 ms) : 0, 67705
Debugger [candidate] (68.475 ms) : 0, 68475
Remote Config [baseline] (631.48 µs) : 0, 631
Remote Config [candidate] (628.038 µs) : 0, 628
Telemetry [baseline] (9.067 ms) : 0, 9067
Telemetry [candidate] (8.977 ms) : 0, 8977
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.72 ms) : 0, 3720
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (793.744 ms) : 0, 793744
BytebuddyAgent [candidate] (797.757 ms) : 0, 797757
GlobalTracer [baseline] (256.471 ms) : 0, 256471
GlobalTracer [candidate] (257.71 ms) : 0, 257710
IAST [baseline] (27.046 ms) : 0, 27046
IAST [candidate] (26.991 ms) : 0, 26991
AppSec [baseline] (33.526 ms) : 0, 33526
AppSec [candidate] (34.619 ms) : 0, 34619
Debugger [baseline] (66.032 ms) : 0, 66032
Debugger [candidate] (64.639 ms) : 0, 64639
Remote Config [baseline] (616.079 µs) : 0, 616
Remote Config [candidate] (577.808 µs) : 0, 578
Telemetry [baseline] (8.447 ms) : 0, 8447
Telemetry [candidate] (8.502 ms) : 0, 8502
Flare Poller [baseline] (3.517 ms) : 0, 3517
Flare Poller [candidate] (3.532 ms) : 0, 3532
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091168
Total [baseline] (10.723 s) : 0, 10723314
Agent [candidate] (1.086 s) : 0, 1085623
Total [candidate] (10.817 s) : 0, 10816796
section appsec
Agent [baseline] (1.265 s) : 0, 1265454
Total [baseline] (10.901 s) : 0, 10900758
Agent [candidate] (1.269 s) : 0, 1269375
Total [candidate] (10.919 s) : 0, 10918802
section iast
Agent [baseline] (1.228 s) : 0, 1228235
Total [baseline] (11.295 s) : 0, 11295116
Agent [candidate] (1.24 s) : 0, 1239606
Total [candidate] (11.165 s) : 0, 11165058
section profiling
Agent [baseline] (1.207 s) : 0, 1206701
Total [baseline] (10.947 s) : 0, 10946661
Agent [candidate] (1.206 s) : 0, 1206438
Total [candidate] (10.887 s) : 0, 10886991
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (655.33 ms) : 0, 655330
BytebuddyAgent [candidate] (651.731 ms) : 0, 651731
GlobalTracer [baseline] (284.091 ms) : 0, 284091
GlobalTracer [candidate] (282.643 ms) : 0, 282643
AppSec [baseline] (32.789 ms) : 0, 32789
AppSec [candidate] (32.798 ms) : 0, 32798
Debugger [baseline] (68.76 ms) : 0, 68760
Debugger [candidate] (68.466 ms) : 0, 68466
Remote Config [baseline] (612.887 µs) : 0, 613
Remote Config [candidate] (610.717 µs) : 0, 611
Telemetry [baseline] (9.066 ms) : 0, 9066
Telemetry [candidate] (8.977 ms) : 0, 8977
Flare Poller [baseline] (3.718 ms) : 0, 3718
Flare Poller [candidate] (3.77 ms) : 0, 3770
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (691.466 ms) : 0, 691466
BytebuddyAgent [candidate] (691.654 ms) : 0, 691654
GlobalTracer [baseline] (258.252 ms) : 0, 258252
GlobalTracer [candidate] (259.663 ms) : 0, 259663
AppSec [baseline] (174.345 ms) : 0, 174345
AppSec [candidate] (174.105 ms) : 0, 174105
Debugger [baseline] (66.334 ms) : 0, 66334
Debugger [candidate] (68.371 ms) : 0, 68371
Remote Config [baseline] (740.857 µs) : 0, 741
Remote Config [candidate] (795.647 µs) : 0, 796
Telemetry [baseline] (9.279 ms) : 0, 9279
Telemetry [candidate] (9.626 ms) : 0, 9626
Flare Poller [baseline] (3.771 ms) : 0, 3771
Flare Poller [candidate] (3.793 ms) : 0, 3793
IAST [baseline] (24.69 ms) : 0, 24690
IAST [candidate] (24.791 ms) : 0, 24791
section iast
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (792.934 ms) : 0, 792934
BytebuddyAgent [candidate] (802.784 ms) : 0, 802784
GlobalTracer [baseline] (257.294 ms) : 0, 257294
GlobalTracer [candidate] (259.032 ms) : 0, 259032
AppSec [baseline] (33.876 ms) : 0, 33876
AppSec [candidate] (34.686 ms) : 0, 34686
Debugger [baseline] (67.345 ms) : 0, 67345
Debugger [candidate] (66.164 ms) : 0, 66164
Remote Config [baseline] (595.621 µs) : 0, 596
Remote Config [candidate] (558.046 µs) : 0, 558
Telemetry [baseline] (8.564 ms) : 0, 8564
Telemetry [candidate] (8.558 ms) : 0, 8558
Flare Poller [baseline] (3.551 ms) : 0, 3551
Flare Poller [candidate] (3.546 ms) : 0, 3546
IAST [baseline] (27.489 ms) : 0, 27489
IAST [candidate] (27.451 ms) : 0, 27451
section profiling
ProfilingAgent [baseline] (97.07 ms) : 0, 97070
ProfilingAgent [candidate] (96.506 ms) : 0, 96506
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (704.54 ms) : 0, 704540
BytebuddyAgent [candidate] (705.027 ms) : 0, 705027
GlobalTracer [baseline] (220.727 ms) : 0, 220727
GlobalTracer [candidate] (220.847 ms) : 0, 220847
AppSec [baseline] (32.169 ms) : 0, 32169
AppSec [candidate] (32.232 ms) : 0, 32232
Debugger [baseline] (67.998 ms) : 0, 67998
Debugger [candidate] (67.799 ms) : 0, 67799
Remote Config [baseline] (633.355 µs) : 0, 633
Remote Config [candidate] (644.484 µs) : 0, 644
Telemetry [baseline] (8.799 ms) : 0, 8799
Telemetry [candidate] (8.685 ms) : 0, 8685
Flare Poller [baseline] (3.626 ms) : 0, 3626
Flare Poller [candidate] (3.657 ms) : 0, 3657
Profiling [baseline] (97.661 ms) : 0, 97661
Profiling [candidate] (97.075 ms) : 0, 97075
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (18.116 ms) : 17932, 18300
. : milestone, 18116,
appsec (18.433 ms) : 18243, 18624
. : milestone, 18433,
code_origins (17.694 ms) : 17517, 17870
. : milestone, 17694,
iast (18.129 ms) : 17948, 18311
. : milestone, 18129,
profiling (19.092 ms) : 18901, 19282
. : milestone, 19092,
tracing (17.733 ms) : 17560, 17905
. : milestone, 17733,
section candidate
no_agent (18.245 ms) : 18057, 18434
. : milestone, 18245,
appsec (18.628 ms) : 18441, 18816
. : milestone, 18628,
code_origins (18.045 ms) : 17866, 18224
. : milestone, 18045,
iast (18.589 ms) : 18400, 18778
. : milestone, 18589,
profiling (18.832 ms) : 18647, 19017
. : milestone, 18832,
tracing (18.01 ms) : 17830, 18191
. : milestone, 18010,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (1.206 ms) : 1194, 1218
. : milestone, 1206,
iast (3.259 ms) : 3217, 3302
. : milestone, 3259,
iast_FULL (5.969 ms) : 5909, 6030
. : milestone, 5969,
iast_GLOBAL (3.625 ms) : 3572, 3678
. : milestone, 3625,
profiling (2.105 ms) : 2084, 2126
. : milestone, 2105,
tracing (1.786 ms) : 1770, 1801
. : milestone, 1786,
section candidate
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.152 ms) : 3112, 3191
. : milestone, 3152,
iast_FULL (5.468 ms) : 5415, 5521
. : milestone, 5468,
iast_GLOBAL (3.529 ms) : 3474, 3584
. : milestone, 3529,
profiling (2.226 ms) : 2205, 2247
. : milestone, 2226,
tracing (1.803 ms) : 1787, 1820
. : milestone, 1803,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (15.495 s) : 15495000, 15495000
. : milestone, 15495000,
appsec (14.705 s) : 14705000, 14705000
. : milestone, 14705000,
iast (17.892 s) : 17892000, 17892000
. : milestone, 17892000,
iast_GLOBAL (17.732 s) : 17732000, 17732000
. : milestone, 17732000,
profiling (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
tracing (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
section candidate
no_agent (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
appsec (14.307 s) : 14307000, 14307000
. : milestone, 14307000,
iast (18.32 s) : 18320000, 18320000
. : milestone, 18320000,
iast_GLOBAL (17.813 s) : 17813000, 17813000
. : milestone, 17813000,
profiling (14.913 s) : 14913000, 14913000
. : milestone, 14913000,
tracing (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4dc965d37b, baseline=1.59.0-SNAPSHOT~61273bcf0b
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.654 ms) : 3440, 3868
. : milestone, 3654,
iast (2.215 ms) : 2150, 2280
. : milestone, 2215,
iast_GLOBAL (2.258 ms) : 2192, 2323
. : milestone, 2258,
profiling (2.093 ms) : 2039, 2148
. : milestone, 2093,
tracing (2.043 ms) : 1991, 2095
. : milestone, 2043,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.728 ms) : 3508, 3948
. : milestone, 3728,
iast (2.21 ms) : 2145, 2274
. : milestone, 2210,
iast_GLOBAL (2.264 ms) : 2198, 2330
. : milestone, 2264,
profiling (2.074 ms) : 2021, 2127
. : milestone, 2074,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
|
What Does This Do
Cleanup duplicate condition check.
Motivation
Clean code.
Additional Notes
Found by IDEA static analysis.