-
Notifications
You must be signed in to change notification settings - Fork 323
Separate few InstrumenterModule from Instrumenter #10324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1086277
Total [baseline] (10.842 s) : 0, 10842369
Agent [candidate] (1.086 s) : 0, 1086459
Total [candidate] (10.868 s) : 0, 10868253
section appsec
Agent [baseline] (1.267 s) : 0, 1266600
Total [baseline] (11.041 s) : 0, 11041489
Agent [candidate] (1.265 s) : 0, 1264932
Total [candidate] (10.958 s) : 0, 10957605
section iast
Agent [baseline] (1.225 s) : 0, 1224551
Total [baseline] (11.163 s) : 0, 11162698
Agent [candidate] (1.225 s) : 0, 1225157
Total [candidate] (11.159 s) : 0, 11158536
section profiling
Agent [baseline] (1.214 s) : 0, 1213563
Total [baseline] (10.947 s) : 0, 10947138
Agent [candidate] (1.205 s) : 0, 1205016
Total [candidate] (10.878 s) : 0, 10878364
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (651.254 ms) : 0, 651254
BytebuddyAgent [candidate] (651.436 ms) : 0, 651436
GlobalTracer [baseline] (283.163 ms) : 0, 283163
GlobalTracer [candidate] (283.131 ms) : 0, 283131
AppSec [baseline] (32.674 ms) : 0, 32674
AppSec [candidate] (32.687 ms) : 0, 32687
Debugger [baseline] (68.758 ms) : 0, 68758
Debugger [candidate] (68.87 ms) : 0, 68870
Remote Config [baseline] (634.907 µs) : 0, 635
Remote Config [candidate] (610.345 µs) : 0, 610
Telemetry [baseline] (9.16 ms) : 0, 9160
Telemetry [candidate] (9.141 ms) : 0, 9141
Flare Poller [baseline] (3.898 ms) : 0, 3898
Flare Poller [candidate] (3.853 ms) : 0, 3853
section appsec
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (691.363 ms) : 0, 691363
BytebuddyAgent [candidate] (690.651 ms) : 0, 690651
GlobalTracer [baseline] (258.316 ms) : 0, 258316
GlobalTracer [candidate] (258.877 ms) : 0, 258877
AppSec [baseline] (173.175 ms) : 0, 173175
AppSec [candidate] (172.513 ms) : 0, 172513
Debugger [baseline] (68.569 ms) : 0, 68569
Debugger [candidate] (67.7 ms) : 0, 67700
Remote Config [baseline] (729.898 µs) : 0, 730
Remote Config [candidate] (761.753 µs) : 0, 762
Telemetry [baseline] (9.512 ms) : 0, 9512
Telemetry [candidate] (9.323 ms) : 0, 9323
Flare Poller [baseline] (3.787 ms) : 0, 3787
Flare Poller [candidate] (3.895 ms) : 0, 3895
IAST [baseline] (24.609 ms) : 0, 24609
IAST [candidate] (24.571 ms) : 0, 24571
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (792.372 ms) : 0, 792372
BytebuddyAgent [candidate] (792.279 ms) : 0, 792279
GlobalTracer [baseline] (255.82 ms) : 0, 255820
GlobalTracer [candidate] (256.215 ms) : 0, 256215
AppSec [baseline] (31.966 ms) : 0, 31966
AppSec [candidate] (34.366 ms) : 0, 34366
Debugger [baseline] (68.265 ms) : 0, 68265
Debugger [candidate] (65.81 ms) : 0, 65810
Remote Config [baseline] (615.429 µs) : 0, 615
Remote Config [candidate] (631.569 µs) : 0, 632
Telemetry [baseline] (8.552 ms) : 0, 8552
Telemetry [candidate] (8.581 ms) : 0, 8581
Flare Poller [baseline] (3.439 ms) : 0, 3439
Flare Poller [candidate] (3.535 ms) : 0, 3535
IAST [baseline] (27.013 ms) : 0, 27013
IAST [candidate] (27.258 ms) : 0, 27258
section profiling
ProfilingAgent [baseline] (97.088 ms) : 0, 97088
ProfilingAgent [candidate] (96.963 ms) : 0, 96963
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (708.269 ms) : 0, 708269
BytebuddyAgent [candidate] (702.437 ms) : 0, 702437
GlobalTracer [baseline] (222.227 ms) : 0, 222227
GlobalTracer [candidate] (220.827 ms) : 0, 220827
AppSec [baseline] (32.943 ms) : 0, 32943
AppSec [candidate] (32.275 ms) : 0, 32275
Debugger [baseline] (68.375 ms) : 0, 68375
Debugger [candidate] (68.16 ms) : 0, 68160
Remote Config [baseline] (664.791 µs) : 0, 665
Remote Config [candidate] (662.959 µs) : 0, 663
Telemetry [baseline] (8.8 ms) : 0, 8800
Telemetry [candidate] (8.914 ms) : 0, 8914
Flare Poller [baseline] (3.678 ms) : 0, 3678
Flare Poller [candidate] (3.773 ms) : 0, 3773
Profiling [baseline] (97.688 ms) : 0, 97688
Profiling [candidate] (97.534 ms) : 0, 97534
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091077
Total [baseline] (8.764 s) : 0, 8763719
Agent [candidate] (1.088 s) : 0, 1087871
Total [candidate] (8.745 s) : 0, 8744745
section iast
Agent [baseline] (1.227 s) : 0, 1227418
Total [baseline] (9.339 s) : 0, 9339176
Agent [candidate] (1.228 s) : 0, 1228410
Total [candidate] (9.336 s) : 0, 9335610
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (655.469 ms) : 0, 655469
BytebuddyAgent [candidate] (654.49 ms) : 0, 654490
GlobalTracer [baseline] (284.275 ms) : 0, 284275
GlobalTracer [candidate] (282.61 ms) : 0, 282610
AppSec [baseline] (33.15 ms) : 0, 33150
AppSec [candidate] (32.529 ms) : 0, 32529
Debugger [baseline] (67.791 ms) : 0, 67791
Debugger [candidate] (67.84 ms) : 0, 67840
Remote Config [baseline] (652.735 µs) : 0, 653
Remote Config [candidate] (626.208 µs) : 0, 626
Telemetry [baseline] (9.07 ms) : 0, 9070
Telemetry [candidate] (9.231 ms) : 0, 9231
Flare Poller [baseline] (3.849 ms) : 0, 3849
Flare Poller [candidate] (3.847 ms) : 0, 3847
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (793.107 ms) : 0, 793107
BytebuddyAgent [candidate] (795.761 ms) : 0, 795761
GlobalTracer [baseline] (257.064 ms) : 0, 257064
GlobalTracer [candidate] (256.406 ms) : 0, 256406
IAST [baseline] (27.277 ms) : 0, 27277
IAST [candidate] (27.046 ms) : 0, 27046
AppSec [baseline] (33.768 ms) : 0, 33768
AppSec [candidate] (32.63 ms) : 0, 32630
Debugger [baseline] (66.743 ms) : 0, 66743
Debugger [candidate] (67.161 ms) : 0, 67161
Remote Config [baseline] (595.332 µs) : 0, 595
Remote Config [candidate] (625.26 µs) : 0, 625
Telemetry [baseline] (8.762 ms) : 0, 8762
Telemetry [candidate] (8.574 ms) : 0, 8574
Flare Poller [baseline] (3.577 ms) : 0, 3577
Flare Poller [candidate] (3.533 ms) : 0, 3533
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section baseline
no_agent (17.689 ms) : 17510, 17867
. : milestone, 17689,
appsec (18.937 ms) : 18744, 19129
. : milestone, 18937,
code_origins (17.925 ms) : 17745, 18105
. : milestone, 17925,
iast (17.724 ms) : 17547, 17900
. : milestone, 17724,
profiling (18.563 ms) : 18377, 18749
. : milestone, 18563,
tracing (18.109 ms) : 17932, 18286
. : milestone, 18109,
section candidate
no_agent (18.148 ms) : 17962, 18335
. : milestone, 18148,
appsec (18.749 ms) : 18558, 18940
. : milestone, 18749,
code_origins (18.842 ms) : 18650, 19035
. : milestone, 18842,
iast (17.615 ms) : 17440, 17789
. : milestone, 17615,
profiling (18.687 ms) : 18498, 18876
. : milestone, 18687,
tracing (17.722 ms) : 17544, 17900
. : milestone, 17722,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section baseline
no_agent (1.202 ms) : 1190, 1213
. : milestone, 1202,
iast (3.168 ms) : 3129, 3207
. : milestone, 3168,
iast_FULL (5.611 ms) : 5555, 5666
. : milestone, 5611,
iast_GLOBAL (3.656 ms) : 3595, 3718
. : milestone, 3656,
profiling (1.94 ms) : 1924, 1957
. : milestone, 1940,
tracing (1.766 ms) : 1752, 1780
. : milestone, 1766,
section candidate
no_agent (1.204 ms) : 1192, 1216
. : milestone, 1204,
iast (3.239 ms) : 3199, 3280
. : milestone, 3239,
iast_FULL (5.809 ms) : 5752, 5867
. : milestone, 5809,
iast_GLOBAL (3.54 ms) : 3488, 3592
. : milestone, 3540,
profiling (2.101 ms) : 2082, 2121
. : milestone, 2101,
tracing (1.81 ms) : 1794, 1827
. : milestone, 1810,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section baseline
no_agent (15.11 s) : 15110000, 15110000
. : milestone, 15110000,
appsec (14.705 s) : 14705000, 14705000
. : milestone, 14705000,
iast (18.059 s) : 18059000, 18059000
. : milestone, 18059000,
iast_GLOBAL (17.946 s) : 17946000, 17946000
. : milestone, 17946000,
profiling (14.855 s) : 14855000, 14855000
. : milestone, 14855000,
tracing (14.584 s) : 14584000, 14584000
. : milestone, 14584000,
section candidate
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (14.415 s) : 14415000, 14415000
. : milestone, 14415000,
iast (18.207 s) : 18207000, 18207000
. : milestone, 18207000,
iast_GLOBAL (17.711 s) : 17711000, 17711000
. : milestone, 17711000,
profiling (14.75 s) : 14750000, 14750000
. : milestone, 14750000,
tracing (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~4260b461f9, baseline=1.59.0-SNAPSHOT~8260d96412
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.476 ms) : 2425, 2528
. : milestone, 2476,
iast (2.223 ms) : 2158, 2288
. : milestone, 2223,
iast_GLOBAL (2.269 ms) : 2204, 2335
. : milestone, 2269,
profiling (2.086 ms) : 2033, 2139
. : milestone, 2086,
tracing (2.06 ms) : 2009, 2111
. : milestone, 2060,
section candidate
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.757 ms) : 3537, 3976
. : milestone, 3757,
iast (2.229 ms) : 2164, 2294
. : milestone, 2229,
iast_GLOBAL (2.27 ms) : 2205, 2335
. : milestone, 2270,
profiling (2.09 ms) : 2036, 2144
. : milestone, 2090,
tracing (2.049 ms) : 1997, 2100
. : milestone, 2049,
|
fcbbb62 to
4260b46
Compare
mcculls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for tackling this!
What Does This Do
Separate the role of InstrumenterModule and instrumenter for few gradle modules where applicable (i.e. having multiple instrumenter loaded by a single module)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]