Skip to content

Add single InstrumenterModule for group of instrumentation #10320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarziali merged 6 commits into from
Jan 12, 2026
Merged

Add single InstrumenterModule for group of instrumentation #10320

amarziali merged 6 commits into from
Jan 12, 2026

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Jan 9, 2026

What Does This Do

Migrate legacy instrumentations by separating InstrumenterModule from single Instrumenter

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner January 9, 2026 13:08
@amarziali amarziali added the inst: others All other instrumentations label Jan 9, 2026
@amarziali amarziali requested a review from a team as a code owner January 9, 2026 13:08
@amarziali amarziali added tag: no release notes Changes to exclude from release notes type: refactoring labels Jan 9, 2026
@amarziali amarziali requested review from mcculls and removed request for a team January 9, 2026 13:08
@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/ref1
git_commit_date 1767950001 1767963842
git_commit_sha 8ef6e7a ae2c6cd
release_version 1.59.0-SNAPSHOT~8ef6e7ab7b 1.59.0-SNAPSHOT~ae2c6cd137
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1767965886 1767965886
ci_job_id 1338986019 1338986019
ci_pipeline_id 89892096 89892096
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ljrbh6ou 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ljrbh6ou 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084768
Total [baseline] (10.743 s) : 0, 10742519
Agent [candidate] (1.086 s) : 0, 1085550
Total [candidate] (10.825 s) : 0, 10825079
section appsec
Agent [baseline] (1.274 s) : 0, 1274227
Total [baseline] (10.986 s) : 0, 10986130
Agent [candidate] (1.268 s) : 0, 1267855
Total [candidate] (10.898 s) : 0, 10897540
section iast
Agent [baseline] (1.233 s) : 0, 1233447
Total [baseline] (11.264 s) : 0, 11263713
Agent [candidate] (1.224 s) : 0, 1224034
Total [candidate] (11.079 s) : 0, 11078874
section profiling
Agent [baseline] (1.22 s) : 0, 1219579
Total [baseline] (10.985 s) : 0, 10985453
Agent [candidate] (1.204 s) : 0, 1203902
Total [candidate] (10.913 s) : 0, 10913396
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent appsec 1.274 s 189.458 ms (17.5%)
Agent iast 1.233 s 148.678 ms (13.7%)
Agent profiling 1.22 s 134.811 ms (12.4%)
Total tracing 10.743 s -
Total appsec 10.986 s 243.612 ms (2.3%)
Total iast 11.264 s 521.195 ms (4.9%)
Total profiling 10.985 s 242.934 ms (2.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent appsec 1.268 s 182.304 ms (16.8%)
Agent iast 1.224 s 138.484 ms (12.8%)
Agent profiling 1.204 s 118.352 ms (10.9%)
Total tracing 10.825 s -
Total appsec 10.898 s 72.461 ms (0.7%)
Total iast 11.079 s 253.795 ms (2.3%)
Total profiling 10.913 s 88.316 ms (0.8%) 
gantt
    title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (650.999 ms) : 0, 650999
BytebuddyAgent [candidate] (651.447 ms) : 0, 651447
GlobalTracer [baseline] (282.528 ms) : 0, 282528
GlobalTracer [candidate] (283.257 ms) : 0, 283257
AppSec [baseline] (32.749 ms) : 0, 32749
AppSec [candidate] (32.533 ms) : 0, 32533
Debugger [baseline] (68.446 ms) : 0, 68446
Debugger [candidate] (68.18 ms) : 0, 68180
Remote Config [baseline] (619.116 µs) : 0, 619
Remote Config [candidate] (635.621 µs) : 0, 636
Telemetry [baseline] (8.959 ms) : 0, 8959
Telemetry [candidate] (8.882 ms) : 0, 8882
Flare Poller [baseline] (3.724 ms) : 0, 3724
Flare Poller [candidate] (3.798 ms) : 0, 3798
section appsec
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (696.62 ms) : 0, 696620
BytebuddyAgent [candidate] (692.989 ms) : 0, 692989
GlobalTracer [baseline] (259.952 ms) : 0, 259952
GlobalTracer [candidate] (258.338 ms) : 0, 258338
AppSec [baseline] (175.021 ms) : 0, 175021
AppSec [candidate] (173.697 ms) : 0, 173697
Debugger [baseline] (66.949 ms) : 0, 66949
Debugger [candidate] (67.641 ms) : 0, 67641
Remote Config [baseline] (747.928 µs) : 0, 748
Remote Config [candidate] (769.921 µs) : 0, 770
Telemetry [baseline] (9.457 ms) : 0, 9457
Telemetry [candidate] (9.449 ms) : 0, 9449
Flare Poller [baseline] (3.868 ms) : 0, 3868
Flare Poller [candidate] (3.716 ms) : 0, 3716
IAST [baseline] (24.792 ms) : 0, 24792
IAST [candidate] (24.581 ms) : 0, 24581
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (797.546 ms) : 0, 797546
BytebuddyAgent [candidate] (791.449 ms) : 0, 791449
GlobalTracer [baseline] (257.91 ms) : 0, 257910
GlobalTracer [candidate] (255.818 ms) : 0, 255818
AppSec [baseline] (34.83 ms) : 0, 34830
AppSec [candidate] (32.898 ms) : 0, 32898
Debugger [baseline] (66.159 ms) : 0, 66159
Debugger [candidate] (67.705 ms) : 0, 67705
Remote Config [baseline] (569.503 µs) : 0, 570
Remote Config [candidate] (566.634 µs) : 0, 567
Telemetry [baseline] (8.565 ms) : 0, 8565
Telemetry [candidate] (8.502 ms) : 0, 8502
Flare Poller [baseline] (3.614 ms) : 0, 3614
Flare Poller [candidate] (3.508 ms) : 0, 3508
IAST [baseline] (27.474 ms) : 0, 27474
IAST [candidate] (26.926 ms) : 0, 26926
section profiling
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (711.378 ms) : 0, 711378
BytebuddyAgent [candidate] (701.023 ms) : 0, 701023
GlobalTracer [baseline] (223.214 ms) : 0, 223214
GlobalTracer [candidate] (220.773 ms) : 0, 220773
AppSec [baseline] (32.953 ms) : 0, 32953
AppSec [candidate] (32.223 ms) : 0, 32223
Debugger [baseline] (68.821 ms) : 0, 68821
Debugger [candidate] (68.141 ms) : 0, 68141
Remote Config [baseline] (650.51 µs) : 0, 651
Remote Config [candidate] (607.568 µs) : 0, 608
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (8.819 ms) : 0, 8819
Flare Poller [baseline] (3.707 ms) : 0, 3707
Flare Poller [candidate] (3.736 ms) : 0, 3736
ProfilingAgent [baseline] (98.333 ms) : 0, 98333
ProfilingAgent [candidate] (97.67 ms) : 0, 97670
Profiling [baseline] (98.924 ms) : 0, 98924
Profiling [candidate] (98.243 ms) : 0, 98243
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081329
Total [baseline] (8.718 s) : 0, 8718115
Agent [candidate] (1.084 s) : 0, 1084294
Total [candidate] (8.756 s) : 0, 8756318
section iast
Agent [baseline] (1.223 s) : 0, 1223469
Total [baseline] (9.284 s) : 0, 9284313
Agent [candidate] (1.223 s) : 0, 1222782
Total [candidate] (9.328 s) : 0, 9328142
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.223 s 142.139 ms (13.1%)
Total tracing 8.718 s -
Total iast 9.284 s 566.198 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.223 s 138.488 ms (12.8%)
Total tracing 8.756 s -
Total iast 9.328 s 571.824 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (649.375 ms) : 0, 649375
BytebuddyAgent [candidate] (651.066 ms) : 0, 651066
GlobalTracer [baseline] (282.141 ms) : 0, 282141
GlobalTracer [candidate] (282.924 ms) : 0, 282924
AppSec [baseline] (32.556 ms) : 0, 32556
AppSec [candidate] (32.742 ms) : 0, 32742
Debugger [baseline] (67.091 ms) : 0, 67091
Debugger [candidate] (67.379 ms) : 0, 67379
Remote Config [baseline] (628.435 µs) : 0, 628
Remote Config [candidate] (633.685 µs) : 0, 634
Telemetry [baseline] (9.045 ms) : 0, 9045
Telemetry [candidate] (9.026 ms) : 0, 9026
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.784 ms) : 0, 3784
section iast
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (791.333 ms) : 0, 791333
BytebuddyAgent [candidate] (791.327 ms) : 0, 791327
GlobalTracer [baseline] (255.848 ms) : 0, 255848
GlobalTracer [candidate] (255.523 ms) : 0, 255523
AppSec [baseline] (32.794 ms) : 0, 32794
AppSec [candidate] (33.798 ms) : 0, 33798
Debugger [baseline] (67.122 ms) : 0, 67122
Debugger [candidate] (65.96 ms) : 0, 65960
Remote Config [baseline] (579.515 µs) : 0, 580
Remote Config [candidate] (604.436 µs) : 0, 604
Telemetry [baseline] (8.485 ms) : 0, 8485
Telemetry [candidate] (8.532 ms) : 0, 8532
Flare Poller [baseline] (3.598 ms) : 0, 3598
Flare Poller [candidate] (3.482 ms) : 0, 3482
IAST [baseline] (27.126 ms) : 0, 27126
IAST [candidate] (26.965 ms) : 0, 26965
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/ref1
git_commit_date 1767950001 1767963842
git_commit_sha 8ef6e7a ae2c6cd
release_version 1.59.0-SNAPSHOT~8ef6e7ab7b 1.59.0-SNAPSHOT~ae2c6cd137
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1767966380 1767966380
ci_job_id 1338986022 1338986022
ci_pipeline_id 89892096 89892096
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-e25qm0ww 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-e25qm0ww 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load worse
[+105.984µs; +333.815µs] or [+2.149%; +6.770%]		 worse
[+311.240µs; +770.841µs] or [+2.662%; +6.592%]		 unstable
[-127.683op/s; +57.370op/s] or [-15.325%; +6.886%]		 5.151ms 12.234ms 798.000op/s 4.931ms 11.693ms 833.156op/s
scenario:load:petclinic:appsec:high_load worse
[+0.513ms; +1.503ms] or [+2.781%; +8.154%]		 unsure
[+178.596µs; +1525.091µs] or [+0.595%; +5.081%]		 unstable
[-35.378op/s; +15.003op/s] or [-14.229%; +6.034%]		 19.435ms 30.867ms 238.438op/s 18.428ms 30.015ms 248.625op/s
scenario:load:petclinic:no_agent:high_load better
[-2.188ms; -0.561ms] or [-11.538%; -2.958%]		 unstable
[-3.921ms; -0.340ms] or [-12.412%; -1.076%]		 unstable
[-8.370op/s; +49.433op/s] or [-3.484%; +20.578%]		 17.592ms 29.460ms 260.750op/s 18.966ms 31.590ms 240.219op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.179 ms) : 1167, 1190
.   : milestone, 1179,
iast (3.372 ms) : 3331, 3413
.   : milestone, 3372,
iast_FULL (5.546 ms) : 5492, 5599
.   : milestone, 5546,
iast_GLOBAL (3.64 ms) : 3583, 3697
.   : milestone, 3640,
profiling (1.896 ms) : 1881, 1912
.   : milestone, 1896,
tracing (1.794 ms) : 1778, 1809
.   : milestone, 1794,
section candidate
no_agent (1.187 ms) : 1176, 1199
.   : milestone, 1187,
iast (3.247 ms) : 3203, 3292
.   : milestone, 3247,
iast_FULL (5.791 ms) : 5733, 5849
.   : milestone, 5791,
iast_GLOBAL (3.659 ms) : 3598, 3721
.   : milestone, 3659,
profiling (2.019 ms) : 2001, 2036
.   : milestone, 2019,
tracing (1.731 ms) : 1716, 1745
.   : milestone, 1731,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.179 ms [1.167 ms, 1.19 ms] -
iast 3.372 ms [3.331 ms, 3.413 ms] 2.193 ms (186.1%)
iast_FULL 5.546 ms [5.492 ms, 5.599 ms] 4.367 ms (370.5%)
iast_GLOBAL 3.64 ms [3.583 ms, 3.697 ms] 2.461 ms (208.8%)
profiling 1.896 ms [1.881 ms, 1.912 ms] 717.401 µs (60.9%)
tracing 1.794 ms [1.778 ms, 1.809 ms] 615.054 µs (52.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.187 ms [1.176 ms, 1.199 ms] -
iast 3.247 ms [3.203 ms, 3.292 ms] 2.06 ms (173.5%)
iast_FULL 5.791 ms [5.733 ms, 5.849 ms] 4.604 ms (387.7%)
iast_GLOBAL 3.659 ms [3.598 ms, 3.721 ms] 2.472 ms (208.2%)
profiling 2.019 ms [2.001 ms, 2.036 ms] 831.247 µs (70.0%)
tracing 1.731 ms [1.716 ms, 1.745 ms] 543.19 µs (45.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.431 ms) : 19229, 19633
.   : milestone, 19431,
appsec (18.767 ms) : 18575, 18958
.   : milestone, 18767,
code_origins (17.785 ms) : 17608, 17962
.   : milestone, 17785,
iast (17.687 ms) : 17508, 17865
.   : milestone, 17687,
profiling (19.6 ms) : 19405, 19795
.   : milestone, 19600,
tracing (17.64 ms) : 17464, 17816
.   : milestone, 17640,
section candidate
no_agent (17.892 ms) : 17709, 18075
.   : milestone, 17892,
appsec (19.574 ms) : 19371, 19776
.   : milestone, 19574,
code_origins (17.482 ms) : 17307, 17658
.   : milestone, 17482,
iast (17.534 ms) : 17359, 17709
.   : milestone, 17534,
profiling (19.256 ms) : 19063, 19448
.   : milestone, 19256,
tracing (17.606 ms) : 17433, 17779
.   : milestone, 17606,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.431 ms [19.229 ms, 19.633 ms] -
appsec 18.767 ms [18.575 ms, 18.958 ms] -664.321 µs (-3.4%)
code_origins 17.785 ms [17.608 ms, 17.962 ms] -1.646 ms (-8.5%)
iast 17.687 ms [17.508 ms, 17.865 ms] -1.744 ms (-9.0%)
profiling 19.6 ms [19.405 ms, 19.795 ms] 168.497 µs (0.9%)
tracing 17.64 ms [17.464 ms, 17.816 ms] -1.791 ms (-9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.892 ms [17.709 ms, 18.075 ms] -
appsec 19.574 ms [19.371 ms, 19.776 ms] 1.682 ms (9.4%)
code_origins 17.482 ms [17.307 ms, 17.658 ms] -409.548 µs (-2.3%)
iast 17.534 ms [17.359 ms, 17.709 ms] -357.993 µs (-2.0%)
profiling 19.256 ms [19.063 ms, 19.448 ms] 1.364 ms (7.6%)
tracing 17.606 ms [17.433 ms, 17.779 ms] -286.119 µs (-1.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/ref1
git_commit_date 1767950001 1767963842
git_commit_sha 8ef6e7a ae2c6cd
release_version 1.59.0-SNAPSHOT~8ef6e7ab7b 1.59.0-SNAPSHOT~ae2c6cd137
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1767966146 1767966146
ci_job_id 1338986024 1338986024
ci_pipeline_id 89892096 89892096
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-b6978ue8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-b6978ue8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (3.641 ms) : 3426, 3856
.   : milestone, 3641,
iast (2.201 ms) : 2136, 2265
.   : milestone, 2201,
iast_GLOBAL (2.246 ms) : 2181, 2311
.   : milestone, 2246,
profiling (2.079 ms) : 2025, 2133
.   : milestone, 2079,
tracing (2.039 ms) : 1988, 2090
.   : milestone, 2039,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (3.675 ms) : 3459, 3891
.   : milestone, 3675,
iast (2.2 ms) : 2136, 2265
.   : milestone, 2200,
iast_GLOBAL (2.248 ms) : 2183, 2314
.   : milestone, 2248,
profiling (2.084 ms) : 2029, 2138
.   : milestone, 2084,
tracing (2.04 ms) : 1989, 2091
.   : milestone, 2040,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.459 ms, 1.482 ms] -
appsec 3.641 ms [3.426 ms, 3.856 ms] 2.171 ms (147.7%)
iast 2.201 ms [2.136 ms, 2.265 ms] 730.621 µs (49.7%)
iast_GLOBAL 2.246 ms [2.181 ms, 2.311 ms] 775.884 µs (52.8%)
profiling 2.079 ms [2.025 ms, 2.133 ms] 609.046 µs (41.4%)
tracing 2.039 ms [1.988 ms, 2.09 ms] 568.839 µs (38.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 3.675 ms [3.459 ms, 3.891 ms] 2.202 ms (149.5%)
iast 2.2 ms [2.136 ms, 2.265 ms] 727.264 µs (49.4%)
iast_GLOBAL 2.248 ms [2.183 ms, 2.314 ms] 775.26 µs (52.6%)
profiling 2.084 ms [2.029 ms, 2.138 ms] 610.472 µs (41.4%)
tracing 2.04 ms [1.989 ms, 2.091 ms] 566.469 µs (38.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~ae2c6cd137, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.75 s) : 14750000, 14750000
.   : milestone, 14750000,
appsec (14.674 s) : 14674000, 14674000
.   : milestone, 14674000,
iast (17.947 s) : 17947000, 17947000
.   : milestone, 17947000,
iast_GLOBAL (17.894 s) : 17894000, 17894000
.   : milestone, 17894000,
profiling (15.365 s) : 15365000, 15365000
.   : milestone, 15365000,
tracing (14.579 s) : 14579000, 14579000
.   : milestone, 14579000,
section candidate
no_agent (14.961 s) : 14961000, 14961000
.   : milestone, 14961000,
appsec (14.741 s) : 14741000, 14741000
.   : milestone, 14741000,
iast (18.106 s) : 18106000, 18106000
.   : milestone, 18106000,
iast_GLOBAL (17.693 s) : 17693000, 17693000
.   : milestone, 17693000,
profiling (14.704 s) : 14704000, 14704000
.   : milestone, 14704000,
tracing (14.672 s) : 14672000, 14672000
.   : milestone, 14672000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.75 s [14.75 s, 14.75 s] -
appsec 14.674 s [14.674 s, 14.674 s] -76.0 ms (-0.5%)
iast 17.947 s [17.947 s, 17.947 s] 3.197 s (21.7%)
iast_GLOBAL 17.894 s [17.894 s, 17.894 s] 3.144 s (21.3%)
profiling 15.365 s [15.365 s, 15.365 s] 615.0 ms (4.2%)
tracing 14.579 s [14.579 s, 14.579 s] -171.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.961 s [14.961 s, 14.961 s] -
appsec 14.741 s [14.741 s, 14.741 s] -220.0 ms (-1.5%)
iast 18.106 s [18.106 s, 18.106 s] 3.145 s (21.0%)
iast_GLOBAL 17.693 s [17.693 s, 17.693 s] 2.732 s (18.3%)
profiling 14.704 s [14.704 s, 14.704 s] -257.0 ms (-1.7%)
tracing 14.672 s [14.672 s, 14.672 s] -289.0 ms (-1.9%)

PerfectSlayer
PerfectSlayer approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. It looks to remove some duplication for helper declaration but remove some fine grained control over instrumentation enablement.
It still feels to go in the right direction 👍

@amarziali
Copy link
Contributor Author

amarziali commented Jan 12, 2026

but remove some fine grained control over instrumentation enablement.

It can still be done in the typeInstrumentation method with if. In this PR I intentionally removed the httpclient-redirect (something similar) qualifier for a single instrumentation since overkill

@amarziali amarziali merged commit 8260d96 into master Jan 12, 2026
571 checks passed
@amarziali amarziali deleted the andrea.marziali/ref1 branch January 12, 2026 07:48
@github-actions github-actions bot added this to the 1.59.0 milestone Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@mcculls mcculls Awaiting requested review from mcculls

Assignees

No one assigned

Labels

inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.59.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @PerfectSlayer