-
Notifications
You must be signed in to change notification settings - Fork 324
Allow running wallclock profiler even without tracer #10298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083322
Total [baseline] (10.82 s) : 0, 10820397
Agent [candidate] (1.086 s) : 0, 1085960
Total [candidate] (10.791 s) : 0, 10791276
section appsec
Agent [baseline] (1.268 s) : 0, 1267936
Total [baseline] (11.113 s) : 0, 11112659
Agent [candidate] (1.274 s) : 0, 1273669
Total [candidate] (10.998 s) : 0, 10997839
section iast
Agent [baseline] (1.225 s) : 0, 1225416
Total [baseline] (11.227 s) : 0, 11226819
Agent [candidate] (1.235 s) : 0, 1234877
Total [candidate] (11.129 s) : 0, 11129130
section profiling
Agent [baseline] (1.212 s) : 0, 1211733
Total [baseline] (10.918 s) : 0, 10918321
Agent [candidate] (1.211 s) : 0, 1211306
Total [candidate] (10.965 s) : 0, 10964883
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (650.599 ms) : 0, 650599
BytebuddyAgent [candidate] (651.888 ms) : 0, 651888
GlobalTracer [baseline] (282.284 ms) : 0, 282284
GlobalTracer [candidate] (283.126 ms) : 0, 283126
AppSec [baseline] (32.374 ms) : 0, 32374
AppSec [candidate] (32.726 ms) : 0, 32726
Debugger [baseline] (68.014 ms) : 0, 68014
Debugger [candidate] (67.926 ms) : 0, 67926
Remote Config [baseline] (631.604 µs) : 0, 632
Remote Config [candidate] (626.257 µs) : 0, 626
Telemetry [baseline] (8.969 ms) : 0, 8969
Telemetry [candidate] (9.032 ms) : 0, 9032
Flare Poller [baseline] (3.806 ms) : 0, 3806
Flare Poller [candidate] (3.849 ms) : 0, 3849
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (692.392 ms) : 0, 692392
BytebuddyAgent [candidate] (696.145 ms) : 0, 696145
GlobalTracer [baseline] (258.885 ms) : 0, 258885
GlobalTracer [candidate] (260.062 ms) : 0, 260062
IAST [baseline] (24.51 ms) : 0, 24510
IAST [candidate] (24.794 ms) : 0, 24794
AppSec [baseline] (173.507 ms) : 0, 173507
AppSec [candidate] (173.838 ms) : 0, 173838
Debugger [baseline] (67.894 ms) : 0, 67894
Debugger [candidate] (68.107 ms) : 0, 68107
Remote Config [baseline] (769.307 µs) : 0, 769
Remote Config [candidate] (757.601 µs) : 0, 758
Telemetry [baseline] (9.496 ms) : 0, 9496
Telemetry [candidate] (9.312 ms) : 0, 9312
Flare Poller [baseline] (3.784 ms) : 0, 3784
Flare Poller [candidate] (3.856 ms) : 0, 3856
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (792.029 ms) : 0, 792029
BytebuddyAgent [candidate] (799.107 ms) : 0, 799107
GlobalTracer [baseline] (256.906 ms) : 0, 256906
GlobalTracer [candidate] (258.723 ms) : 0, 258723
IAST [baseline] (27.069 ms) : 0, 27069
IAST [candidate] (27.222 ms) : 0, 27222
AppSec [baseline] (35.289 ms) : 0, 35289
AppSec [candidate] (35.422 ms) : 0, 35422
Debugger [baseline] (64.84 ms) : 0, 64840
Debugger [candidate] (64.836 ms) : 0, 64836
Remote Config [baseline] (572.24 µs) : 0, 572
Remote Config [candidate] (607.528 µs) : 0, 608
Telemetry [baseline] (8.433 ms) : 0, 8433
Telemetry [candidate] (8.55 ms) : 0, 8550
Flare Poller [baseline] (3.556 ms) : 0, 3556
Flare Poller [candidate] (3.559 ms) : 0, 3559
section profiling
crashtracking [baseline] (1.221 ms) : 0, 1221
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (706.086 ms) : 0, 706086
BytebuddyAgent [candidate] (706.446 ms) : 0, 706446
GlobalTracer [baseline] (222.276 ms) : 0, 222276
GlobalTracer [candidate] (221.917 ms) : 0, 221917
AppSec [baseline] (32.284 ms) : 0, 32284
AppSec [candidate] (32.31 ms) : 0, 32310
Debugger [baseline] (68.212 ms) : 0, 68212
Debugger [candidate] (68.19 ms) : 0, 68190
Remote Config [baseline] (639.481 µs) : 0, 639
Remote Config [candidate] (650.821 µs) : 0, 651
Telemetry [baseline] (9.058 ms) : 0, 9058
Telemetry [candidate] (8.985 ms) : 0, 8985
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.745 ms) : 0, 3745
ProfilingAgent [baseline] (97.953 ms) : 0, 97953
ProfilingAgent [candidate] (97.492 ms) : 0, 97492
Profiling [baseline] (98.542 ms) : 0, 98542
Profiling [candidate] (98.071 ms) : 0, 98071
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083002
Total [baseline] (8.751 s) : 0, 8751458
Agent [candidate] (1.084 s) : 0, 1083796
Total [candidate] (8.747 s) : 0, 8746980
section iast
Agent [baseline] (1.229 s) : 0, 1228949
Total [baseline] (9.305 s) : 0, 9304839
Agent [candidate] (1.221 s) : 0, 1221368
Total [candidate] (9.315 s) : 0, 9314839
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (651.301 ms) : 0, 651301
BytebuddyAgent [candidate] (652.247 ms) : 0, 652247
GlobalTracer [baseline] (282.449 ms) : 0, 282449
GlobalTracer [candidate] (282.684 ms) : 0, 282684
AppSec [baseline] (32.457 ms) : 0, 32457
AppSec [candidate] (32.548 ms) : 0, 32548
Debugger [baseline] (66.823 ms) : 0, 66823
Debugger [candidate] (66.208 ms) : 0, 66208
Remote Config [baseline] (625.224 µs) : 0, 625
Remote Config [candidate] (639.355 µs) : 0, 639
Telemetry [baseline] (8.844 ms) : 0, 8844
Telemetry [candidate] (8.944 ms) : 0, 8944
Flare Poller [baseline] (3.784 ms) : 0, 3784
Flare Poller [candidate] (3.755 ms) : 0, 3755
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (793.986 ms) : 0, 793986
BytebuddyAgent [candidate] (790.048 ms) : 0, 790048
GlobalTracer [baseline] (257.269 ms) : 0, 257269
GlobalTracer [candidate] (256.563 ms) : 0, 256563
IAST [baseline] (27.087 ms) : 0, 27087
IAST [candidate] (26.837 ms) : 0, 26837
AppSec [baseline] (34.756 ms) : 0, 34756
AppSec [candidate] (34.135 ms) : 0, 34135
Debugger [baseline] (66.07 ms) : 0, 66070
Debugger [candidate] (64.5 ms) : 0, 64500
Remote Config [baseline] (592.766 µs) : 0, 593
Remote Config [candidate] (580.72 µs) : 0, 581
Telemetry [baseline] (8.666 ms) : 0, 8666
Telemetry [candidate] (8.481 ms) : 0, 8481
Flare Poller [baseline] (3.649 ms) : 0, 3649
Flare Poller [candidate] (3.581 ms) : 0, 3581
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section baseline
no_agent (17.833 ms) : 17650, 18016
. : milestone, 17833,
appsec (18.783 ms) : 18591, 18975
. : milestone, 18783,
code_origins (17.884 ms) : 17704, 18064
. : milestone, 17884,
iast (17.68 ms) : 17500, 17859
. : milestone, 17680,
profiling (18.422 ms) : 18239, 18605
. : milestone, 18422,
tracing (18.658 ms) : 18473, 18844
. : milestone, 18658,
section candidate
no_agent (17.101 ms) : 16934, 17269
. : milestone, 17101,
appsec (19.364 ms) : 19171, 19558
. : milestone, 19364,
code_origins (17.538 ms) : 17364, 17713
. : milestone, 17538,
iast (18.27 ms) : 18087, 18453
. : milestone, 18270,
profiling (18.969 ms) : 18780, 19159
. : milestone, 18969,
tracing (17.69 ms) : 17513, 17867
. : milestone, 17690,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section baseline
no_agent (1.268 ms) : 1255, 1281
. : milestone, 1268,
iast (3.238 ms) : 3195, 3280
. : milestone, 3238,
iast_FULL (5.829 ms) : 5771, 5888
. : milestone, 5829,
iast_GLOBAL (3.644 ms) : 3590, 3697
. : milestone, 3644,
profiling (1.975 ms) : 1958, 1991
. : milestone, 1975,
tracing (1.759 ms) : 1745, 1773
. : milestone, 1759,
section candidate
no_agent (1.19 ms) : 1178, 1201
. : milestone, 1190,
iast (3.284 ms) : 3237, 3332
. : milestone, 3284,
iast_FULL (5.971 ms) : 5910, 6031
. : milestone, 5971,
iast_GLOBAL (3.566 ms) : 3515, 3617
. : milestone, 3566,
profiling (2.001 ms) : 1982, 2020
. : milestone, 2001,
tracing (1.797 ms) : 1782, 1812
. : milestone, 1797,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section baseline
no_agent (14.79 s) : 14790000, 14790000
. : milestone, 14790000,
appsec (14.607 s) : 14607000, 14607000
. : milestone, 14607000,
iast (18.569 s) : 18569000, 18569000
. : milestone, 18569000,
iast_GLOBAL (17.774 s) : 17774000, 17774000
. : milestone, 17774000,
profiling (15.275 s) : 15275000, 15275000
. : milestone, 15275000,
tracing (14.621 s) : 14621000, 14621000
. : milestone, 14621000,
section candidate
no_agent (15.592 s) : 15592000, 15592000
. : milestone, 15592000,
appsec (14.524 s) : 14524000, 14524000
. : milestone, 14524000,
iast (18.05 s) : 18050000, 18050000
. : milestone, 18050000,
iast_GLOBAL (17.888 s) : 17888000, 17888000
. : milestone, 17888000,
profiling (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
tracing (14.642 s) : 14642000, 14642000
. : milestone, 14642000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~0ef488b5cf, baseline=1.59.0-SNAPSHOT~51c5591fa6
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.459 ms) : 2407, 2512
. : milestone, 2459,
iast (2.215 ms) : 2150, 2281
. : milestone, 2215,
iast_GLOBAL (2.271 ms) : 2205, 2337
. : milestone, 2271,
profiling (2.098 ms) : 2043, 2153
. : milestone, 2098,
tracing (2.043 ms) : 1991, 2095
. : milestone, 2043,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.453 ms) : 2401, 2506
. : milestone, 2453,
iast (2.215 ms) : 2149, 2280
. : milestone, 2215,
iast_GLOBAL (2.255 ms) : 2190, 2321
. : milestone, 2255,
profiling (2.065 ms) : 2012, 2118
. : milestone, 2065,
tracing (2.05 ms) : 1998, 2102
. : milestone, 2050,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
6997fe7 to
a5f0d36
Compare
What Does This Do
Fix the wallclock context filter logic to allow collecting wallclock profiles even with the tracer being disabled and not providing the tracing context.
Motivation
There are users that want to run profiler without tracer (sic). For those, the wallclock profiling is not possible, ATM. This is fixing that gap.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: PROF-13347