Allow type widening when checking schemas compatibility#87
Open
Allow type widening when checking schemas compatibility#87
Conversation
N-Boutaib
force-pushed
the
najib.boutaib/allow-type-widening-during-schema-compatibility-check
branch
from
8010e0b to
dc39aa7
Compare
|
Should this be contributed upstream instead? |
Author
Not sure, since I found it very specific to us. I can propose it upstream and see what happens 😅 |
N-Boutaib
force-pushed
the
najib.boutaib/allow-type-widening-during-schema-compatibility-check
branch
from
dc39aa7 to
43e2968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR allow type widening when checking datafusion and substrait schemas compatibility. A narrow datafusion type (e.g. int32) and a wide substrait type (e.g. int64) are declared compatible.