Skip to content

typing: add typing for api#920

Merged
KowalskiThomas merged 1 commit intomasterfrom
kowalski/typing-add-typing-for-api
Apr 21, 2026
Merged

typing: add typing for api#920
KowalskiThomas merged 1 commit intomasterfrom
kowalski/typing-add-typing-for-api

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented Mar 11, 2026

What does this PR do?

This PR adds typing for api and fixes inconsistent typing where adding type annotations broke existing typing.

@KowalskiThomas KowalskiThomas force-pushed the kowalski/typing-add-typing-for-api branch from b237de1 to a8d39d8 Compare March 12, 2026 10:58
@KowalskiThomas KowalskiThomas force-pushed the kowalski/typing-add-typing-to-dogshell branch 2 times, most recently from f59aa38 to 907000d Compare March 16, 2026 09:04
Base automatically changed from kowalski/typing-add-typing-to-dogshell to master March 16, 2026 15:39
@KowalskiThomas KowalskiThomas force-pushed the kowalski/typing-add-typing-for-api branch 2 times, most recently from 70d3c6c to a578787 Compare March 18, 2026 16:12
@KowalskiThomas KowalskiThomas force-pushed the kowalski/typing-add-typing-for-api branch 4 times, most recently from 6d49154 to fae7aa5 Compare April 17, 2026 15:47
@KowalskiThomas KowalskiThomas added the changelog/no-changelog Changes don't appear in changelog label Apr 17, 2026
@KowalskiThomas KowalskiThomas force-pushed the kowalski/typing-add-typing-for-api branch from fae7aa5 to 798bf9b Compare April 20, 2026 12:07
@KowalskiThomas KowalskiThomas requested a review from MintsInc April 20, 2026 12:08
@KowalskiThomas KowalskiThomas changed the title typing: add typing for api typing: add typing for api Apr 20, 2026
@KowalskiThomas KowalskiThomas marked this pull request as ready for review April 21, 2026 08:41
@KowalskiThomas KowalskiThomas requested a review from a team as a code owner April 21, 2026 08:41
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 798bf9b54c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread datadog/api/metadata.py Outdated
Comment thread datadog/api/security_monitoring_rules.py Outdated
Comment thread datadog/api/security_monitoring_signals.py Outdated
@KowalskiThomas KowalskiThomas force-pushed the kowalski/typing-add-typing-for-api branch from 798bf9b to a87be41 Compare April 21, 2026 11:48
@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@KowalskiThomas KowalskiThomas merged commit 687143f into master Apr 21, 2026
20 checks passed
@KowalskiThomas KowalskiThomas deleted the kowalski/typing-add-typing-for-api branch April 21, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog Changes don't appear in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants