Skip to content

Conversation

@tbavelier
Copy link
Member

What does this PR do?

  • Preserves createStrategy field over updates + updates lastTransition there only when there's a change
  • Update tests

Motivation

  • Matching DDA behaviour

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier changed the title Tbavelier/suggestion DDAI Create strategy review suggestion Dec 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.10%. Comparing base (09cb5c0) to head (39c2b5b).

Files with missing lines Patch % Lines
pkg/agentprofile/agent_profile.go 85.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           khewonc/create-strategy-ddai    #2407      +/-   ##
================================================================
+ Coverage                         37.07%   37.10%   +0.03%     
================================================================
  Files                               288      288              
  Lines                             24553    24566      +13     
================================================================
+ Hits                               9102     9115      +13     
  Misses                            14739    14739              
  Partials                            712      712              
Flag Coverage Δ
unittests 37.10% <85.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/agentprofile/status.go 67.53% <100.00%> (ø)
pkg/agentprofile/agent_profile.go 73.80% <85.00%> (+0.88%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09cb5c0...39c2b5b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from khewonc/create-strategy-ddai to main December 17, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants