Skip to content

Fix deterministic service port derivation#272

Merged
ofek merged 1 commit intomainfrom
ofek/fix-service-port-derivation
May 4, 2026
Merged

Fix deterministic service port derivation#272
ofek merged 1 commit intomainfrom
ofek/fix-service-port-derivation

Conversation

@ofek
Copy link
Copy Markdown
Contributor

@ofek ofek commented May 2, 2026

I encountered a conflict on my Windows machine with an ephemeral port once or twice. The dynamic/private port range should never have been used.

There's a theoretical backward incompatibility issue where one updates dda while a developer environment is active and further SSH communication fails. It's quite easy to recreate an environment so I opted to not implement a specific hack to account for this.

@ofek ofek requested a review from a team as a code owner May 2, 2026 01:25
@datadog-prod-us1-4
Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 71.07% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0394473 | Docs | Datadog PR Page | Give us feedback!

@ofek ofek merged commit 66f5cbe into main May 4, 2026
26 checks passed
@ofek ofek deleted the ofek/fix-service-port-derivation branch May 4, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants