Skip to content

feat: implement remote configuration caching mechanism#4606

Draft
gogusarov wants to merge 1 commit into
mainfrom
grigory.gusarov/RUM-15992
Draft

feat: implement remote configuration caching mechanism#4606
gogusarov wants to merge 1 commit into
mainfrom
grigory.gusarov/RUM-15992

Conversation

@gogusarov
Copy link
Copy Markdown
Contributor

Motivation

Support remote configuration caching mechanism according to the RFC

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 11, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 5 Tests failed

remote configuration › should be fetched and applied › async from rum/remoteConfiguration.scenario.ts   View in Datadog   (Fix with Cursor)
remoteConfiguration.scenario.ts:8:13 async

[chromium] › rum/remoteConfiguration.scenario.ts:8:13 › remote configuration › should be fetched and applied › async 

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 1
    Received: 100

      17 |       await waitForRemoteConfigurationToBeApplied(page)
...
remote configuration › should be fetched and applied › bundle from rum/remoteConfiguration.scenario.ts   View in Datadog   (Fix with Cursor)
remoteConfiguration.scenario.ts:8:13 bundle

[chromium] › rum/remoteConfiguration.scenario.ts:8:13 › remote configuration › should be fetched and applied › bundle 

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 1
    Received: 100

      17 |       await waitForRemoteConfigurationToBeApplied(page)
...
remote configuration › should be fetched and applied › npm from rum/remoteConfiguration.scenario.ts   View in Datadog   (Fix with Cursor)
remoteConfiguration.scenario.ts:8:13 npm

[chromium] › rum/remoteConfiguration.scenario.ts:8:13 › remote configuration › should be fetched and applied › npm 

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: 1
    Received: 100

      17 |       await waitForRemoteConfigurationToBeApplied(page)
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 13884a7 | Docs | Datadog PR Page | Give us feedback!


const cacheResult = configurationCache.read()

metrics.increment('cache', CACHE_STATUS_TO_METRIC_MAP[cacheResult.status])
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mormubis would it be ok to leave metrics keys the way they currently are (success / missing / failure) or should they be exactly the same as in you RFC (hit/miss/error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant