✨ Add sveltekit router integration#4499
Draft
amortemousque wants to merge 12 commits into
Draft
Conversation
Design for a fully automated Claude Code skill pipeline that generates draft Browser SDK router integration PRs from framework public docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Updated spec: skills use separate subdirectories (SKILL.md per dir) - Plan covers 7 tasks: orchestrator + 5 stage skills + validation - Each task has step-by-step instructions with exact file paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Six Claude Code skills forming an automated pipeline: - router:pipeline — orchestrator chaining all stages - router:fetch-docs — Stage 1: fetch & extract router concepts - router:analyze — Stage 2: map to SDK patterns - router:design — Stage 3: produce design decisions - router:generate — Stage 4: generate package code - router:pr — Stage 5: create draft PR Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Generated by the router integration pipeline. Artifacts: router concepts, design decisions, generation manifest.
Auto-generated from framework documentation using the router integration pipeline. See docs/integrations/sveltekit/ for design artifacts and decision rationale.
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: efba2dc | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-generated router integration for sveltekit using the router integration pipeline.
startView()on route changesDesign Artifacts
Full design trail at
docs/integrations/sveltekit/:01-router-concepts.json— structured routing concepts extracted from framework docs02-design-decisions.json— hook selection, wrapping strategy, algorithm family decisions03-generation-manifest.md— list of generated files with lineageKey Decisions
afterNavigate— only post-cancellation/post-redirect SvelteKit hook that fires uniformly on initial mount (type: 'enter') and subsequent client navigations;onNavigateexcludes the initial load so would drop the first RUM view, and page-state reactive hooks require$effectdiffing with no timing benefit.<DatadogRumRouter />) —afterNavigatehas no imperative API and must run during Svelte component init; SvelteKit's file-based routing offers nocreateRouterfactory to wrap, so a renderless component placed in root+layout.svelteis the idiomatic attach point (matches how View Transitions and analytics libs wire in).route-idfamily —navigation.to.route.idalready is the collapsed parameterized pattern (e.g./blog/[slug],/(app)/dashboard);computeViewNameis a one-liner that falls back tourl.pathnamewhenroute.idis null (unmatched/404) and preserves bracket syntax / route groups / matchers verbatim.rum-vue— closest match on plugin shape (top-level factory +router: boolean+ onRumInit queue), subscription pattern (single event-based post-redirect hook,router.afterEach↔afterNavigate), and view-name algorithm (pure-functioncomputeViewNamesplit from subscription site); the wrapping surface differs but the RUM-facing side transfers directly.Test plan
docs/integrations/sveltekit/yarn typecheckto verify type correctnessyarn test:unit --spec packages/rum-sveltekit/to verify tests passcomputeViewName()edge cases🤖 Generated with the router integration pipeline