♻️ inline lazyLoadRecorder into postStartStrategy using mockable()#4326
Draft
BenoitZugmeyer wants to merge 1 commit intomainfrom
Draft
♻️ inline lazyLoadRecorder into postStartStrategy using mockable()#4326BenoitZugmeyer wants to merge 1 commit intomainfrom
lazyLoadRecorder into postStartStrategy using mockable()#4326BenoitZugmeyer wants to merge 1 commit intomainfrom
Conversation
Removes the `loadRecorder` parameter from `makeRecorderApi` and `createPostStartStrategy`, simplifying call sites. Testability is preserved via `replaceMockableWithSpy`.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: f0afe08 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simplification
Changes
Removes the
loadRecorderparameter frommakeRecorderApiandcreatePostStartStrategy, simplifying call sites. Testability is preserved viareplaceMockableWithSpy.Test instructions
Minor change, if CI is green it should be fine.
You could manually test that Session Replay still works.
Checklist