Skip to content

Conversation

@mormubis
Copy link
Contributor

@mormubis mormubis commented Jan 22, 2026

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@github-actions
Copy link

github-actions bot commented Jan 22, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@datadog-official
Copy link

datadog-official bot commented Jan 22, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 322 Tests failed

cookieObservable should notify observers on cookie change from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog) (Fix with Cursor)
Error: Jasmine Clock was unable to install over custom global timer functions. Is the clock already installed?
    at <Jasmine>
    at mockClock (/go/src/github.com/DataDog/browser-sdk/packages/core/test/emulate/mockClock.ts:12:9 <- /tmp/_karma_webpack_292493/commons.js:145588:19)
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/rum-core/src/browser/cookieObservable.spec.ts:18:22 <- /tmp/_karma_webpack_292493/commons.js:186968:86)
    at <Jasmine>
cookieObservable should notify observers on cookie change when cookieStore is not supported from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog) (Fix with Cursor)
Error: Jasmine Clock was unable to install over custom global timer functions. Is the clock already installed?
    at <Jasmine>
    at mockClock (/go/src/github.com/DataDog/browser-sdk/packages/core/test/emulate/mockClock.ts:12:9 <- /tmp/_karma_webpack_292493/commons.js:145588:19)
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/rum-core/src/browser/cookieObservable.spec.ts:18:22 <- /tmp/_karma_webpack_292493/commons.js:186968:86)
    at <Jasmine>
cookieObservable should not notify observers on cookie change when the cookie value as not changed when cookieStore is not supported from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog) (Fix with Cursor)
Error: Jasmine Clock was unable to install over custom global timer functions. Is the clock already installed?
    at <Jasmine>
    at mockClock (/go/src/github.com/DataDog/browser-sdk/packages/core/test/emulate/mockClock.ts:12:9 <- /tmp/_karma_webpack_292493/commons.js:145588:19)
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/rum-core/src/browser/cookieObservable.spec.ts:18:22 <- /tmp/_karma_webpack_292493/commons.js:186968:86)
    at <Jasmine>
View all

ℹ️ Info

❄️ No new flaky tests detected

🎯 Code Coverage
Patch Coverage: 44.23%
Overall Coverage: 73.84% (-3.50%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6244e33 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@mormubis mormubis force-pushed the adlrb/telemetry-prestart branch from d862aa9 to b5775c0 Compare January 22, 2026 13:28
@cit-pr-commenter-54b7da
Copy link

cit-pr-commenter-54b7da bot commented Jan 22, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 165.78 KiB 167.90 KiB +2.11 KiB +1.27%
Rum Profiler 4.33 KiB 4.33 KiB 0 B 0.00%
Rum Recorder 24.48 KiB 24.48 KiB 0 B 0.00%
Logs 56.21 KiB 56.35 KiB +143 B +0.25%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 123.05 KiB 124.98 KiB +1.93 KiB +1.57%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
addglobalcontext N/A 0.0038 N/A
addaction N/A 0.0183 N/A
adderror N/A 0.0194 N/A
addtiming N/A 0.0029 N/A
startview N/A 0.0039 N/A
startstopsessionreplayrecording N/A 0.0007 N/A
logmessage N/A 0.0153 N/A
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
addglobalcontext N/A 33.32 KiB N/A
addaction N/A 55.93 KiB N/A
addtiming N/A 27.09 KiB N/A
adderror N/A 58.95 KiB N/A
startstopsessionreplayrecording N/A 30.48 KiB N/A
startview N/A 431.77 KiB N/A
logmessage N/A 45.54 KiB N/A

🔗 RealWorld

@mormubis mormubis force-pushed the adlrb/telemetry-prestart branch 6 times, most recently from afbe503 to 6dd7a4d Compare January 22, 2026 14:28
Implements phase 2 - RUM telemetry capture in early initialization:
- Add hooks early creation to preStartRum
- Activate telemetry collection in preStart
- Wire hooks parameter and fix re-exports
Integrates phase 3 - RUM transport with observable architecture:
- Fix observable architecture (BufferedObservable pattern)
- Add integration tests for preStart telemetry transport
- Update startTelemetryTransport to unbuffer parameter observable
Completes phase 4 - comprehensive testing and validation:
- Unit tests for RUM and Logs preStart telemetry capture
- E2E tests ensuring errors appear in first batch
- Performance tests measuring preStart overhead
@mormubis mormubis force-pushed the adlrb/telemetry-prestart branch from 6dd7a4d to 6244e33 Compare January 22, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants