-
Notifications
You must be signed in to change notification settings - Fork 168
⚗ [RUM-11393] Add Start/StopResource API #4110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 668bda0 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
|
@codex pls review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 998c7a9b5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea would be to reuse it for different events, else it adds bloat.
Without it only for actions and resources:
Without this: Rum | 169.41 KiB
With it: Rum | 169.52 KiB
After AI refactoring quickly VitalCollection to use it I got:
rum | 169.45 KiB
Motivation
Discussed in this RFC
Following the same pattern as for start/stopAction, this PR introduces a manual resource tracking API.
Changes
New Experimental Feature
START_STOP_RESOURCEfeature flagNew Public APIs
Architecture Refactoring
createManualEventLifecycle: Shared utility for managing start/stop lifecycle (used by both actions and resources)trackManualActions.tsto use the shared utilitytrackManualResources.tsfor manual resource lifecycleTest instructions
I used this HTML file to test locally.
Example Resource
Example in Flutter web.
Checklist