[DT-2755] Adds showing file name + errata #3239

otchet-broad · 2025-12-19T21:11:12Z

Addresses

https://broadworkbench.atlassian.net/browse/DT-2755

Displays the filename for the file previously uploaded
Ensures the front end does not send the FileStorageObject to the backend because the backend will try to interpret it as a file (bug in current form in production as well)
Update nihCertificationFile to match backend name: nihInstitutionalCertificationFile
Makes NIH Institutional File a downloadable link when it is saved in consent.

Summary

Alternative Sharing Plan (text since we don't have a download API for this)

Link for NIH Institutional Certification Document

Have you read Terra's Contributing Guide lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

…tes; fix model name to match backend API name

otchet-broad · 2025-12-19T21:56:53Z

src/components/consent_group_list/ConsentGroupAddEdit.tsx

            description="If an Institutional Certification for this consent group exists, please upload it here"
-            id="nihInstitutionalCertificationFile"
-            defaultValue={current.nihInstitutionalCertificationFile}
+            id="addedNIHInstitutionalCertificationFile"


Renamed because there's a bit of a confusing state within consent. The object being sent to the backend should be a File and not a FileStorageObject.
In consent a Dataset calls the field nihInstitutionalCertificationFile and it contains FileStorageObject
When sending the consentGroup payload, this field should not be mutated. We should only ever set a file as the specific structure specified in the multipart form payload in DataSubmissionFormV2.buildMultiPartFormData

@ncalvanese1 - We should catch up on your script. :-)

…lse; handle data cases from Nate's scripts that the backend allows.

otchet-broad · 2025-12-19T23:27:14Z

src/pages/data_submission/v2/v2-common-functions.tsx

+
    consentGroup.mor = !isEmpty(dataset.dataUse.publicationMoratorium)
-    consentGroup.morDate = dataset.dataUse.publicationMoratorium
+    if (isEmpty(dataset.dataUse.publicationMoratorium)) {


We can get an empty string from the backend.

otchet-broad · 2025-12-19T23:27:37Z

src/pages/data_submission/v2/v2-common-functions.tsx

    consentGroup.col = dataset.dataUse.collaboratorRequired
    consentGroup.irb = dataset.dataUse.ethicsApprovalRequired
-    consentGroup.gs = dataset.dataUse.geographicalRestrictions
+    if (isEmpty(dataset.dataUse.geographicalRestrictions)) {


We are getting empty strings in cases for this value.

otchet-broad · 2025-12-19T23:28:21Z

src/pages/data_submission/v2/v2-common-functions.tsx

    consentGroup.diseaseSpecificUse = dataset.dataUse.diseaseRestrictions
    consentGroup.poa = dataset.dataUse.populationOriginsAncestry
-    consentGroup.otherPrimary = dataset.dataUse.other
+    if (isEmpty(dataset.dataUse.other)) {


We are getting empty strings in cases for this value.

We likely have a bug on the back end that sends empty strings.

otchet-broad · 2025-12-19T23:29:05Z

src/pages/data_submission/v2/v2-common-functions.tsx

+    }
    consentGroup.npu = dataset.dataUse.nonProfitUse
-    consentGroup.otherSecondary = dataset.dataUse.secondaryOther
+    if (consentGroup.otherSecondary && consentGroup.otherSecondary.length > 0) {


We can get an empty string from the backend.

otchet-broad · 2025-12-19T23:30:34Z

src/pages/data_submission/v2/v2-common-functions.tsx

+    }
    consentGroup.npu = dataset.dataUse.nonProfitUse
-    consentGroup.otherSecondary = dataset.dataUse.secondaryOther
+    if (isEmpty(consentGroup.otherSecondary)) {


We can get an empty string from the backend.

sonarqubecloud · 2025-12-22T14:20:46Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

rushtong

Looks good 👍🏽

rushtong · 2026-01-05T13:48:09Z

src/pages/data_submission/v2/v2-common-functions.tsx

    consentGroup.diseaseSpecificUse = dataset.dataUse.diseaseRestrictions
    consentGroup.poa = dataset.dataUse.populationOriginsAncestry
-    consentGroup.otherPrimary = dataset.dataUse.other
+    if (isEmpty(dataset.dataUse.other)) {


We likely have a bug on the back end that sends empty strings.

Adds showing file name; ensures proper updates are sent for file upda…

96d84e6

…tes; fix model name to match backend API name

otchet-broad changed the title ~~Adds showing file name; ensures proper updates are sent for file upda…~~ [DT-2755] Adds showing file name + errata Dec 19, 2025

Remove lint.

545dae6

otchet-broad commented Dec 19, 2025

View reviewed changes

otchet-broad marked this pull request as ready for review December 19, 2025 21:57

otchet-broad requested a review from a team as a code owner December 19, 2025 21:57

otchet-broad requested review from eweitz, fboulnois, kevinmarete and rushtong and removed request for a team December 19, 2025 21:57

fix: allow setting url if changing from Not Determined to something e…

e33efb8

…lse; handle data cases from Nate's scripts that the backend allows.

otchet-broad commented Dec 19, 2025

View reviewed changes

Refactor conditional to be consistent.

1d7191d

otchet-broad commented Dec 19, 2025

View reviewed changes

otchet-broad added 2 commits December 22, 2025 09:04

Add download link for NIH Institutional Certification File.

f557d8e

fix: lint.

cc53f99

kevinmarete approved these changes Jan 4, 2026

View reviewed changes

rushtong approved these changes Jan 5, 2026

View reviewed changes

otchet-broad merged commit 0093bdb into develop Jan 5, 2026
11 checks passed

otchet-broad deleted the otchet-dt-2755-display-filenames-in-s4r-form branch January 5, 2026 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DT-2755] Adds showing file name + errata #3239

[DT-2755] Adds showing file name + errata #3239

Uh oh!

otchet-broad commented Dec 19, 2025 •

edited

Loading

Uh oh!

otchet-broad Dec 19, 2025

Uh oh!

otchet-broad Dec 19, 2025

Uh oh!

otchet-broad Dec 19, 2025

Uh oh!

otchet-broad Dec 19, 2025

Uh oh!

otchet-broad Dec 19, 2025

Uh oh!

rushtong Jan 5, 2026

Uh oh!

otchet-broad Dec 19, 2025

Uh oh!

otchet-broad Dec 19, 2025

Uh oh!

sonarqubecloud bot commented Dec 22, 2025

Uh oh!

rushtong left a comment

Uh oh!

rushtong Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[DT-2755] Adds showing file name + errata #3239

[DT-2755] Adds showing file name + errata #3239

Uh oh!

Conversation

otchet-broad commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Addresses

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Dec 22, 2025

Quality Gate passed

Uh oh!

rushtong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

otchet-broad commented Dec 19, 2025 •

edited

Loading