-
Notifications
You must be signed in to change notification settings - Fork 47
0.5.2 dev #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…, and location environment variables
jupyter if unset. test_setup.sh updated to use env variables rather than hardcoded network settings
…network and SA values
test/integration/io_setup.sh
Outdated
|
|
||
| echo " Checking user-id" | ||
| util::dstat_yaml_assert_field_equal "${dstat_output}" "[0].user-id" "${USER}" | ||
| util::dstat_yaml_assert_field_equal "${dstat_output}" "[0].user-id" "${USER:-jupyter}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be preferable for io_setup.sh to set a variable, like JOB_USER in the other test scripts, and then reference it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated that here as well as in io_tasks_setup.sh
…w integration test files and use that directly
|
I also verified that the tests pass in the AoU app; the only failing tests were the same 5 that failed outside of the perimeter plus |
This just adds a couple of fixes to get some more tests to pass - right now, 5 tests are still failing using the
google-batchprovider, but these also fail onmainThe following summary was generated with the help of Claude Code:
Overview
Branch: 0.5.2_dev
Provider: google-batch
Environment: Jupyter on Workbench (VPC-SC)
Results: 38 passed, 5 failed (out of 43 tests)
Failing Tests (5)
Important: All 5 failing tests also failed on 0.5.1/main branch. These are not regressions from 0.5.2 changes.
e2e_image.shValueError: --use-private-address must specify a --image with a gcr.io or pkg.dev hostbash:4.4,python:2-slim,python:3-slim) which can't be pulled with--use-private-addressin VPC-SC environmentse2e_verify_failure_log.shdstat_output: unbound variable(line 46)e2e_python_api.pyJobExecutionErrore2e_non_root.shJobExecutionErrore2e_requester_pays_buckets.shJobExecutionErrorTest Fixes Applied in This Branch
1. USER Variable Fix
Several tests failed with
USER: unbound variablein bash strict mode. Fixed by setting default:Files modified:
test/integration/io_setup.sh-${USER}→${USER:-jupyter}test/integration/io_tasks_setup.sh-${USER}→${USER:-jupyter}test/integration/e2e_logging_paths.sh-${USER}→${USER:-jupyter}test/integration/e2e_logging_paths_pattern_tasks.sh-${USER}→${USER:-jupyter}test/integration/test_setup.sh- Addedexport USER="${USER:-jupyter}"2. Python Test Setup Fix
Python tests (
e2e_*.py) were missing--service-accountand had hardcoded network settings.File modified:
test/integration/test_setup_e2e.pyGPU_NETWORK,GPU_SUBNETWORK,LOCATION,PET_SA_EMAILenvironment variables--service-accountflag whenPET_SA_EMAILis set3. Shell Test Setup Fix
Shell tests had hardcoded network settings that didn't work in VPC-SC.
File modified:
test/integration/test_setup.shGPU_NETWORK,GPU_SUBNETWORK,PET_SA_EMAIL,LOCATIONenvironment variablesVPC-SC Limitations
The following tests are expected to fail in VPC-SC environments:
e2e_image.sh- Uses public Docker Hub images which cannot be pulled when--use-private-addressis enabled. VPC-SC environments block access to public container registries.Any test using non-gcr.io/pkg.dev images - The
--use-private-addressflag requires images from Google Container Registry (gcr.io) or Artifact Registry (pkg.dev).Comparison to Previous Runs
| Run | Total | Passed | Failed | Notes |
| After cleanup fix | 43 | 38 | 5 | Current state |
Current explanations for the failing tests:
e2e_verify_failure_log.sh- Fix the unbound variable bug (pre-existing issue, separate PR)e2e_image.sh- Document as expected failure in VPC-SC, or mirror test images to GARJob execution failures (
e2e_python_api.py,e2e_non_root.sh,e2e_requester_pays_buckets.sh) - Investigate root cause, but these appear to be environmental rather than code issues