Skip to content

Fix non-functional Download and Copy buttons on HCA project matrices page #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix non-functional Download and Copy buttons on HCA project matrices page #4629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e1a84b
Initial plan
Copilot Dec 20, 2025
1743606
Fix FileLocationDownload and FileLocationCopy onClick handlers
Copilot Dec 20, 2025
dd2ee74
Remove requireLogin wrapper from matrix download/copy buttons
Copilot Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...etail/components/GeneratedMatricesTables/components/FileLocationCopy/fileLocationCopy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { ButtonGroupButton } from "@databiosphere/findable-ui/lib/components/common/ButtonGroup/components/ButtonGroupButton/buttonGroupButton";
import { ContentCopyIconSmall } from "@databiosphere/findable-ui/lib/components/common/CustomIcon/common/constants";
import { useFileLocation } from "@databiosphere/findable-ui/lib/hooks/useFileLocation";
import { useLoginGuard } from "@databiosphere/findable-ui/lib/providers/loginGuard/hook";
import copy from "copy-to-clipboard";
import { useEffect } from "react";
import { ProjectMatrixView } from "../../../../../../viewModelBuilders/azul/hca-dcp/common/projectMatrixMapper/entities";
Expand All @@ -16,9 +15,6 @@ export const FileLocationCopy = ({
const { url } = projectMatrixView;
const { fileUrl, isLoading, isSuccess, run } = useFileLocation(url);

// Prompt user for login before download, if required.
const { requireLogin } = useLoginGuard();

useEffect(() => {
if (fileUrl && isSuccess) {
copy(fileUrl);
Expand All @@ -30,7 +26,7 @@ export const FileLocationCopy = ({
action="Copy project matrix"
label={<ContentCopyIconSmall />}
loading={isLoading}
onClick={() => requireLogin(run)}
onClick={run}
/>
);
};
6 changes: 1 addition & 5 deletions ...mponents/GeneratedMatricesTables/components/FileLocationDownload/fileLocationDownload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { FileDownloadButton } from "@databiosphere/findable-ui/lib/components/co
import { ButtonGroupButton } from "@databiosphere/findable-ui/lib/components/common/ButtonGroup/components/ButtonGroupButton/buttonGroupButton";
import { DownloadIconSmall } from "@databiosphere/findable-ui/lib/components/common/CustomIcon/common/constants";
import { useFileLocation } from "@databiosphere/findable-ui/lib/hooks/useFileLocation";
import { useLoginGuard } from "@databiosphere/findable-ui/lib/providers/loginGuard/hook";
import { ProjectMatrixView } from "../../../../../../viewModelBuilders/azul/hca-dcp/common/projectMatrixMapper/entities";

export interface FileLocationDownloadProps {
Expand All @@ -15,16 +14,13 @@ export const FileLocationDownload = ({
const { fileName, url } = projectMatrixView;
const { fileUrl, isLoading, run } = useFileLocation(url);

// Prompt user for login before download, if required.
const { requireLogin } = useLoginGuard();

return (
<>
<ButtonGroupButton
action="Download project matrix"
label={<DownloadIconSmall />}
loading={isLoading}
onClick={() => requireLogin(run)}
onClick={run}
/>
<FileDownloadButton fileName={fileName} fileUrl={fileUrl} />
</>
Expand Down