Skip to content

Expose access to mirrored MA files via /repository/files (#7931) #8028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nadove-ucsc wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Expose access to mirrored MA files via /repository/files (#7931) #8028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/azul/indexer/mirror_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,14 +511,6 @@ def mirror_uri(self,
return None

def mirror_url(self, file: File) -> str | None:

# FIXME: Expose access to mirrored MA files via /repository/files
# https://github.com/DataBiosphere/azul/issues/7931
#
assert file.source is not None, file
if not self._is_public(file.source.spec):
return None

if self._info_exists(file):
storage = self._storage_for_file(file)
return storage.get_presigned_url(object_key=self._file_object_key(file),
Expand Down
7 changes: 6 additions & 1 deletion src/azul/service/lambda_iam_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@
],
'Resource': [
f'arn:aws:s3:::{resource}'
for bucket in alist(aws.mirror_bucket, config.mirror_bucket)
for bucket in alist(
aws.mirror_bucket,
config.mirror_bucket,
aws.ma_mirror_bucket,
config.ma_mirror_bucket
)
for resource in [bucket, f'{bucket}/*']
]
},
Expand Down
Loading