Skip to content

Security: Fix Wildcard CORS Configuration #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FinnBotOrca wants to merge 1 commit into from
Closed

Security: Fix Wildcard CORS Configuration #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions sdgsystem/app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
"""FastAPI application entry point."""
import os
from typing import List
from fastapi import FastAPI
from fastapi.middleware.cors import CORSMiddleware

Expand All @@ -10,13 +12,21 @@
version="1.0.0"
)

def get_allowed_origins() -> List[str]:
"""Get allowed origins from environment."""
origins_str = os.getenv(
"ALLOWED_ORIGINS",
"http://localhost:3000,http://localhost:5173" # Dev defaults
)
return [origin.strip() for origin in origins_str.split(",")]

# CORS middleware for frontend
app.add_middleware(
CORSMiddleware,
allow_origins=["*"],
allow_origins=get_allowed_origins(),
allow_credentials=True,
allow_methods=["*"],
allow_headers=["*"],
allow_methods=["GET", "POST", "PUT", "DELETE"],
allow_headers=["Content-Type", "Authorization"],
)

app.include_router(router)
Expand Down