Add a change password option to xiloader.#30
Open
mrhappyasthma wants to merge 1 commit intoDarkstarProject:masterfrom
Open
Add a change password option to xiloader.#30mrhappyasthma wants to merge 1 commit intoDarkstarProject:masterfrom
mrhappyasthma wants to merge 1 commit intoDarkstarProject:masterfrom
Conversation
This works by using the same login flow from before to validate the correct user. However instead of returning to connect to the game server, the user is prompted for a new password to set. I tested all code paths manually: error cases and succesful password changing cases. fixed DarkstarProject#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works by using the same login flow from before to validate the correct user. However instead of returning to connect to the game server, the user is prompted for a new password to set.
I tested all code paths manually: error cases and successful password changing cases.
(Note: I held off for some time on submitting this, as the state of https://github.com/DarkstarProject/darkstar was a bit unknown. This works with https://github.com/project-topaz/topaz and https://github.com/topaz-next/topaz as of project-topaz/topaz@821bcfe and topaz-next/topaz@821bcfe respectively. If you're still using the archived Darkstar project, then you can simply merge this pull request into your local branch: DarkstarProject/darkstar#6366)
fixed #7