performance: skip ToString with interpolated string#2175
Open
TimothyMakkison wants to merge 1 commit intoDapperLib:mainfrom
Open
performance: skip ToString with interpolated string#2175TimothyMakkison wants to merge 1 commit intoDapperLib:mainfrom
ToString with interpolated string#2175TimothyMakkison wants to merge 1 commit intoDapperLib:mainfrom
Conversation
mgravell
approved these changes
Jul 6, 2025
Member
mgravell
left a comment
There was a problem hiding this comment.
Yep, I'm very familiar with the joys of interpolated string internals (I was very recently proposing changes to /runtime in that area) - LGTM
Author
I wish the compiler were smart enough to do this by default for common types. I've done this exact same change so many times 😞 OOC how much focus does Dapper place on performance? Looking through the repository I can definitely see a couple of changes to remove redundant strings ie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interpolated string skips the
Guid.ToStringallocation by callingISpanFormattable.TryFormat