Fixes #142: Renamed filters module to resolve collision with netbox-branching#143
Fixes #142: Renamed filters module to resolve collision with netbox-branching#143arcticash wants to merge 1 commit intoDanSheps:mainfrom
Conversation
|
Updated the PR description to reflect the actual root cause being netbox-branching plugin and not netbox core as originally suspected |
|
Note - we are renaming this is in branching ; but for completeness, we should do both |
|
Tests failures are not related to this change, otherwise, this looks good to me. |
|
@jsenecal Can you fix the conflict? |
|
Hi @DanSheps this is not my work, I don't seem to have the rights to commit on @arcticash pr branch. |
|
Sorry, for some reason thought it was yours. If it doesn't get updated by eod I might close it out and redo it |
Head branch was pushed to by a user without write access
Pull request was closed
895ee21 to
fd4baf0
Compare
…filters.py and updated all {% load filters %} references
|
Not sure if this has already been included in a separate change but I've re-applied the module renaming on top of the latest changes to main |
Renamed netbox_lifecycle/templatetags/filters.py to netbox_lifecycle_filters.py and updated all {% load filters %} references.
This PR Fixes issue #142
Root Cause
The plugin's templatetag module
templatetags/filters.pyconflicts with netbox-branching (Thanks to @cruse1977 for the pointer!) as both usedutilities/templatetags/filters.py. The library from netbox-ranching is resolved first during{% load filters %}, meaningdate_badge_classis never found.Changes
netbox_lifecycle/templatetags/filters.pytonetbox_lifecycle/templatetags/netbox_lifecycle_filters.py{% load filters %}to{% load netbox_lifecycle_filters %}in all affected templatestests/test_templatetags.pyTesting
Tested against NetBox 4.5.4 and 4.5.5 with
netbox-lifecycle1.1.8 andnetbox-branching. Device detail pages now load correctly with lifecycle date badges rendering as expected.