Skip to content

Fix UI clipping on Withdraw screen for large text sizes #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DongJun-H wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix UI clipping on Withdraw screen for large text sizes #714

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2fb06e
[bug] Remove fixed button height to prevent text clipping with large …
DongJun-H Dec 17, 2025
d715851
[bug] Replace Row with FlowRow to support wrapping when text size inc…
DongJun-H Dec 17, 2025
9bfb6f2
[bug] Remove fixed button height to prevent text clipping with large …
DongJun-H Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions presentation/src/main/java/daily/dayo/presentation/screen/account/WithdrawScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,11 @@ import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.FlowRow
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.aspectRatio
import androidx.compose.foundation.layout.defaultMinSize
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
Expand Down Expand Up @@ -551,7 +553,7 @@ fun WithdrawHoldBottomSheet(
label = stringResource(id = content.cancelButtonTextResId),
modifier = Modifier
.weight(1f)
.height(52.dp),
.defaultMinSize(minHeight = 52.dp),
color = ButtonDefaults.buttonColors(
containerColor = PrimaryL3_F2FBF7,
contentColor = Primary_23C882
Expand All @@ -567,7 +569,7 @@ fun WithdrawHoldBottomSheet(
label = stringResource(id = content.confirmButtonTextResId),
modifier = Modifier
.weight(1f)
.height(52.dp),
.defaultMinSize(minHeight = 52.dp),
enabled = !(reason == WithdrawalReason.OTHER && otherReasonText.isBlank()),
color = ButtonDefaults.buttonColors(
containerColor = Primary_23C882,
Expand Down Expand Up @@ -669,7 +671,7 @@ fun WithdrawButton(
FilledRoundedCornerButton(
modifier = Modifier
.fillMaxWidth()
.height(52.dp),
.defaultMinSize(minHeight = 52.dp),
label = stringResource(R.string.withdraw_confirm),
color = ButtonDefaults.buttonColors(
containerColor = Primary_23C882,
Expand Down Expand Up @@ -814,30 +816,36 @@ private fun WithdrawGuideContentUI(
Spacer(modifier = Modifier.height(20.dp))
val guideStrings = words.ifEmpty { emptyList() }

Row(
FlowRow(
modifier = Modifier
.padding(bottom = 16.dp)
.wrapContentHeight()
.fillMaxWidth(),
horizontalArrangement = Arrangement.Center,
verticalAlignment = Alignment.CenterVertically,
verticalArrangement = Arrangement.Center
) {
guideStrings.forEachIndexed { index, guide ->
Text(
text = guide,
modifier = Modifier.align(Alignment.CenterVertically),
color = Gray1_50545B,
textAlign = TextAlign.Center,
style = DayoTheme.typography.caption4
style = DayoTheme.typography.caption4,
)
if (index != guideStrings.lastIndex) {
Spacer(modifier = Modifier.width(6.dp))
Spacer(modifier = Modifier
.width(6.dp)
.align(Alignment.CenterVertically))
Icon(
imageVector = ImageVector.vectorResource(R.drawable.ic_arrow_right),
contentDescription = null,
modifier = Modifier
.size(12.dp)
.align(Alignment.CenterVertically),
tint = Gray3_9FA5AE,
modifier = Modifier.size(12.dp)
)
Spacer(modifier = Modifier.width(6.dp))
Spacer(modifier = Modifier
.width(6.dp)
.align(Alignment.CenterVertically))
}
}
}
Expand Down