Skip to content

Conversation

@guysmoilov
Copy link
Member

For consumption by LLMs.

@guysmoilov guysmoilov added the documentation Improvements or additions to documentation label Feb 5, 2025
@guysmoilov guysmoilov requested a review from kbolashev February 5, 2025 13:56
@guysmoilov guysmoilov self-assigned this Feb 5, 2025
@dagshub
Copy link

dagshub bot commented Feb 5, 2025

Comment on lines 20 to 22
try:
docstring = pydoc.plain(pydoc.render_doc(module_name))
out_f.write(docstring)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will ignore all of the :meta private tags I have on private functions that users aren't supposed to be using
Don't care about it that much, but I am concerned of LLMs abusing private things in the library.
Remains to be seen i guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably less important for LLMs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably less important for LLMs

In my opinion this is actually MUCH MORE important for LLMs, because if the docs show up there, LLM will just pick it up and regurgitate to the user, and then the user ends up writing code that mangles private things that shouldn't be mangled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try to find a possible solution, probably not easy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's a point in worrying about it yet, and if we have users complaining about these functions/fields changing we can tell them that they're intended to be private.

Copy link
Member

@kbolashev kbolashev Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realizing that it might be even worse, because I have some files where I have docs that I didn't bother to hide with :meta private, but are still very internal and just not showing up in the sphinx docs because I didn't add them.
Example: https://github.com/DagsHub/client/blob/master/dagshub/data_engine/client/data_client.py
this is the GraphQL data layer, which is not intended to be used directly

@kbolashev
Copy link
Member

disregard the failing 3.8 test, that's a weird flaky test that I didn't manage to pinpoint yet. Rarely shows up

@guysmoilov guysmoilov requested a review from kbolashev February 5, 2025 14:08
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the lint (you can run ruff fmt or black) and feel free to merge

@kbolashev kbolashev changed the base branch from master to main July 20, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants