Change fixed_time_eq to avoid undefined behavior#461
Open
jaysonsantos wants to merge 1 commit intoDaGenix:masterfrom
Open
Change fixed_time_eq to avoid undefined behavior#461jaysonsantos wants to merge 1 commit intoDaGenix:masterfrom
jaysonsantos wants to merge 1 commit intoDaGenix:masterfrom
Conversation
If both slices have len() == 0, get_unchecked will have an undefined behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If both slices have
len() == 0, I think that get_unchecked will have undefined behavior.I'd say that this is the type of operation that the gain of not checking the boundaries for the first element does not justify the usage of unsafe there, what do you think?