Skip to content

Update the life stage of upper vines in onRemove instead of destroy #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaFuqs merged 1 commit into from
Jan 16, 2026
Merged

Update the life stage of upper vines in onRemove instead of destroy #807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/main/java/de/dafuqs/spectrum/blocks/deeper_down/flora/TriStateVineBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,17 +144,20 @@ protected int getCurrentHeight(Level world, BlockPos pos) {

return count;
}

@Override
public void destroy(LevelAccessor world, BlockPos pos, BlockState state) {
var roof = BlockReference.of(world, pos.above());

if (roof.isOf(this)) {
roof.setProperty(LIFE_STAGE, getLowestLifeStage(world, pos.below(), state.getValue(LIFE_STAGE)));
roof.update(world);
}

scheduleBreakCheck(world, pos);

@Override
protected void onRemove(BlockState state, Level level, BlockPos pos, BlockState newState, boolean movedByPiston) {
if (!state.is(newState.getBlock())) {
var roof = BlockReference.of(level, pos.above());

if (roof.isOf(this)) {
roof.setProperty(LIFE_STAGE, getLowestLifeStage(level, pos.below(), state.getValue(LIFE_STAGE)));
roof.update(level);
}

scheduleBreakCheck(level, pos);
}
super.onRemove(state, level, pos, newState, movedByPiston);
}

public LifeStage getLowestLifeStage(LevelAccessor world, BlockPos pos, LifeStage stage) {
Expand Down