Skip to content

Conversation

@AsaNehm
Copy link
Contributor

@AsaNehm AsaNehm commented Oct 7, 2025

To allow for seamless plots on the updated DUNE slides template, this adds the option to change the background color of plots to the same off-white (#f0f0f0) color.

Function is called off_white.bkg and would be called like the other dunestyle functions

To allow for seamless plots on the updated DUNE slides template, this adds the option to change the background color of plots to the same off-white (#f0f0f0) color.
Function is called off_white.bkg and would be called like the other dunestyle functions
@AsaNehm AsaNehm requested a review from chenel October 7, 2025 10:05
@AsaNehm AsaNehm self-assigned this Oct 7, 2025
@AsaNehm AsaNehm added the enhancement New feature or request label Oct 7, 2025
@chenel
Copy link
Collaborator

chenel commented Oct 7, 2025

I added a commit with a ROOT variant as well.

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Oct 7, 2025

My plan was to implement this in different PRs for the different languages, but can change this of course

@AsaNehm
Copy link
Contributor Author

AsaNehm commented Oct 7, 2025

There is the PyROOT version left to do. Would you implement this as well?

@chenel
Copy link
Collaborator

chenel commented Oct 7, 2025

There is the PyROOT version left to do. Would you implement this as well?

PyROOT should come "for free"---all the functions from DUNEStyle.h get exposed via the interface. I haven't checked that yet, but I will as soon as I get all the typos I introduced into the PR sorted 🙃

Copy link
Collaborator

@chenel chenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this! 👍🏻

Copy link
Contributor

@admlw admlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@chenel chenel merged commit 8446b43 into main Oct 7, 2025
3 checks passed
@chenel chenel deleted the AsaNehm-patch-1 branch October 7, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants