fix setup of Okabe-Ito custom colors #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admlw
approved these changes
Feb 12, 2025
Contributor
admlw
left a comment
admlw
left a comment
There was a problem hiding this comment.
This looks fine to me, and looks like Jake was able to test it and it works 👌🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though in principle stuff that's all in the same translation unit should be initialized in order of appearance, the Okabe-Ito custom
TColorinstances seem not to have been fully initialized by the time they are stored in their color cycler. This PR packs them away into a function, in the same way the Static Initialization Order Fiasco is usually worked around. That seems to solve it.