PR for merging 'BSM Window' TAMaker code to triggeralgs #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Created a nicer class interface for Treelite inference. Some commented outputs still there as further testing is still needed. Can now be run successfully with trgtools along with other algorithms.
…ength in time. Not too successful yet.
…with compiled treelite model.
…custom branch of detchannelmaps.
treelite model is no-longer global c-style code. Treelite model is now in c++ style with a namespace and class structure. The detector plane mapping has now been separated into a separate file and struct object. The channel map is now a configurable parameter.
Author
|
New commit pushed to this branch. Improvements to style and robustness. Compiled treelite model is no-longer global c-style code. Treelite model code is now in c++ style with a namespace and class structure. The detector plane mapping has now been separated into a separate file and struct object. The channel map is now a configurable parameter. |
…ying up of code and style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for additional TAMaker and TCMaker to triggeralgs. This is called "BSM Window". The additions are independent of other code in this repository and does not rely on specific versions of other repositories in DUNE DAQ. It runs a compiled XGBoost BDT in a TAMaker algorithm. There is a TCMaker, but this is largely a place-holder and does not actually do anything difference from the ADCSimpleWindow TCMaker. In fact, I just use the ADCSimpleWindow TCMaker in my tests of this algorithm. This TAMaker has been tested in the DAQ replay app.