Provide the ability to delete (remove) HDF5 files at the end of integration tests#157
Open
bieryAtFnal wants to merge 8 commits into
Open
Provide the ability to delete (remove) HDF5 files at the end of integration tests#157bieryAtFnal wants to merge 8 commits into
bieryAtFnal wants to merge 8 commits into
Conversation
added 5 commits
May 20, 2026 10:08
…o help make their meaning more clear.
…y to allow users to request that the HDF5 files created in integtests get removed at the end of the test.
…e used by many/all integtests to accomplish common functionality. It will take over basic_checks.py
…figResult attribute names and store the value of the --remove-hdf5-files command-line option in the run_dunerc result so that it can be used by integtests and utility_functions::remove_hdf5_files_if_requested()
…hdf5_files_if_requested() to try to make its meaning more clear
3 tasks
This was referenced May 26, 2026
…ify true, nothing, or false. In this way, HDF5 files can be kept in special situations.
Contributor
Author
|
Sorry for the last-minute change. I realized that it might be helpful to request that HDF5 files be kept on disk in certain situations, despite what the integtest writer specified. (That's in addition to the ability to request that HDF5 files be deleted in certain situations.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The primary change covered by this Pull Request is the addition of common utility that will remove HDF5 files at the end of each regression/integration test based on directives from within each integtest and from a command-line option that can be specified when each integtest is run.
Some additional changes that were made:
CreateConfigResultdata class were modified to try to make their meaning more clear--remove-hdf5-files" command-line option was addedutility_functions.py" file was added and the pre-existing "basic_checks" function was copied from a dedicated file into this "utility" file, with the goal of getting rid of that dedicated "basic_checks" file soonAs part of this work, corresponding changes were made to the integration tests in various repositories. Those changes are covered by the following PRs:
Here is a suggested set of steps for testing these changes:
For reference, here is a sample
pytest"test" that provides the hooks for removing (deleting) HDF5 files at the end of an integtest:The flag that is specified in the
remove_hdf5_files_if_requested()call is what the integrationtest developer feels is the best option. In any case, the presence of this function call in the integtest enables the ability for end users to request that the HDF5 files get removed by specifying the '--remove-hdf5-files' pytest option when the test is run.Type of change
Testing checklist
pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)