Skip to content

Conversation

@jcfreeman2
Copy link
Contributor

With fddaq-v5.5.0 now cut, this source branch consists of a fork of the develop branch with prep-release/fddaq-v5.5.0 merged in (i.e., this will be a fast-forward merge which brings the fddaq-v5.5.0 code into develop). Over the weekend a test nightly was created, MRGFD_DEV_251213_A9, in which all the johnfreeman/prep_release_merged branches were used, and if I pip install -U . the johnfreeman/prep_release_merged branch of drunc, integration tests with it look fine.

Description

If full decription and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.

Addresses issue #

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcfreeman2
Copy link
Contributor Author

n.b. The reason for the single repo CI workflow failure isn't due to the code itself, but because the fact that there's a johnfreeman/prep_release_merged branch of dbe means that dbe gets built, but fails because Qt would need to be specially loaded in for dbe.

Copy link
Contributor

@andrewmogan andrewmogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jcfreeman2 jcfreeman2 merged commit 478435a into develop Dec 15, 2025
3 of 4 checks passed
@jcfreeman2 jcfreeman2 deleted the johnfreeman/prep_release_merged branch December 15, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants