perf(evm): add keccak cache to interpreter and extract shared header#420
Open
starwarfan wants to merge 1 commit intoDTVMStack:mainfrom
Open
perf(evm): add keccak cache to interpreter and extract shared header#420starwarfan wants to merge 1 commit intoDTVMStack:mainfrom
starwarfan wants to merge 1 commit intoDTVMStack:mainfrom
Conversation
3f4dde7 to
82b09d7
Compare
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
Reuse keccak256 results for repeated inputs (e.g. storage slot keys in ERC20 transfer) via a 16-slot thread-local circular buffer cache. Extracts KeccakCache into shared header src/evm/keccak_cache.h so both interpreter and multipass paths use the same implementation. ERC20 transfer benchmark: ~5376ns -> ~4798ns (-10.7%) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
82b09d7 to
04c4c79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse keccak256 results for repeated inputs (e.g. storage slot keys in ERC20 transfer) via a 16-slot thread-local circular buffer cache. Extracts KeccakCache into shared header src/evm/keccak_cache.h so both interpreter and multipass paths use the same implementation.
ERC20 transfer benchmark: ~5376ns -> ~4798ns (-10.7%)
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note