Skip to content

Show Shared Submission menu even if user is not submitter #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdamF42 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Open

Show Shared Submission menu even if user is not submitter #5630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5622416
[DURACOM-476] fix to show other workspace configuration
AdamF42 May 6, 2026
5ed265b
[DURACOM-476] test fix
AdamF42 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/my-dspace-page/my-dspace-configuration.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ describe('MyDSpaceConfigurationService', () => {
b: [
MyDSpaceConfigurationValueType.SupervisedItems,
MyDSpaceConfigurationValueType.Workflow,
MyDSpaceConfigurationValueType.OtherWorkspace,
],
}));
});
Expand All @@ -223,6 +224,7 @@ describe('MyDSpaceConfigurationService', () => {
b: [
MyDSpaceConfigurationValueType.SupervisedItems,
MyDSpaceConfigurationValueType.Workflow,
MyDSpaceConfigurationValueType.OtherWorkspace,
],
}));
});
Expand All @@ -237,9 +239,9 @@ describe('MyDSpaceConfigurationService', () => {
expect(list$).toBeObservable(cold('(b|)', {
b: [
MyDSpaceConfigurationValueType.Workspace,
MyDSpaceConfigurationValueType.OtherWorkspace,
MyDSpaceConfigurationValueType.SupervisedItems,
MyDSpaceConfigurationValueType.Workflow,
MyDSpaceConfigurationValueType.OtherWorkspace,
],
}));
});
Expand Down
2 changes: 1 addition & 1 deletion src/app/my-dspace-page/my-dspace-configuration.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,12 @@ export class MyDSpaceConfigurationService extends SearchConfigurationService {
const availableConf: MyDSpaceConfigurationValueType[] = [];
if (isSubmitter) {
availableConf.push(MyDSpaceConfigurationValueType.Workspace);
availableConf.push(MyDSpaceConfigurationValueType.OtherWorkspace);
}
if (isController || isAdmin) {
availableConf.push(MyDSpaceConfigurationValueType.SupervisedItems);
availableConf.push(MyDSpaceConfigurationValueType.Workflow);
}
availableConf.push(MyDSpaceConfigurationValueType.OtherWorkspace);
return availableConf;
}));
}
Expand Down
6 changes: 3 additions & 3 deletions src/app/submission/submission.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ describe('SubmissionService', () => {

const searchService = getMockSearchService();

const requestServce = getMockRequestService();
const requestService = getMockRequestService();

beforeEach(waitForAsync(() => {
itemService = new ItemDataServiceStub();
Expand All @@ -432,7 +432,7 @@ describe('SubmissionService', () => {
{ provide: SubmissionRestService, useValue: restService },
{ provide: ActivatedRoute, useValue: new MockActivatedRoute() },
{ provide: SearchService, useValue: searchService },
{ provide: RequestService, useValue: requestServce },
{ provide: RequestService, useValue: requestService },
{ provide: SubmissionJsonPatchOperationsService, useValue: submissionJsonPatchOperationsService },
{ provide: ItemDataService, useValue: itemService },
NotificationsService,
Expand Down Expand Up @@ -980,6 +980,7 @@ describe('SubmissionService', () => {
it('should redirect to Item page', fakeAsync(() => {
scheduler = getTestScheduler();

(requestService.setStaleByHrefSubstring as jasmine.Spy).calls.reset();
const itemUuid = 'd62fc60f-e9a5-48e6-973a-90819acf23ae';
const mockBundle = Object.assign(new Bundle(), {
_links: {
Expand All @@ -999,7 +1000,6 @@ describe('SubmissionService', () => {
});
let itemSubmissionId = itemUuid + ':FULL';
spyOn(itemService as any, 'findById').and.returnValue(cold('a', { a: createSuccessfulRemoteDataObject(mockItem) }));
spyOn(requestServce as any, 'setStaleByHrefSubstring').and.returnValue(cold('a', { a: true }));

scheduler.schedule(() => service.invalidateCacheAndRedirectToItemPage(itemSubmissionId));
scheduler.flush();
Expand Down
Loading