Align viewport meta with the canonical width=device-width, initial-scale=1 pattern#5609
Draft
bram-atmire wants to merge 1 commit intoDSpace:mainfrom
Draft
Align viewport meta with the canonical width=device-width, initial-scale=1 pattern#5609bram-atmire wants to merge 1 commit intoDSpace:mainfrom
bram-atmire wants to merge 1 commit intoDSpace:mainfrom
Conversation
…ale=1 pattern The previous value `width=device-width,minimum-scale=1` worked correctly with the project's responsive CSS, but diverged from the documented best-practice shipped by Bootstrap 5 starters and the Angular CLI default. `initial-scale=1` guarantees the page renders at 100% on first paint across mobile browsers and embedded WebViews; dropping `minimum-scale=1` removes the unneeded pinch-zoom-out restriction. References DSpace#5604
lgeggleston
added
improvement
accessibility
1 APPROVAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Align the viewport meta tag with the canonical
width=device-width, initial-scale=1pattern used by Bootstrap 5 starters and the Angular CLI default.Instructions for Reviewers
List of changes in this PR:
src/index.html— viewport meta updated fromwidth=device-width,minimum-scale=1towidth=device-width, initial-scale=1.How to test:
main, the project renders correctly on every modern browser tested. This change is hygiene: it brings the meta tag in line with the documented best-practice and removes aminimum-scale=1restriction that pinch-zoom-disables on some mobile browsers. Verify the homepage and an item page on a mobile browser still render at 100% on first paint and that pinch-zoom now works without the artificial floor.This is not fixing a current WCAG failure — see the issue for the full rationale.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation. (n/a)