fix #5488: add ARIA labeling to hide edit menu from screen readers wh…

[guillermo-escire]

References

Fixes #5488

Description

Adds dynamic ARIA labeling to the DSO edit menu so that when a user has no edit permissions, the menu is hidden from screen readers and the role="menubar" attribute is removed, preventing the broken ARIA menu error detected by the WAVE accessibility tool.

Instructions for Reviewers

List of changes in this PR:

• dso-edit-menu.component.html: role="menubar" is now dynamic — only applied when the menu has visible subsections. Added aria-hidden="true" when no subsections are visible.
• dso-edit-menu.component.ts: Added menuVisibleWithSections$ observable that checks real subsections with permissions via getSubSectionsByParentID.
• dso-edit-menu.component.spec.ts: Added tests to verify DOM behavior for both cases.

How to test:

1. Install the WAVE browser extension
2. Navigate to any community or item page without being logged in
3. Run WAVE — the Broken ARIA menu error should no longer appear
4. Log in as an admin and navigate to the same pages — the edit menu (three dots) should still appear and work correctly

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[bram-atmire]

Hi @guillermo-escire, thanks for picking #5488 up.

While preparing a wider accessibility-audit follow-up I noticed your PR fixes the case where the dso-edit-menu <div role="menubar"> is rendered but empty/hidden, which is one of the issues axe flagged on community + item pages. There are four more ARIA issues from the same audit that #5488 originally also covers but that this PR does not address:

1. ds-auth-nav-menu login dropdown trigger has aria-haspopup="menu" but opens a <div role="dialog" aria-modal="true">. Screen readers announce "has popup, menu" and then reveal a dialog.
2. ds-expandable-navbar-section toggler is <a href="javascript:void(0);" role="menuitem">. The href="javascript:void(0)" is an HTML antipattern; the element should be a <button>.
3. ds-context-help-toggle is also <a href="javascript:void(0);" role="menuitem"> and additionally is not nested inside any role="menu"/menubar" , so the menuitem role is an orphan and axe fires aria-required-parent on it.
4. When the menubar role IS rendered (your case), the descendants of dso-edit-menu are still plain <a class="btn"> / <button class="btn"> without role="menuitem", so axe still fires aria-required-children on it.

Rather than asking you to expand this PR, I have opened a separate complementary PR (#5611) that scopes those four remaining changes. They sit cleanly on top of main and on top of yours, so when both merge, #5488 fully closes.

Note: my PR is in draft for now, pending an internal review.

[guillermo-escire]

Hi @bram-atmire, thank you for the detailed review and for opening the complementary PR #5611 to cover the remaining ARIA issues. I'm glad this PR addresses the main case from #5488. Please let me know if there's anything else you'd like me to adjust on my end before this gets merged.