Skip to content

Comments

Update Cypress section in README.md#5154

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
MMilosz:chore/readme-fix-cypress-section
Feb 24, 2026
Merged

Update Cypress section in README.md#5154
tdonohue merged 1 commit intoDSpace:mainfrom
MMilosz:chore/readme-fix-cypress-section

Conversation

@MMilosz
Copy link
Contributor

@MMilosz MMilosz commented Feb 24, 2026

References

Description

This PR:

  • changes references ./cypress/integration/ to ./cypress/e2e/
  • fixes the description mismatch between ./cypress/e2e/ & ./cypress/fixtures/ directories

In 7.6.0 (PR #2127), there was an upgrade to Cypress 12 for e2e tests that changed file structure under ./cypress/ dir, but there were no changes to README.md file:

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

- In 7.6.0, ./cypress/integration/ dir was renamed to ./cypress/e2e/
- Related PR: DSpace#2127
@MMilosz MMilosz added the documentation Ticket describes improvements or additions to documentation label Feb 24, 2026
@lgeggleston lgeggleston added 1 APPROVAL pull request only requires a single approval to merge testing framework Related specifically to Unit or Integration (e2e) Tests labels Feb 24, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 24, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for getting these docs updated, @MMilosz !

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Feb 24, 2026
@tdonohue tdonohue added this to the 10.0 milestone Feb 24, 2026
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Feb 24, 2026
@tdonohue tdonohue merged commit ddac164 into DSpace:main Feb 24, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Feb 24, 2026
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Feb 24, 2026
@MMilosz MMilosz deleted the chore/readme-fix-cypress-section branch February 24, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge documentation Ticket describes improvements or additions to documentation testing framework Related specifically to Unit or Integration (e2e) Tests

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants